Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon MQ (broker + configuration) #2466

Merged
merged 3 commits into from
Nov 29, 2017
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 29, 2017

Depends on #2465 (I'll rebase this PR after merging)

Also I'm breaching the etiquette here a little by submitting multiple new resources in a single PR, but the code was already more-or-less reviewed in a private fork where we were developing this prior to public announcement of the service yesterday at re:invent.

Test results

TF_ACC=1 go test ./aws -v -run=TestAccAwsMq -timeout 120m
=== RUN   TestAccAwsMqBroker_basic
--- PASS: TestAccAwsMqBroker_basic (1145.34s)
=== RUN   TestAccAwsMqBroker_allFields
--- PASS: TestAccAwsMqBroker_allFields (2114.92s)
=== RUN   TestAccAwsMqBroker_updateUsers
--- PASS: TestAccAwsMqBroker_updateUsers (1568.25s)
=== RUN   TestAccAwsMqConfiguration_basic
--- PASS: TestAccAwsMqConfiguration_basic (49.94s)
=== RUN   TestAccAwsMqConfiguration_withData
--- PASS: TestAccAwsMqConfiguration_withData (21.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4899.602s

@radeksimko radeksimko added the new-resource Introduces a new resource. label Nov 29, 2017
@radeksimko radeksimko requested a review from catsby November 29, 2017 14:30
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 pending rebase on that other PR and the vendor changes here go away with it

@radeksimko radeksimko merged commit 84f9d90 into master Nov 29, 2017
@radeksimko radeksimko deleted the f-r-mq branch November 29, 2017 15:50
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-resource Introduces a new resource.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants