Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of acctest.Providers with acctest.ProviderFactories #24680

Merged
merged 157 commits into from
May 6, 2022
Merged

Replace use of acctest.Providers with acctest.ProviderFactories #24680

merged 157 commits into from
May 6, 2022

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24500.

ewbankkit added 30 commits May 6, 2022 09:17
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for accessanalyzer.
f4a2bcf
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for acm.
7bcdce2
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for acmpca.
b0bb87f
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for amp.
954748f
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for amplify.
abf8758
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for apigateway.
8cd93ae
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for apigatewayv2.
0cf96a1
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for appautoscaling.
d9396bb
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for appconfig.
d269097
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for appmesh.
1d80322
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for apprunner.
4249639
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for appsync.
d0c7ed2
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for athena.
6c02cfa
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for autoscaling.
62a1d90
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for autoscalingplans.
2d96f04
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for backup.
c7118ba
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for batch.
54586eb
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for budgets.
e8f35db
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for chime.
54a4cfc
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for cloud9.
ecd5382
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for cloudformation.
53fa599
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for cloudfront.
13146dc
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for cloudhsmv2.
6940beb
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for cloudsearch.
9ff9848
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for cloudtrail.
cf28c45
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for cloudwatch.
fcdd1b4
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for codeartifact.
1f4f634
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for codebuild.
84250cd
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for codecommit.
037a7a8
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for codepipeline.
5b83496
ewbankkit added 19 commits May 6, 2022 09:18
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for ssoadmin.
29c5b96
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for storagegateway.
3cc1b5c
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for sts.
1b7f60d
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for swf.
c784524
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for synthetics.
db96556
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for timestreamwrite.
4a33bf7
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for transfer.
7387dfd
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for waf.
1c18330
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for wafregional.
2dc51b2
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for wafv2.
dbbb0ab
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for worklink.
7396f95
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for workspaces.
8383d16
@ewbankkit
'acctest.Providers' -> 'acctest.ProviderFactories' for xray.
c24daac
@ewbankkit
'Providers' -> 'ProviderFactories' for acctest.
24a55ec
@ewbankkit
Add semgrep 'use-acctest-provider-factories' rule.
662fa37
@ewbankkit
Add '.semgrepignore' that includes '*_test.go'.
aa706b3
@ewbankkit
Fix semgrep 'use-error-code-equals-if-not-checking-message'.
6328790
@ewbankkit
Suppress semgrep 'acceptance-test-naming-parent-disappears'.
a30443c
@ewbankkit
Exclude 'internal/service/route53domains/registered_domain_test.go' f…
10c4e7c 
…rom semgrep 'email-address' rule.
@github-actions github-actions bot added the size/XL Managed by automation to categorize the size of a PR. label May 6, 2022
@ewbankkit ewbankkit added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels May 6, 2022
@ewbankkit ewbankkit merged commit 2f94715 into main May 6, 2022
@ewbankkit ewbankkit deleted the td-acctest.Providers-to-acctest.ProviderFactories branch May 6, 2022 18:16
@github-actions github-actions bot added this to the v4.14.0 milestone May 6, 2022
@github-actions
Copy link

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
size/XL Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.14.0
Development

Successfully merging this pull request may close these issues.

Tech Debt: Replace use of acctest.Providers with acctest.ProviderFactories
1 participant
@ewbankkit