Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/servicecatalog_provisioned_product: remove waiter from read CRUD op to prevent irreversible state #24758

Merged
merged 2 commits into from
May 12, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented May 12, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24574

Output from acceptance testing:

 make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_' PKG=servicecatalog
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20  -run=TestAccServiceCatalogProvisionedProduct_ -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_update
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_update
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (137.02s)
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (145.85s)
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (238.49s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (242.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	246.290s

@github-actions github-actions bot added service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/S Managed by automation to categorize the size of a PR. labels May 12, 2022
@anGie44 anGie44 force-pushed the b-servicecatalog-provisioned-product-wait-for-status branch from df9408c to 3a2b0f1 Compare May 12, 2022 18:23
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels May 12, 2022
@anGie44 anGie44 force-pushed the b-servicecatalog-provisioned-product-wait-for-status branch from 3a2b0f1 to 762ac92 Compare May 12, 2022 18:37
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels May 12, 2022
@anGie44 anGie44 marked this pull request as ready for review May 12, 2022 18:49
@anGie44 anGie44 changed the title r/servicecatalog_provisioned_product: remove waiter from read CRUD to prevent irreversible state r/servicecatalog_provisioned_product: remove waiter from read CRUD op to prevent irreversible state May 12, 2022
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label May 12, 2022
@anGie44 anGie44 force-pushed the b-servicecatalog-provisioned-product-wait-for-status branch from deef51e to 3d48a64 Compare May 12, 2022 19:19
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalogProvisionedProduct_' PKG=servicecatalog ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 2  -run=TestAccServiceCatalogProvisionedProduct_ -timeout 180m
=== RUN   TestAccServiceCatalogProvisionedProduct_basic
=== PAUSE TestAccServiceCatalogProvisionedProduct_basic
=== RUN   TestAccServiceCatalogProvisionedProduct_update
=== PAUSE TestAccServiceCatalogProvisionedProduct_update
=== RUN   TestAccServiceCatalogProvisionedProduct_disappears
=== PAUSE TestAccServiceCatalogProvisionedProduct_disappears
=== RUN   TestAccServiceCatalogProvisionedProduct_tags
=== PAUSE TestAccServiceCatalogProvisionedProduct_tags
=== CONT  TestAccServiceCatalogProvisionedProduct_basic
=== CONT  TestAccServiceCatalogProvisionedProduct_disappears
--- PASS: TestAccServiceCatalogProvisionedProduct_disappears (138.91s)
=== CONT  TestAccServiceCatalogProvisionedProduct_tags
--- PASS: TestAccServiceCatalogProvisionedProduct_basic (151.83s)
=== CONT  TestAccServiceCatalogProvisionedProduct_update
--- PASS: TestAccServiceCatalogProvisionedProduct_tags (246.87s)
--- PASS: TestAccServiceCatalogProvisionedProduct_update (281.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	440.269s

@anGie44 anGie44 added this to the v4.14.0 milestone May 12, 2022
@anGie44 anGie44 merged commit 0e390ab into main May 12, 2022
@anGie44 anGie44 deleted the b-servicecatalog-provisioned-product-wait-for-status branch May 12, 2022 20:05
github-actions bot pushed a commit that referenced this pull request May 12, 2022
@github-actions
Copy link

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

ewbankkit added a commit that referenced this pull request May 13, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants