r/redshift_event_subscription - use finder + validations

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTS=TestAccRedshiftEventSubscription_ PKG=redshift
--- PASS: TestAccRedshiftEventSubscription_disappears (33.01s)
--- PASS: TestAccRedshiftEventSubscription_withSourceIDs (60.67s)
--- PASS: TestAccRedshiftEventSubscription_basic (62.88s)
--- PASS: TestAccRedshiftEventSubscription_categoryUpdate (63.63s)
--- PASS: TestAccRedshiftEventSubscription_tags (88.79s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftEventSubscription_' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftEventSubscription_ -timeout 180m
=== RUN   TestAccRedshiftEventSubscription_basic
=== PAUSE TestAccRedshiftEventSubscription_basic
=== RUN   TestAccRedshiftEventSubscription_withSourceIDs
=== PAUSE TestAccRedshiftEventSubscription_withSourceIDs
=== RUN   TestAccRedshiftEventSubscription_categoryUpdate
=== PAUSE TestAccRedshiftEventSubscription_categoryUpdate
=== RUN   TestAccRedshiftEventSubscription_tags
=== PAUSE TestAccRedshiftEventSubscription_tags
=== RUN   TestAccRedshiftEventSubscription_disappears
=== PAUSE TestAccRedshiftEventSubscription_disappears
=== CONT  TestAccRedshiftEventSubscription_basic
=== CONT  TestAccRedshiftEventSubscription_tags
--- PASS: TestAccRedshiftEventSubscription_basic (42.31s)
=== CONT  TestAccRedshiftEventSubscription_categoryUpdate
--- PASS: TestAccRedshiftEventSubscription_tags (58.49s)
=== CONT  TestAccRedshiftEventSubscription_withSourceIDs
--- PASS: TestAccRedshiftEventSubscription_categoryUpdate (39.08s)
=== CONT  TestAccRedshiftEventSubscription_disappears
--- PASS: TestAccRedshiftEventSubscription_withSourceIDs (37.32s)
--- PASS: TestAccRedshiftEventSubscription_disappears (19.48s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	107.931s

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[ewbankkit]

% make providerlint && make golangci-lint                                
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

[github-actions]

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.