Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Context' as an optional parameter for Auto Scaling 'CreateAutoScalingGroup' #24951

Closed
wants to merge 1 commit into from
Closed

Add 'Context' as an optional parameter for Auto Scaling 'CreateAutoScalingGroup' #24951

wants to merge 1 commit into from

Conversation

gjmveloso
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24943

Output from acceptance testing:

$ make testacc TESTS=TestAccAutoScalingGroup_basic PKG=autoscaling
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 5 -run='TestAccAutoScalingGroup_basic'  -timeout 180m
=== RUN   TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== CONT  TestAccAutoScalingGroup_basic
--- PASS: TestAccAutoScalingGroup_basic (264.39s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling268.769s
...

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/autoscaling Issues and PRs that pertain to the autoscaling service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 23, 2022
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels May 24, 2022
ewbankkit added a commit to cjerad/terraform-provider-aws that referenced this pull request May 25, 2022
@ewbankkit
Copy link
Contributor

ewbankkit commented May 25, 2022

@gjmveloso Thanks for the contribution 🎉 👏.
I have rolled this change into #24795.

@ewbankkit ewbankkit closed this May 25, 2022
@gjmveloso gjmveloso deleted the ec2/autoscaling_context branch May 26, 2022 20:50
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 26, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support optional Context for EC2 Auto Scaling
3 participants