rd/redshift_cluster - add missing arguments + attributes

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #24396
Closes #22819
Closes #18171
Output from acceptance testing:

$ make testacc TESTS=TestAccRedshiftClusterDataSource_basic PKG=redshift
--- PASS: TestAccRedshiftClusterDataSource_basic (280.85s)

make testacc TESTS=TestAccRedshiftCluster_basic PKG=redshift
--- PASS: TestAccRedshiftCluster_basic (190.21s)

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRedshiftClusterDataSource_\|TestAccRedshiftCluster_basic' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftClusterDataSource_\|TestAccRedshiftCluster_basic -timeout 180m
=== RUN   TestAccRedshiftClusterDataSource_basic
=== PAUSE TestAccRedshiftClusterDataSource_basic
=== RUN   TestAccRedshiftClusterDataSource_vpc
=== PAUSE TestAccRedshiftClusterDataSource_vpc
=== RUN   TestAccRedshiftClusterDataSource_logging
=== PAUSE TestAccRedshiftClusterDataSource_logging
=== RUN   TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== PAUSE TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
=== RUN   TestAccRedshiftCluster_basic
=== PAUSE TestAccRedshiftCluster_basic
=== CONT  TestAccRedshiftClusterDataSource_basic
=== CONT  TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled
--- PASS: TestAccRedshiftClusterDataSource_basic (236.12s)
=== CONT  TestAccRedshiftCluster_basic
--- PASS: TestAccRedshiftClusterDataSource_availabilityZoneRelocationEnabled (316.41s)
=== CONT  TestAccRedshiftClusterDataSource_logging
--- PASS: TestAccRedshiftCluster_basic (340.73s)
=== CONT  TestAccRedshiftClusterDataSource_vpc
--- PASS: TestAccRedshiftClusterDataSource_logging (267.93s)
--- PASS: TestAccRedshiftClusterDataSource_vpc (290.44s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	871.293s

[ewbankkit]

After merge:

% make testacc TESTARGS='-run=TestAccRedshiftClusterDataSource_vpc' PKG=redshift ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshift/... -v -count 1 -parallel 2  -run=TestAccRedshiftClusterDataSource_vpc -timeout 180m
=== RUN   TestAccRedshiftClusterDataSource_vpc
=== PAUSE TestAccRedshiftClusterDataSource_vpc
=== CONT  TestAccRedshiftClusterDataSource_vpc
--- PASS: TestAccRedshiftClusterDataSource_vpc (251.29s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/redshift	257.585s

[ewbankkit]

% make providerlint && make golangci-lint
==> Checking source code with providerlint...
==> Checking source code with golangci-lint...

[ewbankkit]

@DrFaust92 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.16.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.