Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(beanstalk-env): polling_interval validation #25084

Closed
wants to merge 1 commit into from

Conversation

egarbi
Copy link
Contributor

@egarbi egarbi commented May 27, 2022

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25082

Output from acceptance testing:

I'm not sure how to run the test here of if they need to be modified
$ make testacc TESTS=TestAccXXX PKG=ec2

...

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. pre-service-packages Includes pre-Service Packages aspects. labels May 27, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @egarbi 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 6, 2022
@gdavison
Copy link
Contributor

gdavison commented Jun 8, 2022

Hi @egarbi. It looks like you've made your changes starting from an old version of the provider. We rearranged the directory structure in #21306. This file has moved to internal/service/elasticbeanstalk/environment.go. If you either rebase your change or redo the change and point this branch at the new change, you can reuse this pull request.

Please also add a changelog entry as described in https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/pullrequest-submission-and-lifecycle.md#changelog-process

Otherwise, we can make the appropriate change

@ewbankkit ewbankkit added the service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. label Aug 4, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. pre-service-packages Includes pre-Service Packages aspects. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElasticBeanstalk Environment: 'poll_interval' fails for values > 60s and < 180s
4 participants