r/aws_redshiftdata_statement: Fix Semgrep error: Config funcs should follow form testAcc<Resource>Config_<testDetail>

[ewbankkit]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #25104.

Fixes:

Findings:

  internal/service/redshiftdata/statement_test.go 
     test-config-funcs-correct-form
        Config funcs should follow form testAcc<Resource>Config_<testDetail>

         27┆ {
         28┆ 	Config: testAccStatementConfigBasic(rName),
         29┆ 	Check: resource.ComposeTestCheckFunc(
         30┆ 		testAccCheckStatementExists(resourceName, &v),
         31┆ 		resource.TestCheckResourceAttrPair(resourceName, "cluster_identifier", "aws_redshift_cluster.test", "cluster_identifier"),
         32┆ 		resource.TestCheckResourceAttr(resourceName, "sql", "CREATE GROUP group_name;"),
         33┆ 		resource.TestCheckResourceAttr(resourceName, "parameters.#", "0"),
         34┆ 	),
         35┆ },

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Partially scanned: 1 files only partially analyzed due to a parsing or internal Semgrep error
  Scan skipped: 1593 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 107 rules on 39[53](https://github.com/hashicorp/terraform-provider-aws/runs/6696150989?check_suite_focus=true#step:4:54) files: 1 finding.

Output from acceptance testing:

% make semall
==> Running Semgrep checks locally (must have semgrep installed)...
Scanning 3953 files with 37 go rules.
  100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|3953/3953 tasks

Findings:

  internal/service/ec2/ebs_volume_test.go 
     use-acctest-provider-factories
        Use acctest.ProviderFactories, not acctest.Providers

        702┆ Providers:    acctest.Providers,

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1593 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 37 rules on 3953 files: 1 finding.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 3953 files with 107 go rules.
  100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|3953/3953 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1593 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 107 rules on 3953 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 891 files with 179 go rules.
  100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|891/891 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1593 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 180 rules on 891 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 883 files with 197 go rules.
  100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|883/883 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1593 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 201 rules on 883 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading
Scanning 1122 files with 198 go rules.
  100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████|1122/1122 tasks

Some files were skipped or only partially analyzed.
  Scan was limited to files tracked by git.
  Scan skipped: 1593 files matching .semgrepignore patterns
  For a full list of skipped files, run semgrep with the --verbose flag.

Ran 198 rules on 1122 files: 0 findings.

A new version of Semgrep is available. See https://semgrep.dev/docs/upgrading

[github-actions]

This functionality has been released in v4.17.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.