Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Commit - for aws-internal-review #25288

Closed
wants to merge 1 commit into from
Closed

Initial Commit - for aws-internal-review #25288

wants to merge 1 commit into from

Conversation

meetreks
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates to #25251

Output from acceptance testing:

make testacc PKG=s3 TESTS=TestAccS3BucketMetric_basic
![image](https://user-images.githubusercontent.com/12427542/173233964-5d7ad1ca-e072-4578-90d8-d5793b98aed1.png)


...

@github-actions github-actions bot added service/s3 Issues and PRs that pertain to the s3 service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jun 12, 2022
@justinretzolk
Copy link
Member

Related #25260

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jun 17, 2022
@anGie44
Copy link
Contributor

anGie44 commented Jun 21, 2022

Hi @meetreks , since this PR is preceded by #25260, i'm going to cherry-pick your commit into that PR since it already has a changelog entry and an update to the documentation.

@anGie44 anGie44 closed this Jun 21, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
partner Contribution from a partner. service/s3 Issues and PRs that pertain to the s3 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meetreks @justinretzolk @anGie44