Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data source for aws_route53_resolver_firewall_rule_group #25511

Merged
merged 11 commits into from
Nov 9, 2022
Merged

add data source for aws_route53_resolver_firewall_rule_group #25511

merged 11 commits into from
Nov 9, 2022

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Jun 21, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25493

Output from acceptance testing:

$ make testacc TESTS='TestAccRoute53ResolverFirewallDomainListDataSource_basic' PKG=route53resolver TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 20 -run='TestAccRoute53ResolverFirewallDomainListDataSource_basic' -short -timeout 180m
=== RUN   TestAccRoute53ResolverFirewallDomainListDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallDomainListDataSource_basic (7.77s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	10.278s

...

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. labels Jun 21, 2022
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/M Managed by automation to categorize the size of a PR. labels Jun 21, 2022
@silvaalbert silvaalbert changed the title wip: add data source for aws_route53_resolver_firewall_rule_group add data source for aws_route53_resolver_firewall_rule_group Jun 21, 2022
@silvaalbert silvaalbert marked this pull request as ready for review June 21, 2022 15:41
@silvaalbert silvaalbert requested a review from ewbankkit as a code owner June 21, 2022 15:41
@AdamTylerLynch AdamTylerLynch self-assigned this Jun 21, 2022
@silvaalbert silvaalbert changed the title add data source for aws_route53_resolver_firewall_rule_group wip: add data source for aws_route53_resolver_firewall_rule_group Jun 22, 2022
@silvaalbert silvaalbert marked this pull request as draft June 22, 2022 19:51
@silvaalbert silvaalbert changed the title wip: add data source for aws_route53_resolver_firewall_rule_group add data source for aws_route53_resolver_firewall_rule_group Jun 22, 2022
@silvaalbert silvaalbert marked this pull request as ready for review June 22, 2022 23:08
@justinretzolk justinretzolk added new-data-source Introduces a new data source. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 20, 2022
@ewbankkit
Merge branch 'main' into HEAD
d9e13fd
@ewbankkit
d/aws_route53_resolver_firewall_rule_group: 'id' -> 'firewall_rule_gr…
f05ebea 
…oup_id' and switch to 'WithoutTimeout' CRUD handlers (hashicorp#15090).

Acceptance test output:

% make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallRuleGroupDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverFirewallRuleGroupDataSource_ -timeout 180m
=== RUN   TestAccRoute53ResolverFirewallRuleGroupDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroupDataSource_basic (22.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	30.541s
ewbankkit
ewbankkit approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccRoute53ResolverFirewallRuleGroupDataSource_' PKG=route53resolver ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53resolver/... -v -count 1 -parallel 2  -run=TestAccRoute53ResolverFirewallRuleGroupDataSource_ -timeout 180m
=== RUN   TestAccRoute53ResolverFirewallRuleGroupDataSource_basic
--- PASS: TestAccRoute53ResolverFirewallRuleGroupDataSource_basic (22.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/route53resolver	30.541s

@ewbankkit
Copy link
Contributor

@silvaalbert Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit bfd7848 into hashicorp:main Nov 9, 2022
@github-actions github-actions bot added this to the v4.39.0 milestone Nov 9, 2022
@github-actions
Copy link

This functionality has been released in v4.39.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@AdamTylerLynch AdamTylerLynch

Labels
documentation Introduces or discusses updates to documentation. new-data-source Introduces a new data source. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.39.0
Development

Successfully merging this pull request may close these issues.

add data source for aws_route53_resolver_firewall_rule_group
5 participants
@silvaalbert @ewbankkit @AdamTylerLynch @justinretzolk @albsilv-aws