-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/redshiftserverless_namespace - new resource #25546
Conversation
77e4c52
to
1427af2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRedshiftServerlessNamespace_' PKG=redshiftserverless ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/redshiftserverless/... -v -count 1 -parallel 2 -run=TestAccRedshiftServerlessNamespace_ -timeout 180m
=== RUN TestAccRedshiftServerlessNamespace_basic
=== PAUSE TestAccRedshiftServerlessNamespace_basic
=== RUN TestAccRedshiftServerlessNamespace_tags
=== PAUSE TestAccRedshiftServerlessNamespace_tags
=== RUN TestAccRedshiftServerlessNamespace_disappears
=== PAUSE TestAccRedshiftServerlessNamespace_disappears
=== CONT TestAccRedshiftServerlessNamespace_basic
=== CONT TestAccRedshiftServerlessNamespace_disappears
--- PASS: TestAccRedshiftServerlessNamespace_disappears (15.90s)
=== CONT TestAccRedshiftServerlessNamespace_tags
--- PASS: TestAccRedshiftServerlessNamespace_basic (39.46s)
--- PASS: TestAccRedshiftServerlessNamespace_tags (45.53s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/redshiftserverless 64.154s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Seems like this has been fixed upstream in Release v1.44.45 (on 29 June 2022), is it possible to attempt a re-merge? |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #24501
Output from acceptance testing: