Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated Lambda function runtime errors #25859

Merged
merged 4 commits into from
Jul 18, 2022
Merged

Fix deprecated Lambda function runtime errors #25859

merged 4 commits into from
Jul 18, 2022

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 18, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25857.

% make testacc TESTARGS='-run=TestAccLambdaFunction_runtimes' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunction_runtimes -timeout 180m
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_runtimes (304.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	308.789s
% make testacc TESTARGS='-run=TestAccSNSTopicSubscription_autoConfirmingEndpoint\|TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint' PKG=sns
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sns/... -v -count 1 -parallel 20  -run=TestAccSNSTopicSubscription_autoConfirmingEndpoint\|TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint -timeout 180m
=== RUN   TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== RUN   TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== PAUSE TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
=== CONT  TestAccSNSTopicSubscription_autoConfirmingEndpoint
=== CONT  TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint
--- PASS: TestAccSNSTopicSubscription_autoConfirmingEndpoint (92.87s)
--- PASS: TestAccSNSTopicSubscription_autoConfirmingSecuredEndpoint (135.66s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sns	139.630s

ewbankkit added 4 commits July 18, 2022 10:50
@ewbankkit
Fix validate-terraform: 'Warning: The python3.6 runtime has reached t…
f75012d 
…he end of support (aws_lambda_function_deprecated_runtime)'.
@ewbankkit
TestAccLambdaFunction_runtimes: Fix 'InvalidParameterValueException: …
cba7260 
…The runtime parameter of python2.7 is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (python3.9) while creating or updating functions'.
@ewbankkit
TestAccLambdaFunction_runtimes: Pre-empt upcoming 'python3.6' runtime…
b6c8942 
… deprecation.

Acceptance test output:

% make testacc TESTARGS='-run=TestAccLambdaFunction_runtimes' PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20  -run=TestAccLambdaFunction_runtimes -timeout 180m
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_runtimes (304.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	308.789s
@ewbankkit
r/aws_sns_topic_subscription: Pre-empt upcoming 'python3.6' runtime d…
343a59d 
…eprecation in acceptance test configurations.
@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apigateway Issues and PRs that pertain to the apigateway service. service/lambda Issues and PRs that pertain to the lambda service. service/sns Issues and PRs that pertain to the sns service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 18, 2022
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. linter Pertains to changes to or issues with the various linters. labels Jul 18, 2022
@ewbankkit ewbankkit merged commit de1f280 into main Jul 18, 2022
@ewbankkit ewbankkit deleted the td-python3.6-lambda-runtime-deprecated branch July 18, 2022 18:20
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 18, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. linter Pertains to changes to or issues with the various linters. service/apigateway Issues and PRs that pertain to the apigateway service. service/lambda Issues and PRs that pertain to the lambda service. service/sns Issues and PRs that pertain to the sns service. size/XS Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.23.0
Development

Successfully merging this pull request may close these issues.

validate-terraform errors: The "python3.6" runtime has reached the end of support
1 participant
@ewbankkit