Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #23601 #25982

Closed
wants to merge 2 commits into from
Closed

Attempt to fix #23601 #25982

wants to merge 2 commits into from

Conversation

danielcweber
Copy link
Contributor

When a cluster is restored from a snapshot, resourceClusterUpdate is called, passing the engine-version along to ModifyDBCluster. This will always fail, even when the engine-version has not changed. The solution might be to omit the version from the arguments in case the resource has been freshly created.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #23601

…called, passing the engine-version along to ModifyDBCluster. This will always fail, even when the engine-version has not changed. The solution might be to omit the version from the arguments in case the resource has been freshly created.
@github-actions github-actions bot added service/neptune Issues and PRs that pertain to the neptune service. needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. labels Jul 26, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 27, 2022
@tgourley01
Copy link

We tested this locally and it resolves the restore from snapshot issue. Can we get some attention on this to get it merged?

@ran2806
Copy link

ran2806 commented Nov 8, 2022

We are blocked by this issue. So I took the change from this branch and built the provider locally. I have tested following flows.

  1. Restoring cluster from snapshot.
  2. Destroying restored cluster.
  3. Creating blank cluster.
  4. Updating blank cluster.
  5. Destroying blank cluster.

All the above scenarios are working good.

@ewbankkit
Copy link
Contributor

@danielcweber Thanks for the contribution 🎉 👏.
I have rolled the functionality into #28051.

@danielcweber danielcweber deleted the b-AttemptToFix23601 branch February 13, 2023 14:11
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/neptune Issues and PRs that pertain to the neptune service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants