Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guardduty: organization malware protection configuration #25992 #25997

Merged
merged 14 commits into from
Jul 28, 2022
Merged

Guardduty: organization malware protection configuration #25992 #25997

merged 14 commits into from
Jul 28, 2022

Conversation

nickolivera
Copy link
Contributor

@nickolivera nickolivera commented Jul 27, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25992

Output from acceptance testing:
Requires update to 1.44.63 Tested with 1.44.63 draft until sdk is updated

nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccGuardDuty_serial/OrganizationConfiguration' PKG=guardduty ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/guardduty/... -v -count 1 -parallel 2  -run=TestAccGuardDuty_serial/OrganizationConfiguration -timeout 180m
=== RUN   TestAccGuardDuty_serial
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/malwareProtection
--- PASS: TestAccGuardDuty_serial (49.00s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (49.00s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/malwareProtection (49.00s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  50.679s
nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccGuardDuty_serial/OrganizationConfiguration' PKG=guardduty ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/guardduty/... -v -count 1 -parallel 2  -run=TestAccGuardDuty_serial/OrganizationConfiguration -timeout 180m
=== RUN   TestAccGuardDuty_serial
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/basic
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/malwareProtection
--- PASS: TestAccGuardDuty_serial (124.32s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (124.32s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/basic (32.36s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs (30.57s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes (30.13s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/malwareProtection (31.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/guardduty  126.052s
nick@nick1 terraform-provider-aws % 


...

@nickolivera nickolivera marked this pull request as draft July 27, 2022 08:13
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/guardduty Issues and PRs that pertain to the guardduty service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/guardduty Issues and PRs that pertain to the guardduty service. labels Jul 27, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/guardduty Issues and PRs that pertain to the guardduty service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jul 27, 2022
@nickolivera nickolivera marked this pull request as ready for review July 27, 2022 15:29
@nickolivera
Copy link
Contributor Author

gtg

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Jul 27, 2022
ewbankkit
ewbankkit approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccGuardDuty_serial/OrganizationConfiguration' PKG=guardduty ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/guardduty/... -v -count 1 -parallel 2  -run=TestAccGuardDuty_serial/OrganizationConfiguration -timeout 180m
=== RUN   TestAccGuardDuty_serial
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/malwareProtection
=== RUN   TestAccGuardDuty_serial/OrganizationConfiguration/basic
--- PASS: TestAccGuardDuty_serial (167.11s)
    --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration (167.11s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/s3Logs (44.89s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/kubernetes (34.39s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/malwareProtection (36.97s)
        --- PASS: TestAccGuardDuty_serial/OrganizationConfiguration/basic (50.86s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/guardduty	171.137s

@ewbankkit
Copy link
Contributor

@nickyamanaka Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 6a99e70 into hashicorp:main Jul 28, 2022
@github-actions github-actions bot added this to the v4.24.0 milestone Jul 28, 2022
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

This functionality has been released in v4.24.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Sep 3, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/guardduty Issues and PRs that pertain to the guardduty service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.24.0
Development

Successfully merging this pull request may close these issues.

aws guardduty organization configuration auto enable malware protection
3 participants
@nickolivera @ewbankkit @justinretzolk