Macie Macie2 Classification Results - Export Configuration #19856

[nickolivera]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19856

Two things:

• Import doesn't care about IDs, there's only one resource, the API takes care of not found, etc. Documentation has a dummy value
• Objects returned from the API are not nil (at least the first Configuration property) but empty structs,

string=(*macie2.GetClassificationExportConfigurationOutput)(0x140002091e8)({
│   Configuration: {
│ 
│   }
│ })

so my comparison might be unorthodox to check if the object are empty or if the resource already exists. Can I get some feedback for this approach? I could go checking if output.Configuration.SetS3Destination != nil if that makes more sense.

Output from acceptance testing:

nick@nick1 terraform-provider-aws % make testacc TESTARGS='-run=TestAccMacie2_serial/ClassificationExportConfiguration' PKG=macie2 ACCTEST_PARALLELISM=1
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/macie2/... -v -count 1 -parallel 1  -run=TestAccMacie2_serial/ClassificationExportConfiguration -timeout 180m
=== RUN   TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/ClassificationExportConfiguration
=== RUN   TestAccMacie2_serial/ClassificationExportConfiguration/basic
--- PASS: TestAccMacie2_serial (37.65s)
    --- PASS: TestAccMacie2_serial/ClassificationExportConfiguration (37.65s)
        --- PASS: TestAccMacie2_serial/ClassificationExportConfiguration/basic (37.65s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/macie2     39.333s


...

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccMacie2_serial/ClassificationExportConfiguration' PKG=macie2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/macie2/... -v -count 1 -parallel 20  -run=TestAccMacie2_serial/ClassificationExportConfiguration -timeout 180m
=== RUN   TestAccMacie2_serial
=== RUN   TestAccMacie2_serial/ClassificationExportConfiguration
=== RUN   TestAccMacie2_serial/ClassificationExportConfiguration/basic
--- PASS: TestAccMacie2_serial (49.57s)
    --- PASS: TestAccMacie2_serial/ClassificationExportConfiguration (49.57s)
        --- PASS: TestAccMacie2_serial/ClassificationExportConfiguration/basic (49.57s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/macie2	55.719s

[ewbankkit]

@nickyamanaka Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.