r/aws_backup_vault: Add force_destroy argument
#26199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acceptance test output: % make testacc TESTARGS='-run=TestAccBackupVault_' PKG=backup ACCTEST_PARALLELISM=1 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 1 -run=TestAccBackupVault_ -timeout 180m === RUN TestAccBackupVault_basic === PAUSE TestAccBackupVault_basic === RUN TestAccBackupVault_disappears === PAUSE TestAccBackupVault_disappears === RUN TestAccBackupVault_tags === PAUSE TestAccBackupVault_tags === RUN TestAccBackupVault_withKMSKey === PAUSE TestAccBackupVault_withKMSKey === CONT TestAccBackupVault_basic --- PASS: TestAccBackupVault_basic (17.52s) === CONT TestAccBackupVault_tags --- PASS: TestAccBackupVault_tags (37.63s) === CONT TestAccBackupVault_withKMSKey --- PASS: TestAccBackupVault_withKMSKey (17.59s) === CONT TestAccBackupVault_disappears --- PASS: TestAccBackupVault_disappears (11.44s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 88.100s
Acceptance test output: % make testacc TESTARGS='-run=TestAccBackupVault_forceDestroy' PKG=backup ACCTEST_PARALLELISM=1 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 1 -run=TestAccBackupVault_forceDestroy -timeout 180m === RUN TestAccBackupVault_forceDestroyEmpty === PAUSE TestAccBackupVault_forceDestroyEmpty === CONT TestAccBackupVault_forceDestroyEmpty --- PASS: TestAccBackupVault_forceDestroyEmpty (23.93s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 31.410s
github-actions
bot
added
documentation
…oint'. Acceptance test output: % make testacc TESTARGS='-run=TestAccBackupVault_forceDestroyWithRecoveryPoint' PKG=backup ACCTEST_PARALLELISM=1 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/backup/... -v -count 1 -parallel 1 -run=TestAccBackupVault_forceDestroyWithRecoveryPoint -timeout 180m === RUN TestAccBackupVault_forceDestroyWithRecoveryPoint === PAUSE TestAccBackupVault_forceDestroyWithRecoveryPoint === CONT TestAccBackupVault_forceDestroyWithRecoveryPoint --- PASS: TestAccBackupVault_forceDestroyWithRecoveryPoint (110.64s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/backup 114.576s
Hello!
Usecase:
in `backup_aws_vault`, if you set the variable `vault_name` with a string of more than 50 characters, instead of a length error, it raises:
`"must consist of lowercase letters, numbers, and hyphens."`
I think it should raise something along the line of:
`expected length of name to be in the range (1 - 50)`
I think this regex is to blame (the last part of the regex):
`^[a-zA-Z0-9\-\_\.]{1, 50}$`
Proposed solution:
Split the validation into syntax validation and length validation
|
This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #13247.