Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_comprehend_entity_recognizer: New resource #26244

Merged
merged 29 commits into from
Aug 11, 2022

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Aug 11, 2022

Adds new resource aws_comprehend_entity_recognizer.

Relates #18864

Output from acceptance testing:

$ make testacc PKG=comprehend TESTS=TestAccComprehendEntityRecognizer_

--- PASS: TestAccComprehendEntityRecognizer_annotations_validateNoTestDocuments (26.74s)
--- PASS: TestAccComprehendEntityRecognizer_annotations_validateNoTestAnnotations (26.80s)
--- PASS: TestAccComprehendEntityRecognizer_versionNameGenerated (1075.21s)
--- PASS: TestAccComprehendEntityRecognizer_KMSKeys_CreateARNs (1082.77s)
--- PASS: TestAccComprehendEntityRecognizer_DefaultTags_providerOnly (1104.42s)
--- PASS: TestAccComprehendEntityRecognizer_basic (1125.98s)
--- PASS: TestAccComprehendEntityRecognizer_versionNameEmpty (1129.50s)
--- PASS: TestAccComprehendEntityRecognizer_annotations_testDocuments (1130.88s)
--- PASS: TestAccComprehendEntityRecognizer_KMSKeys_CreateIDs (1135.89s)
--- PASS: TestAccComprehendEntityRecognizer_tags (1896.25s)
--- PASS: TestAccComprehendEntityRecognizer_versionNamePrefix (1932.05s)
--- PASS: TestAccComprehendEntityRecognizer_disappears (1936.58s)
--- PASS: TestAccComprehendEntityRecognizer_versionName (1937.11s)
--- PASS: TestAccComprehendEntityRecognizer_annotations_basic (1942.24s)
--- PASS: TestAccComprehendEntityRecognizer_documents_testDocuments (1944.67s)
--- PASS: TestAccComprehendEntityRecognizer_VPCConfig_Create (2996.79s)
--- PASS: TestAccComprehendEntityRecognizer_VPCConfig_Update (3218.81s)
--- PASS: TestAccComprehendEntityRecognizer_KMSKeys_Update (4139.52s)

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Aug 11, 2022
@github-actions github-actions bot added service/comprehend Issues and PRs that pertain to the comprehend service. service/vpc Issues and PRs that pertain to the vpc service. skaff Issues and pull requested related to the skaff tool tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XL Managed by automation to categorize the size of a PR. labels Aug 11, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% ACCTEST_TIMEOUT=600m make testacc TESTARGS='-run=TestAccComprehendEntityRecognizer_' PKG=comprehend ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/comprehend/... -v -count 1 -parallel 3  -run=TestAccComprehendEntityRecognizer_ -timeout 600m
=== RUN   TestAccComprehendEntityRecognizer_basic
=== PAUSE TestAccComprehendEntityRecognizer_basic
=== RUN   TestAccComprehendEntityRecognizer_disappears
=== PAUSE TestAccComprehendEntityRecognizer_disappears
=== RUN   TestAccComprehendEntityRecognizer_versionName
=== PAUSE TestAccComprehendEntityRecognizer_versionName
=== RUN   TestAccComprehendEntityRecognizer_versionNameEmpty
=== PAUSE TestAccComprehendEntityRecognizer_versionNameEmpty
=== RUN   TestAccComprehendEntityRecognizer_versionNameGenerated
=== PAUSE TestAccComprehendEntityRecognizer_versionNameGenerated
=== RUN   TestAccComprehendEntityRecognizer_versionNamePrefix
=== PAUSE TestAccComprehendEntityRecognizer_versionNamePrefix
=== RUN   TestAccComprehendEntityRecognizer_documents_testDocuments
=== PAUSE TestAccComprehendEntityRecognizer_documents_testDocuments
=== RUN   TestAccComprehendEntityRecognizer_annotations_basic
=== PAUSE TestAccComprehendEntityRecognizer_annotations_basic
=== RUN   TestAccComprehendEntityRecognizer_annotations_testDocuments
=== PAUSE TestAccComprehendEntityRecognizer_annotations_testDocuments
=== RUN   TestAccComprehendEntityRecognizer_annotations_validateNoTestDocuments
=== PAUSE TestAccComprehendEntityRecognizer_annotations_validateNoTestDocuments
=== RUN   TestAccComprehendEntityRecognizer_annotations_validateNoTestAnnotations
=== PAUSE TestAccComprehendEntityRecognizer_annotations_validateNoTestAnnotations
=== RUN   TestAccComprehendEntityRecognizer_KMSKeys_CreateIDs
=== PAUSE TestAccComprehendEntityRecognizer_KMSKeys_CreateIDs
=== RUN   TestAccComprehendEntityRecognizer_KMSKeys_CreateARNs
=== PAUSE TestAccComprehendEntityRecognizer_KMSKeys_CreateARNs
=== RUN   TestAccComprehendEntityRecognizer_KMSKeys_Update
=== PAUSE TestAccComprehendEntityRecognizer_KMSKeys_Update
=== RUN   TestAccComprehendEntityRecognizer_VPCConfig_Create
=== PAUSE TestAccComprehendEntityRecognizer_VPCConfig_Create
=== RUN   TestAccComprehendEntityRecognizer_VPCConfig_Update
=== PAUSE TestAccComprehendEntityRecognizer_VPCConfig_Update
=== RUN   TestAccComprehendEntityRecognizer_tags
=== PAUSE TestAccComprehendEntityRecognizer_tags
=== RUN   TestAccComprehendEntityRecognizer_DefaultTags_providerOnly
=== PAUSE TestAccComprehendEntityRecognizer_DefaultTags_providerOnly
=== CONT  TestAccComprehendEntityRecognizer_basic
=== CONT  TestAccComprehendEntityRecognizer_annotations_testDocuments
=== CONT  TestAccComprehendEntityRecognizer_DefaultTags_providerOnly
--- PASS: TestAccComprehendEntityRecognizer_annotations_testDocuments (1053.77s)
=== CONT  TestAccComprehendEntityRecognizer_tags
--- PASS: TestAccComprehendEntityRecognizer_basic (1054.26s)
=== CONT  TestAccComprehendEntityRecognizer_VPCConfig_Update
--- PASS: TestAccComprehendEntityRecognizer_DefaultTags_providerOnly (1080.49s)
=== CONT  TestAccComprehendEntityRecognizer_VPCConfig_Create
--- PASS: TestAccComprehendEntityRecognizer_tags (1205.44s)
=== CONT  TestAccComprehendEntityRecognizer_KMSKeys_Update
--- PASS: TestAccComprehendEntityRecognizer_VPCConfig_Create (2466.18s)
=== CONT  TestAccComprehendEntityRecognizer_KMSKeys_CreateARNs
--- PASS: TestAccComprehendEntityRecognizer_KMSKeys_CreateARNs (1004.50s)
=== CONT  TestAccComprehendEntityRecognizer_annotations_validateNoTestDocuments
--- PASS: TestAccComprehendEntityRecognizer_VPCConfig_Update (3504.17s)
=== CONT  TestAccComprehendEntityRecognizer_annotations_basic
--- PASS: TestAccComprehendEntityRecognizer_annotations_validateNoTestDocuments (13.78s)
=== CONT  TestAccComprehendEntityRecognizer_KMSKeys_CreateIDs
--- PASS: TestAccComprehendEntityRecognizer_KMSKeys_CreateIDs (1124.33s)
=== CONT  TestAccComprehendEntityRecognizer_annotations_validateNoTestAnnotations
--- PASS: TestAccComprehendEntityRecognizer_annotations_validateNoTestAnnotations (11.37s)
=== CONT  TestAccComprehendEntityRecognizer_documents_testDocuments
--- PASS: TestAccComprehendEntityRecognizer_annotations_basic (1173.50s)
=== CONT  TestAccComprehendEntityRecognizer_versionName
--- PASS: TestAccComprehendEntityRecognizer_KMSKeys_Update (3769.24s)
=== CONT  TestAccComprehendEntityRecognizer_disappears
--- PASS: TestAccComprehendEntityRecognizer_documents_testDocuments (991.68s)
=== CONT  TestAccComprehendEntityRecognizer_versionNamePrefix
--- PASS: TestAccComprehendEntityRecognizer_disappears (989.36s)
=== CONT  TestAccComprehendEntityRecognizer_versionNameGenerated
--- PASS: TestAccComprehendEntityRecognizer_versionNamePrefix (1051.99s)
=== CONT  TestAccComprehendEntityRecognizer_versionNameEmpty
--- PASS: TestAccComprehendEntityRecognizer_versionNameGenerated (991.21s)
--- PASS: TestAccComprehendEntityRecognizer_versionName (2404.48s)
--- PASS: TestAccComprehendEntityRecognizer_versionNameEmpty (1111.95s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/comprehend	8860.168s

@gdavison gdavison merged commit 68321aa into main Aug 11, 2022
@gdavison gdavison deleted the f-comprehend-entity-recognizer branch August 11, 2022 21:19
@github-actions github-actions bot added this to the v4.26.0 milestone Aug 11, 2022
@github-actions
Copy link

This functionality has been released in v4.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/comprehend Issues and PRs that pertain to the comprehend service. service/vpc Issues and PRs that pertain to the vpc service. size/XL Managed by automation to categorize the size of a PR. skaff Issues and pull requested related to the skaff tool tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants