Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Redis DMS target endpoint correctly #26410

Closed
wants to merge 1 commit into from

Conversation

dpattmann
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26266

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDMSEndpoint_Redis_' PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20  -run=TestAccDMSEndpoint_Redis_ -timeout 180m
=== RUN   TestAccDMSEndpoint_Redis_basic
=== PAUSE TestAccDMSEndpoint_Redis_basic
=== RUN   TestAccDMSEndpoint_Redis_update
=== PAUSE TestAccDMSEndpoint_Redis_update
=== CONT  TestAccDMSEndpoint_Redis_basic
=== CONT  TestAccDMSEndpoint_Redis_update
--- PASS: TestAccDMSEndpoint_Redis_basic (103.42s)
--- PASS: TestAccDMSEndpoint_Redis_update (118.68s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/dms	120.368s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Aug 21, 2022
@dpattmann
Copy link
Contributor Author

There is already another PR #26411 handling issue #26266. Going to close this PR.

@dpattmann dpattmann closed this Aug 22, 2022
@dpattmann dpattmann deleted the b-aws_dms_endpoint-26266 branch August 22, 2022 11:54
@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Aug 22, 2022
@peresypkinroman
Copy link
Contributor

We did PRs almost simultaneously.
If you have smth to add or to reason fill free.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/dms Issues and PRs that pertain to the dms service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to create aws_dms_endpoint Redis target
2 participants