[WIP] New Resource: LB Listener Additional Certificates #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Ninir
added
the
enhancement
Puneeth-n
reviewed
Dec 15, 2017
| } | ||
| } | ||
|
|
||
| if *resp.NextMarker != "" { |
There was a problem hiding this comment.
if resp.NextMarker != nil {
There was a problem hiding this comment.
Otherwise causes segfault
|
Closing in favour of #2686. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for #1853 and is a second attempt of the PR #2203.
We create a new resource
aws_lb_listener_certificatewhich is used to add additional certificates into an HTTPS load balancer listener. This does not effect thecertificate_arnargument toaws_lb_listeneras there must still be a default certificate assigned to the listener.I need help with the acceptance tests currently. They currently fail in the destroy phase as I believe the listener resource is being destroyed before the listener certificate resource and therefore the listener cannot be found. This could fairly easily be worked around by allowing a
ListenerNotFounderror in the destroy test but I don't believe that'd be testing the destruction of this specific resource correctly. Maybe @radeksimko can be of assistance here (as he reviewed my previous PR).Other than that failing test this is ready to go IMO.