Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to ses email_identity for SESv2 and aws sdkv2 #26604

Closed
wants to merge 8 commits into from
Closed

Updates to ses email_identity for SESv2 and aws sdkv2 #26604

wants to merge 8 commits into from

Conversation

JoshiiSinfield
Copy link

@JoshiiSinfield JoshiiSinfield commented Sep 1, 2022

Moved ses_email_identity to sesv2 api
Moved ses_email_identity to use context based resource CRUD operations
Moved ses_email_identity to new sesv2 package to allow use of SDKv2

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #19363
Relates #21129
Relates #23955

Relates #26796

Output from acceptance testing:

Acceptance test output can be seen in comments as functionality added/changed

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ses Issues and PRs that pertain to the ses service. size/M Managed by automation to categorize the size of a PR. labels Sep 1, 2022
@JoshiiSinfield
Copy link
Author

JoshiiSinfield commented Sep 1, 2022

First commit just updates resource. This is to verify against existing acctests.

Next steps:
update acctests for email_identity
add required new functionality to email_identity

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @JoshiiSinfield 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added the tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. label Sep 6, 2022
@JoshiiSinfield
Copy link
Author

JoshiiSinfield commented Sep 6, 2022

acctest output following sesv2 updates.

make testacc TESTS=TestAccSESEmailIdentity PKG=ses
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ses/... -v -count 1 -parallel 20 -run='TestAccSESEmailIdentity' -timeout 180m
=== RUN TestAccSESEmailIdentityDataSource_basic
=== PAUSE TestAccSESEmailIdentityDataSource_basic
=== RUN TestAccSESEmailIdentityDataSource_trailingPeriod
=== PAUSE TestAccSESEmailIdentityDataSource_trailingPeriod
=== RUN TestAccSESEmailIdentity_basic
=== PAUSE TestAccSESEmailIdentity_basic
=== RUN TestAccSESEmailIdentity_trailingPeriod
=== PAUSE TestAccSESEmailIdentity_trailingPeriod
=== CONT TestAccSESEmailIdentityDataSource_basic
=== CONT TestAccSESEmailIdentity_trailingPeriod
=== CONT TestAccSESEmailIdentity_basic
=== CONT TestAccSESEmailIdentityDataSource_trailingPeriod
--- PASS: TestAccSESEmailIdentityDataSource_trailingPeriod (11.15s)
--- PASS: TestAccSESEmailIdentityDataSource_basic (11.18s)
--- PASS: TestAccSESEmailIdentity_basic (12.44s)
--- PASS: TestAccSESEmailIdentity_trailingPeriod (12.50s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ses 14.164s

@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Sep 6, 2022
@JoshiiSinfield
Copy link
Author

make testacc TESTS=TestAccSESEmailIdentity PKG=ses
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ses/... -v -count 1 -parallel 20 -run='TestAccSESEmailIdentity' -timeout 180m
=== RUN TestAccSESEmailIdentityDataSource_basic
=== PAUSE TestAccSESEmailIdentityDataSource_basic
=== RUN TestAccSESEmailIdentityDataSource_trailingPeriod
=== PAUSE TestAccSESEmailIdentityDataSource_trailingPeriod
=== RUN TestAccSESEmailIdentity_basic
=== PAUSE TestAccSESEmailIdentity_basic
=== RUN TestAccSESEmailIdentity_trailingPeriod
=== PAUSE TestAccSESEmailIdentity_trailingPeriod
=== RUN TestAccSESEmailIdentity_complete
=== PAUSE TestAccSESEmailIdentity_complete
=== CONT TestAccSESEmailIdentityDataSource_basic
=== CONT TestAccSESEmailIdentity_trailingPeriod
=== CONT TestAccSESEmailIdentity_basic
=== CONT TestAccSESEmailIdentityDataSource_trailingPeriod
=== CONT TestAccSESEmailIdentity_complete
--- PASS: TestAccSESEmailIdentityDataSource_basic (12.34s)
--- PASS: TestAccSESEmailIdentityDataSource_trailingPeriod (12.34s)
--- PASS: TestAccSESEmailIdentity_basic (13.84s)
--- PASS: TestAccSESEmailIdentity_complete (13.98s)
--- PASS: TestAccSESEmailIdentity_trailingPeriod (14.16s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ses 15.883s

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@github-actions github-actions bot added client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/sesv2 Issues and PRs that pertain to the sesv2 service. labels Sep 7, 2022
@JoshiiSinfield
Copy link
Author

latest testacc output
make testacc TESTS=TestAccSESEmailIdentity PKG=sesv2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESEmailIdentity' -timeout 180m
=== RUN TestAccSESEmailIdentityDataSource_basic
=== PAUSE TestAccSESEmailIdentityDataSource_basic
=== RUN TestAccSESEmailIdentityDataSource_trailingPeriod
=== PAUSE TestAccSESEmailIdentityDataSource_trailingPeriod
=== RUN TestAccSESEmailIdentity_basic
=== PAUSE TestAccSESEmailIdentity_basic
=== RUN TestAccSESEmailIdentity_trailingPeriod
=== PAUSE TestAccSESEmailIdentity_trailingPeriod
=== RUN TestAccSESEmailIdentity_complete
=== PAUSE TestAccSESEmailIdentity_complete
=== CONT TestAccSESEmailIdentityDataSource_basic
=== CONT TestAccSESEmailIdentity_trailingPeriod
=== CONT TestAccSESEmailIdentity_complete
=== CONT TestAccSESEmailIdentity_basic
=== CONT TestAccSESEmailIdentityDataSource_trailingPeriod
--- PASS: TestAccSESEmailIdentityDataSource_basic (11.36s)
--- PASS: TestAccSESEmailIdentityDataSource_trailingPeriod (11.41s)
--- PASS: TestAccSESEmailIdentity_trailingPeriod (12.53s)
--- PASS: TestAccSESEmailIdentity_basic (12.66s)
--- PASS: TestAccSESEmailIdentity_complete (13.09s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 14.757s

@JoshiiSinfield JoshiiSinfield changed the title Updates to ses email_identity and domain Updates to ses email_identity Sep 7, 2022
@github-actions github-actions bot added the tags Pertains to resource tagging. label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Thank you for your contribution! 🚀

Please note that the CHANGELOG.md file contents are handled by the maintainers during merge. This is to prevent pull request merge conflicts, especially for contributions which may not be merged immediately. Please see the Contributing Guide for additional pull request review items.

Remove any changes to the CHANGELOG.md file and commit them in this pull request to prevent delays with reviewing and potentially merging this pull request.

@JoshiiSinfield JoshiiSinfield marked this pull request as ready for review September 7, 2022 11:09
@JoshiiSinfield
Copy link
Author

FYI - I had planned to do domain identity also, but this MR grew legs & has become large therefore decided to wait for this to be reviewed/merged first. This MR is also a dependency for domain_identity work.

@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Sep 13, 2022
@JoshiiSinfield JoshiiSinfield mentioned this pull request Oct 12, 2022
@JoshiiSinfield JoshiiSinfield changed the title Updates to ses email_identity Updates to ses email_identity for SESv2 and aws sdkv2 Oct 12, 2022
@JoshiiSinfield JoshiiSinfield deleted the update-ses-resources-sesv2-api branch November 6, 2022 09:48
@github-actions
Copy link

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/ses Issues and PRs that pertain to the ses service. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants