-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to ses email_identity for SESv2 and aws sdkv2 #26604
Updates to ses email_identity for SESv2 and aws sdkv2 #26604
Conversation
First commit just updates resource. This is to verify against existing acctests. Next steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @JoshiiSinfield 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
acctest output following sesv2 updates. make testacc TESTS=TestAccSESEmailIdentity PKG=ses |
make testacc TESTS=TestAccSESEmailIdentity PKG=ses |
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
latest testacc output |
Thank you for your contribution! 🚀 Please note that the Remove any changes to the |
Move SDK to v2 for sesv2 move sesv2 to own service package
FYI - I had planned to do domain identity also, but this MR grew legs & has become large therefore decided to wait for this to be reviewed/merged first. This MR is also a dependency for domain_identity work. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Moved ses_email_identity to sesv2 api
Moved ses_email_identity to use context based resource CRUD operations
Moved ses_email_identity to new sesv2 package to allow use of SDKv2
Community Note
Relates #19363
Relates #21129
Relates #23955
Relates #26796
Output from acceptance testing:
Acceptance test output can be seen in comments as functionality added/changed