-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional validation for aws_cloudwatch_event_connection #26755
Additional validation for aws_cloudwatch_event_connection #26755
Conversation
Signed-off-by: Matt Sladen <matt5188@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEventsConnection_' PKG=events ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/events/... -v -count 1 -parallel 3 -run=TestAccEventsConnection_ -timeout 360m
=== RUN TestAccEventsConnection_apiKey
=== PAUSE TestAccEventsConnection_apiKey
=== RUN TestAccEventsConnection_basic
=== PAUSE TestAccEventsConnection_basic
=== RUN TestAccEventsConnection_oAuth
=== PAUSE TestAccEventsConnection_oAuth
=== RUN TestAccEventsConnection_invocationHTTPParameters
=== PAUSE TestAccEventsConnection_invocationHTTPParameters
=== RUN TestAccEventsConnection_disappears
=== PAUSE TestAccEventsConnection_disappears
=== CONT TestAccEventsConnection_apiKey
=== CONT TestAccEventsConnection_invocationHTTPParameters
=== CONT TestAccEventsConnection_disappears
--- PASS: TestAccEventsConnection_disappears (25.23s)
=== CONT TestAccEventsConnection_basic
--- PASS: TestAccEventsConnection_invocationHTTPParameters (64.66s)
=== CONT TestAccEventsConnection_oAuth
--- PASS: TestAccEventsConnection_apiKey (65.10s)
--- PASS: TestAccEventsConnection_basic (60.92s)
--- PASS: TestAccEventsConnection_oAuth (74.59s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/events 149.657s
@mtt88 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Add validation on
aws_cloudwatch_event_connection
resource to prevent emptyoauth_http_parameters
orinvocation_http_parameters
elements.Community Note
Closes #26378
Output from acceptance testing: