Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional validation for aws_cloudwatch_event_connection #26755

Merged

Conversation

mtt88
Copy link
Contributor

@mtt88 mtt88 commented Sep 11, 2022

Add validation on aws_cloudwatch_event_connection resource to prevent empty oauth_http_parameters or invocation_http_parameters elements.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #26378

Output from acceptance testing:

$ ACCTEST_PARALLELISM=10 make testacc TESTS=TestAccEventsConnection PKG=events
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/events/... -v -count 1 -parallel 10 -run='TestAccEventsConnection'  -timeout 180m
=== RUN   TestAccEventsConnectionDataSource_Connection_basic
=== PAUSE TestAccEventsConnectionDataSource_Connection_basic
=== RUN   TestAccEventsConnection_apiKey
=== PAUSE TestAccEventsConnection_apiKey
=== RUN   TestAccEventsConnection_basic
=== PAUSE TestAccEventsConnection_basic
=== RUN   TestAccEventsConnection_oAuth
=== PAUSE TestAccEventsConnection_oAuth
=== RUN   TestAccEventsConnection_invocationHTTPParameters
=== PAUSE TestAccEventsConnection_invocationHTTPParameters
=== RUN   TestAccEventsConnection_disappears
=== PAUSE TestAccEventsConnection_disappears
=== CONT  TestAccEventsConnectionDataSource_Connection_basic
=== CONT  TestAccEventsConnection_basic
=== CONT  TestAccEventsConnection_apiKey
=== CONT  TestAccEventsConnection_oAuth
=== CONT  TestAccEventsConnection_disappears
=== CONT  TestAccEventsConnection_invocationHTTPParameters
--- PASS: TestAccEventsConnection_disappears (26.76s)
--- PASS: TestAccEventsConnectionDataSource_Connection_basic (34.02s)
--- PASS: TestAccEventsConnection_invocationHTTPParameters (71.14s)
--- PASS: TestAccEventsConnection_basic (72.87s)
--- PASS: TestAccEventsConnection_apiKey (73.88s)
--- PASS: TestAccEventsConnection_oAuth (75.75s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	78.659s

...

Signed-off-by: Matt Sladen <matt5188@gmail.com>
@github-actions github-actions bot added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. service/events Issues and PRs that pertain to the events service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 11, 2022
@justinretzolk justinretzolk added bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 12, 2022
@ewbankkit ewbankkit self-assigned this May 1, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 1, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEventsConnection_' PKG=events ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.2 test ./internal/service/events/... -v -count 1 -parallel 3  -run=TestAccEventsConnection_ -timeout 360m
=== RUN   TestAccEventsConnection_apiKey
=== PAUSE TestAccEventsConnection_apiKey
=== RUN   TestAccEventsConnection_basic
=== PAUSE TestAccEventsConnection_basic
=== RUN   TestAccEventsConnection_oAuth
=== PAUSE TestAccEventsConnection_oAuth
=== RUN   TestAccEventsConnection_invocationHTTPParameters
=== PAUSE TestAccEventsConnection_invocationHTTPParameters
=== RUN   TestAccEventsConnection_disappears
=== PAUSE TestAccEventsConnection_disappears
=== CONT  TestAccEventsConnection_apiKey
=== CONT  TestAccEventsConnection_invocationHTTPParameters
=== CONT  TestAccEventsConnection_disappears
--- PASS: TestAccEventsConnection_disappears (25.23s)
=== CONT  TestAccEventsConnection_basic
--- PASS: TestAccEventsConnection_invocationHTTPParameters (64.66s)
=== CONT  TestAccEventsConnection_oAuth
--- PASS: TestAccEventsConnection_apiKey (65.10s)
--- PASS: TestAccEventsConnection_basic (60.92s)
--- PASS: TestAccEventsConnection_oAuth (74.59s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/events	149.657s

@ewbankkit
Copy link
Contributor

@mtt88 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit ac7dafd into hashicorp:main May 1, 2024
55 checks passed
@github-actions github-actions bot added this to the v5.48.0 milestone May 1, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

This functionality has been released in v5.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Jun 2, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/events Issues and PRs that pertain to the events service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Crash - AWS - Event Rule
3 participants