Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sesv2: Use AWS SDK v2 #26846

Merged
merged 2 commits into from
Sep 30, 2022
Merged

sesv2: Use AWS SDK v2 #26846

merged 2 commits into from
Sep 30, 2022

Conversation

kamilturek
Copy link
Collaborator

This PR moves sesv2 to AWS SDK v2 so all upcoming SESv2 resources and data sources can be implemented using the newest SDK.

No SESv2 resources/data resources are implemented at the moment.

Relates #26796.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Please review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. labels Sep 16, 2022
@github-actions
Copy link

Thank you for your contribution! 🚀

Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the go.mod or go.sum files and commit them into this pull request.

Additional details:

  • Check open pull requests with the dependencies label to view other dependency updates.
  • If this pull request includes an update the AWS Go SDK (or any other dependency) version, only updates submitted via dependabot will be merged. This pull request will need to remove these changes and will need to be rebased after the existing dependency update via dependabot has been merged for this pull request to be reviewed.
  • If this pull request is for supporting a new AWS service:
    • Ensure the new AWS service changes are following the Contributing Guide section on new services, in particular that the dependency addition and initial provider support are in a separate pull request from other changes (e.g. new resources). Contributions not following this item will not be reviewed until the changes are split.
    • If this pull request is already a separate pull request from the above item, you can ignore this message.

@kamilturek kamilturek marked this pull request as ready for review September 17, 2022 19:17
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Sep 28, 2022
@kamilturek
Copy link
Collaborator Author

I'll resolve the merge conflict.

@github-actions github-actions bot added size/XS Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Sep 30, 2022
@ewbankkit ewbankkit added the service/sesv2 Issues and PRs that pertain to the sesv2 service. label Sep 30, 2022
@ewbankkit ewbankkit merged commit ea37ab0 into hashicorp:main Sep 30, 2022
@github-actions github-actions bot added this to the v4.34.0 milestone Sep 30, 2022
@kamilturek kamilturek deleted the f-aws-sesv2-sdk-v2 branch September 30, 2022 20:09
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants