-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Data Source] d/aws_vpc_ipam_pool_cidrs #27051
[New Data Source] d/aws_vpc_ipam_pool_cidrs #27051
Conversation
Community NoteVoting for Prioritization
For Submitters
|
added pagination
|
84a1255
to
27ab02b
Compare
27ab02b
to
fafbcdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIPAMPoolCIDRsDataSource_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccIPAMPoolCIDRsDataSource_ -timeout 180m
=== RUN TestAccIPAMPoolCIDRsDataSource_basic
=== PAUSE TestAccIPAMPoolCIDRsDataSource_basic
=== CONT TestAccIPAMPoolCIDRsDataSource_basic
--- PASS: TestAccIPAMPoolCIDRsDataSource_basic (94.44s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 98.742s
@drewmullen Thanks for the contribution 🎉 👏. |
This functionality has been released in v4.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds a new data source to list all cidrs provisioned into a pool. This is especially helpful for those who receive a pool via ram sharing and want to add all CIDRs from a pool to route tables.
Relations
Closes #27040
References
Output from Acceptance Testing