Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sweepers/aws_evidently_project #27198

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

GlennChia
Copy link
Collaborator

Description

Sweepers for Evidently Project.

Relations

Relates #22624

References

Output from Acceptance Testing

$ make sweep SWEEPARGS=-sweep-run=aws_evidently SWEEP=us-west-2
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2 -sweep-run=aws_evidently -timeout 60m
2022/10/11 15:19:23 [DEBUG] Running Sweepers for region (us-west-2):
2022/10/11 15:19:23 [DEBUG] Running Sweeper (aws_evidently_project) in region (us-west-2)
2022/10/11 15:19:23 [INFO] Retrieved credentials from "EC2RoleProvider"
2022/10/11 15:19:23 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/11 15:19:24 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/11 15:19:25 [DEBUG] Completed Sweeper (aws_evidently_project) in region (us-west-2) in 2.072274992s
2022/10/11 15:19:25 Completed Sweepers for region (us-west-2) in 2.072366218s
2022/10/11 15:19:25 Sweeper Tests for region (us-west-2) ran successfully:
        - aws_evidently_project
ok      github.com/hashicorp/terraform-provider-aws/internal/sweep      2.093s


...

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. service/evidently Issues and PRs that pertain to the evidently service. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make sweep SWEEPARGS=-sweep-run=aws_evidently_project
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_evidently_project -timeout 60m
2022/10/13 08:51:50 [DEBUG] Running Sweepers for region (us-west-2):
2022/10/13 08:51:50 [DEBUG] Running Sweeper (aws_evidently_project) in region (us-west-2)
2022/10/13 08:51:50 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/10/13 08:51:50 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/13 08:51:51 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/13 08:51:52 [DEBUG] Completed Sweeper (aws_evidently_project) in region (us-west-2) in 2.018240832s
2022/10/13 08:51:52 Completed Sweepers for region (us-west-2) in 2.018500558s
2022/10/13 08:51:52 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_evidently_project
2022/10/13 08:51:52 [DEBUG] Running Sweepers for region (us-east-1):
2022/10/13 08:51:52 [DEBUG] Running Sweeper (aws_evidently_project) in region (us-east-1)
2022/10/13 08:51:52 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/10/13 08:51:52 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/13 08:51:52 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/13 08:51:53 [DEBUG] Completed Sweeper (aws_evidently_project) in region (us-east-1) in 781.753142ms
2022/10/13 08:51:53 Completed Sweepers for region (us-east-1) in 781.843262ms
2022/10/13 08:51:53 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_evidently_project
2022/10/13 08:51:53 [DEBUG] Running Sweepers for region (us-east-2):
2022/10/13 08:51:53 [DEBUG] Running Sweeper (aws_evidently_project) in region (us-east-2)
2022/10/13 08:51:53 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/10/13 08:51:53 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/13 08:51:53 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/13 08:51:54 [DEBUG] Completed Sweeper (aws_evidently_project) in region (us-east-2) in 1.114187574s
2022/10/13 08:51:54 Completed Sweepers for region (us-east-2) in 1.114239137s
2022/10/13 08:51:54 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_evidently_project
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	7.666s

@ewbankkit
Copy link
Contributor

@GlennChia Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit a49771e into hashicorp:main Oct 13, 2022
@github-actions github-actions bot added this to the v4.35.0 milestone Oct 13, 2022
@github-actions
Copy link

This functionality has been released in v4.35.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partner Contribution from a partner. service/evidently Issues and PRs that pertain to the evidently service. size/M Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants