update vendor #2722
Merged
update vendor #2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
force-pushed
the
jbardin/update-core-vendor
branch
from
65f61f2
to
239c61e
Compare
jen20
added
bug
radeksimko
approved these changes
Jan 3, 2018
catsby
approved these changes
Jan 4, 2018
|
I agree too. This was intended to get a release out ASAP, but the timeline fell through. I can merge this as is if we want to fix the linked issue, or wait for a core release (which should be soon-ish). |
|
If "soonish" is next week, then I think waiting would be 👍 |
apparentlymart
approved these changes
Jan 5, 2018
|
v0.11.2 is now out, so we could update this PR to reference that release by its tag. |
There's no reason to spend time installing the test dependencies separately from running the tests themselves. Remove `grep -v vendor`, the `./...` wildcard already excludes it.
jbardin
force-pushed
the
jbardin/update-core-vendor
branch
from
239c61e
to
1420480
Compare
Get the tagged version of terraform core. Removed a few more unused packages in the process.
jbardin
force-pushed
the
jbardin/update-core-vendor
branch
from
1420480
to
65b0601
Compare
|
Rebased on master, updated terraform packages to the v0.11.2 tag, and removed a few more unused vendor packages. |
This was referenced Jan 11, 2018
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update terraform to 0.11.2-a262a0e04, to fix the case where an empty string needs to be considered unset for a computed field. Fixes #2348
Clean unused packages from vendor folder.
Update GNUMakefile to build tests faster.