Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kendra sweepers #27259

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Fix Kendra sweepers #27259

merged 2 commits into from
Oct 20, 2022

Conversation

gdavison
Copy link
Contributor

The AWS SDK for Go v2 returns a different error than v1, which was causing an error for Amazon Kendra in unsupported regions.

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/kendra Issues and PRs that pertain to the kendra service. sweeper Pertains to changes to or issues with the sweeper. labels Oct 15, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make sweep SWEEPARGS=-sweep-run=aws_kendra_index
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
# set SWEEPARGS=-sweep-allow-failures to continue after first failure
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_kendra_index -timeout 60m
2022/10/16 17:44:12 [DEBUG] Running Sweepers for region (us-west-2):
2022/10/16 17:44:12 [DEBUG] Running Sweeper (aws_kendra_index) in region (us-west-2)
2022/10/16 17:44:12 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/10/16 17:44:12 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/16 17:44:13 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/16 17:44:14 [DEBUG] Completed Sweeper (aws_kendra_index) in region (us-west-2) in 1.525285257s
2022/10/16 17:44:14 Completed Sweepers for region (us-west-2) in 1.525517062s
2022/10/16 17:44:14 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_kendra_index
2022/10/16 17:44:14 [DEBUG] Running Sweepers for region (us-east-1):
2022/10/16 17:44:14 [DEBUG] Running Sweeper (aws_kendra_index) in region (us-east-1)
2022/10/16 17:44:14 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/10/16 17:44:14 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/16 17:44:17 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/16 17:44:17 [DEBUG] Completed Sweeper (aws_kendra_index) in region (us-east-1) in 3.614696012s
2022/10/16 17:44:17 Completed Sweepers for region (us-east-1) in 3.614719995s
2022/10/16 17:44:17 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_kendra_index
2022/10/16 17:44:17 [DEBUG] Running Sweepers for region (us-east-2):
2022/10/16 17:44:17 [DEBUG] Running Sweeper (aws_kendra_index) in region (us-east-2)
2022/10/16 17:44:17 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/10/16 17:44:17 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/16 17:44:18 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/10/16 17:44:25 [DEBUG] Completed Sweeper (aws_kendra_index) in region (us-east-2) in 7.840150082s
2022/10/16 17:44:25 Completed Sweepers for region (us-east-2) in 7.840171954s
2022/10/16 17:44:25 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_kendra_index
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	18.329s

@gdavison gdavison merged commit 22ffff2 into main Oct 20, 2022
@gdavison gdavison deleted the td-kendra-sweeper branch October 20, 2022 21:35
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 20, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/kendra Issues and PRs that pertain to the kendra service. size/S Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants