Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource aws_sesv2_dedicated_ip_pool #27278

Merged
merged 17 commits into from
Oct 18, 2022
Merged

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Oct 17, 2022

Description

Adds a new resource and data source aws_sesv2_dedicated_ip_pool.

Relations

Relates #26796
Closes #10703

Output from Acceptance Testing

$ make testacc PKG=sesv2 TESTS="TestAccSESV2DedicatedIPPool"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2DedicatedIPPool'  -timeout 180m
=== RUN   TestAccSESV2DedicatedIPPoolDataSource_basic
=== PAUSE TestAccSESV2DedicatedIPPoolDataSource_basic
=== RUN   TestAccSESV2DedicatedIPPool_basic
=== PAUSE TestAccSESV2DedicatedIPPool_basic
=== RUN   TestAccSESV2DedicatedIPPool_disappears
=== PAUSE TestAccSESV2DedicatedIPPool_disappears
=== RUN   TestAccSESV2DedicatedIPPool_tags
=== PAUSE TestAccSESV2DedicatedIPPool_tags
=== CONT  TestAccSESV2DedicatedIPPoolDataSource_basic
=== CONT  TestAccSESV2DedicatedIPPool_disappears
=== CONT  TestAccSESV2DedicatedIPPool_tags
=== CONT  TestAccSESV2DedicatedIPPool_basic
--- PASS: TestAccSESV2DedicatedIPPool_disappears (13.81s)
--- PASS: TestAccSESV2DedicatedIPPoolDataSource_basic (16.93s)
--- PASS: TestAccSESV2DedicatedIPPool_basic (18.25s)
--- PASS: TestAccSESV2DedicatedIPPool_tags (39.87s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      42.966s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sesv2 Issues and PRs that pertain to the sesv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 17, 2022
Copy link
Collaborator

@kamilturek kamilturek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

I left one comment but I'm not quite sure about it 😅 Maybe it's alright!

internal/service/sesv2/dedicated_ip_pool.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc PKG=sesv2 TESTS="TestAccSESV2DedicatedIPPool" ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 3 -run='TestAccSESV2DedicatedIPPool'  -timeout 180m
=== RUN   TestAccSESV2DedicatedIPPoolDataSource_basic
=== PAUSE TestAccSESV2DedicatedIPPoolDataSource_basic
=== RUN   TestAccSESV2DedicatedIPPool_basic
=== PAUSE TestAccSESV2DedicatedIPPool_basic
=== RUN   TestAccSESV2DedicatedIPPool_disappears
=== PAUSE TestAccSESV2DedicatedIPPool_disappears
=== RUN   TestAccSESV2DedicatedIPPool_tags
=== PAUSE TestAccSESV2DedicatedIPPool_tags
=== CONT  TestAccSESV2DedicatedIPPoolDataSource_basic
=== CONT  TestAccSESV2DedicatedIPPool_disappears
=== CONT  TestAccSESV2DedicatedIPPool_tags
--- PASS: TestAccSESV2DedicatedIPPool_disappears (16.68s)
=== CONT  TestAccSESV2DedicatedIPPool_basic
--- PASS: TestAccSESV2DedicatedIPPoolDataSource_basic (20.28s)
--- PASS: TestAccSESV2DedicatedIPPool_basic (18.63s)
--- PASS: TestAccSESV2DedicatedIPPool_tags (47.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	51.840s

@jar-b jar-b merged commit 55ad27d into main Oct 18, 2022
@jar-b jar-b deleted the f-aws_sesv2_dedicated_ip_pool branch October 18, 2022 18:59
@github-actions github-actions bot added this to the v4.36.0 milestone Oct 18, 2022
@github-actions
Copy link

This functionality has been released in v4.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/sesv2 Issues and PRs that pertain to the sesv2 service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support of dedicated IP pool in AWS SES
3 participants