r/aws_evidently_project - waiters

[GlennChia]

Description

CloudWatch Evidently Project has a status attribute (docs: API_GetProject). Valid values of status are AVAILABLE and UPDATING

Relations

Relates #24263
Relates #22624

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccEvidentlyProject' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyProject -timeout 180m
=== RUN   TestAccEvidentlyProject_basic
=== PAUSE TestAccEvidentlyProject_basic
=== RUN   TestAccEvidentlyProject_tags
=== PAUSE TestAccEvidentlyProject_tags
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== RUN   TestAccEvidentlyProject_disappears
=== PAUSE TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_basic
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== CONT  TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_tags
--- PASS: TestAccEvidentlyProject_disappears (22.29s)
--- PASS: TestAccEvidentlyProject_basic (48.00s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup (56.45s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3 (60.14s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Bucket (62.86s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Prefix (63.03s)
--- PASS: TestAccEvidentlyProject_tags (68.95s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  69.044s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ddericco]

LGTM - thanks @GlennChia!

[johnsonaj]

Thanks for the PR @GlennChia . I made some suggestions below. Please let me know if you have any questions about the changes

[GlennChia]

Thanks @johnsonaj, great catch! I'm surprised the IDE didn't throw any type errors. Re-ran the test cases successfully

$ make testacc TESTARGS='-run=TestAccEvidentlyProject' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyProject -timeout 180m
=== RUN   TestAccEvidentlyProject_basic
=== PAUSE TestAccEvidentlyProject_basic
=== RUN   TestAccEvidentlyProject_tags
=== PAUSE TestAccEvidentlyProject_tags
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== RUN   TestAccEvidentlyProject_disappears
=== PAUSE TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_basic
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== CONT  TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_tags
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
--- PASS: TestAccEvidentlyProject_disappears (22.46s)
--- PASS: TestAccEvidentlyProject_basic (48.06s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup (56.96s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3 (60.08s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Prefix (62.66s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Bucket (62.90s)
--- PASS: TestAccEvidentlyProject_tags (68.75s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  68.847s

[johnsonaj]

LGTM 🚀

$ make testacc TESTARGS='-run=TestAccEvidentlyProject' PKG=evidently                                            141 ↵
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyProject -timeout 180m
=== RUN   TestAccEvidentlyProject_basic
=== PAUSE TestAccEvidentlyProject_basic
=== RUN   TestAccEvidentlyProject_tags
=== PAUSE TestAccEvidentlyProject_tags
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== RUN   TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== RUN   TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== PAUSE TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== RUN   TestAccEvidentlyProject_disappears
=== PAUSE TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_basic
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Prefix
=== CONT  TestAccEvidentlyProject_disappears
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup
=== CONT  TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3
=== CONT  TestAccEvidentlyProject_updateDataDeliveryS3Bucket
=== CONT  TestAccEvidentlyProject_tags
--- PASS: TestAccEvidentlyProject_disappears (12.64s)
--- PASS: TestAccEvidentlyProject_basic (26.72s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchLogGroup (31.77s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Bucket (34.89s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryCloudWatchToS3 (35.01s)
--- PASS: TestAccEvidentlyProject_updateDataDeliveryS3Prefix (35.15s)
--- PASS: TestAccEvidentlyProject_tags (38.21s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/evidently	40.838s

[johnsonaj]

@GlennChia thanks for the contribution! 👏🏾 🎉

[github-actions]

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.