New Resource aws_sesv2_dedicated_ip_assignment

[jar-b]

Description

This resource will manage assignment of "standard" SES dedicated IP addresses to a dedicated IP pool.

Relations

Relates #26796

References

Requesting a dedicated IP address from AWS
https://docs.aws.amazon.com/ses/latest/dg/dedicated-ip-case.html

Bring your own IP address
https://docs.aws.amazon.com/ses/latest/dg/dedicated-ip-byo.html

Default IP pool ses-default-dedicated-ip-pool
https://docs.aws.amazon.com/ses/latest/dg/managing-ip-pools.html

Output from Acceptance Testing

$ SES_DEDICATED_IP="X.X.X.X" make testacc PKG=sesv2 TESTS="TestAccSESV2DedicatedIPAssignment_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2DedicatedIPAssignment_'  -timeout 180m
=== RUN   TestAccSESV2DedicatedIPAssignment_serial
=== RUN   TestAccSESV2DedicatedIPAssignment_serial/basic
=== RUN   TestAccSESV2DedicatedIPAssignment_serial/disappears
--- PASS: TestAccSESV2DedicatedIPAssignment_serial (30.54s)
    --- PASS: TestAccSESV2DedicatedIPAssignment_serial/basic (16.24s)
    --- PASS: TestAccSESV2DedicatedIPAssignment_serial/disappears (14.30s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      34.013s

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[jar-b]

I opted for ForceNew here, even though technically the IP could be moved via an update. This felt cleaner for the case where a config like the following has a pool_name change:

resource "aws_sesv2_dedicated_ip_pool" "test" {
  pool_name = "my-pool" # ex. change to my-pool2
}

resource "aws_sesv2_dedicated_ip_assignment" "test" {
  ip                    = "0.0.0.0"
  destination_pool_name = aws_sesv2_dedicated_ip_pool.test.pool_name
}

Without ForceNew:

• apply attempts to delete aws_sesv2_dedicated_ip_pool.test first, but fails because the pool isn't empty. This is resolved by a two-step apply. First, removing the assignment resource and applying to destroy it. Then the pool name can be updated and the assignment safely added back.
  • Adding logic to the dedicated IP pool destroy function to empty it first can't be done safely because it will cause a state change for assignment resources mid-apply.

With ForceNew:

• Both resources are destroyed and re-created with no side effects.

[kamilturek]

LGTM 👍

[ewbankkit]

LGTM 🚀.

% make testacc PKG=sesv2 TESTS="TestAccSESV2DedicatedIPAssignment_"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 20 -run='TestAccSESV2DedicatedIPAssignment_'  -timeout 180m
=== RUN   TestAccSESV2DedicatedIPAssignment_serial
=== RUN   TestAccSESV2DedicatedIPAssignment_serial/basic
    dedicated_ip_assignment_test.go:37: Environment variable SES_DEDICATED_IP is not set
=== RUN   TestAccSESV2DedicatedIPAssignment_serial/disappears
    dedicated_ip_assignment_test.go:69: Environment variable SES_DEDICATED_IP is not set
--- PASS: TestAccSESV2DedicatedIPAssignment_serial (0.00s)
    --- SKIP: TestAccSESV2DedicatedIPAssignment_serial/basic (0.00s)
    --- SKIP: TestAccSESV2DedicatedIPAssignment_serial/disappears (0.00s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/sesv2	4.482s

[github-actions]

This functionality has been released in v4.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.