Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple listeners for Virtual Nodes, Routers, and Gateways #27368

Closed
wants to merge 18 commits into from
Closed

Add multiple listeners for Virtual Nodes, Routers, and Gateways #27368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
886ecd5
Add multiple listeners for Virtual Nodes
benmurden Oct 20, 2022
25ba1ce
Add update test
benmurden Oct 21, 2022
395dcab
Add Virtual Router handling
benmurden Oct 21, 2022
f730f2c
Update Virtual Gateway handling
benmurden Oct 21, 2022
1af41c6
Add Virtual Router tests
benmurden Oct 21, 2022
c990a19
Fix ExactlyOneOf error
benmurden Oct 21, 2022
fd94c30
Fix test index
benmurden Oct 21, 2022
0ef5aa9
Add Virtual Router multipleListeners test
benmurden Oct 21, 2022
5ed5fb4
Fix expected port
benmurden Oct 21, 2022
2fb8e7a
Add Virtual Gateway tests
benmurden Oct 21, 2022
8b6ac5e
Documentation changes for multiple listeners.
benmurden Oct 21, 2022
80b796a
Update Changelog
benmurden Oct 21, 2022
e719c6f
Revert Changelog
benmurden Oct 21, 2022
98c1a4c
Add Changelog file
benmurden Oct 21, 2022
3582526
Add target port for Gateway Route & test
benmurden Nov 4, 2022
ced7793
Add Route target port and test
benmurden Nov 9, 2022
f344aaf
Add target port documentation
benmurden Nov 9, 2022
2a8fc56
Update Changelog
benmurden Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .changelog/27368.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
```release-note:enhancement
resource/aws_appmesh_virtual_node: Allow for multiple `listener` blocks
```

```release-note:enhancement
resource/aws_appmesh_virtual_router: Allow for multiple `listener` blocks
```

```release-note:enhancement
resource/aws_appmesh_virtual_gateway: Allow for multiple `listener` blocks
```

```release-note:enhancement
resource/aws_appmesh_gateway_route: Add `port` to `target` block, which is required when target Virtual Nodes or Virtual Routers have multiple listeners
```

```release-note:enhancement
resource/aws_appmesh_route: Add `port` to `weighted_target` block, which is required when target Virtual Nodes have multiple listeners
```
37 changes: 22 additions & 15 deletions internal/service/appmesh/appmesh_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,23 @@ func TestAccAppMesh_serial(t *testing.T) {
"tags": testAccMesh_tags,
},
"Route": {
"grpcRoute": testAccRoute_grpcRoute,
"grpcRouteEmptyMatch": testAccRoute_grpcRouteEmptyMatch,
"grpcRouteTimeout": testAccRoute_grpcRouteTimeout,
"http2Route": testAccRoute_http2Route,
"http2RouteTimeout": testAccRoute_http2RouteTimeout,
"httpHeader": testAccRoute_httpHeader,
"httpRetryPolicy": testAccRoute_httpRetryPolicy,
"httpRoute": testAccRoute_httpRoute,
"httpRouteTimeout": testAccRoute_httpRouteTimeout,
"routePriority": testAccRoute_routePriority,
"tcpRoute": testAccRoute_tcpRoute,
"tcpRouteTimeout": testAccRoute_tcpRouteTimeout,
"tags": testAccRoute_tags,
"grpcRoute": testAccRoute_grpcRoute,
"grpcRouteEmptyMatch": testAccRoute_grpcRouteEmptyMatch,
"grpcRouteTimeout": testAccRoute_grpcRouteTimeout,
"grpcRouteTargetPort": testAccRoute_grpcRouteTargetPort,
"http2Route": testAccRoute_http2Route,
"http2RouteTimeout": testAccRoute_http2RouteTimeout,
"http2RouteTargetPort": testAccRoute_http2RouteTargetPort,
"httpHeader": testAccRoute_httpHeader,
"httpRetryPolicy": testAccRoute_httpRetryPolicy,
"httpRoute": testAccRoute_httpRoute,
"httpRouteTimeout": testAccRoute_httpRouteTimeout,
"httpRouteTargetPort": testAccRoute_httpRouteTargetPort,
"routePriority": testAccRoute_routePriority,
"tcpRoute": testAccRoute_tcpRoute,
"tcpRouteTimeout": testAccRoute_tcpRouteTimeout,
"tcpRouteTargetPort": testAccRoute_tcpRouteTargetPort,
"tags": testAccRoute_tags,
},
"VirtualGateway": {
"basic": testAccVirtualGateway_basic,
Expand All @@ -43,6 +47,7 @@ func TestAccAppMesh_serial(t *testing.T) {
"listenerHealthChecks": testAccVirtualGateway_ListenerHealthChecks,
"listenerTls": testAccVirtualGateway_ListenerTLS,
"listenerValidation": testAccVirtualGateway_ListenerValidation,
"multipleListeners": testAccVirtualGateway_multipleListeners,
"logging": testAccVirtualGateway_Logging,
"tags": testAccVirtualGateway_Tags,
},
Expand All @@ -60,12 +65,14 @@ func TestAccAppMesh_serial(t *testing.T) {
"listenerTimeout": testAccVirtualNode_listenerTimeout,
"listenerTls": testAccVirtualNode_listenerTLS,
"listenerValidation": testAccVirtualNode_listenerValidation,
"multipleListeners": testAccVirtualNode_multipleListeners,
"logging": testAccVirtualNode_logging,
"tags": testAccVirtualNode_tags,
},
"VirtualRouter": {
"basic": testAccVirtualRouter_basic,
"tags": testAccVirtualRouter_tags,
"basic": testAccVirtualRouter_basic,
"multipleListeners": testAccVirtualRouter_multipleListeners,
"tags": testAccVirtualRouter_tags,
},
"VirtualService": {
"virtualNode": testAccVirtualService_virtualNode,
Expand Down
Loading