-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_sns_topic: Add support of prefixes #2753
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ColinHebert thanks so much for this enhancement! Sorry it took so long to get reviewed. This PR looks great and thanks for including the additional acceptance test. I'll actually be including an additional one to make sure the generated name bits are okay (which they are 😄 ).
make testacc TEST=./aws TESTARGS='-run=TestAccAWSSNSTopic_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -run=TestAccAWSSNSTopic_ -timeout 120m
=== RUN TestAccAWSSNSTopic_importBasic
--- PASS: TestAccAWSSNSTopic_importBasic (11.68s)
=== RUN TestAccAWSSNSTopic_basic
--- PASS: TestAccAWSSNSTopic_basic (9.02s)
=== RUN TestAccAWSSNSTopic_name
--- PASS: TestAccAWSSNSTopic_name (10.67s)
=== RUN TestAccAWSSNSTopic_namePrefix
--- PASS: TestAccAWSSNSTopic_namePrefix (9.51s)
=== RUN TestAccAWSSNSTopic_policy
--- PASS: TestAccAWSSNSTopic_policy (10.46s)
=== RUN TestAccAWSSNSTopic_withIAMRole
--- PASS: TestAccAWSSNSTopic_withIAMRole (29.56s)
=== RUN TestAccAWSSNSTopic_withFakeIAMRole
--- PASS: TestAccAWSSNSTopic_withFakeIAMRole (66.70s)
=== RUN TestAccAWSSNSTopic_withDeliveryPolicy
--- PASS: TestAccAWSSNSTopic_withDeliveryPolicy (10.03s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 157.691s
…me generated/name/name_prefix bits for clarity
This has been released in terraform-provider-aws version 1.9.0. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
No description provided.