r/aws_transfer_user - fix error removing home_directory_mappings

[mtt88]

Description

It's not currently possible to completely remove all home_directory_mappings attributes from a transfer user. Removing all
home_directory_mappings from a transfer_user was represented as an empty list. This caused a validation error in the AWS SDK. See here.

HomeDirectoryMappings []*HomeDirectoryMapEntry `min:"1" type:"list"`

InvalidParameter: 1 validation error(s) found.
│ - minimum field size of 1, UpdateUserInput.HomeDirectoryMappings.

We now represent this value as nil rather than an empty list.

Note: The tests for transfer package are serial/non-concurrent. I temporarily changed the access of the test to allow individual execution and the output below.

Relations

Output from Acceptance Testing

 make testacc TESTS=TestAccUser_homeDirectoryMappings PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccUser_homeDirectoryMappings'  -timeout 180m
=== RUN   TestAccUser_homeDirectoryMappings
--- PASS: TestAccUser_homeDirectoryMappings (233.59s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   233.643s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/User' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/User -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/User
=== RUN   TestAccTransfer_serial/User/UserNameValidation
=== RUN   TestAccTransfer_serial/User/basic
=== RUN   TestAccTransfer_serial/User/disappears
=== RUN   TestAccTransfer_serial/User/tags
=== RUN   TestAccTransfer_serial/User/HomeDirectoryMappings
=== RUN   TestAccTransfer_serial/User/ModifyWithOptions
=== RUN   TestAccTransfer_serial/User/Posix
--- PASS: TestAccTransfer_serial (1164.51s)
    --- PASS: TestAccTransfer_serial/User (1164.51s)
        --- PASS: TestAccTransfer_serial/User/UserNameValidation (16.07s)
        --- PASS: TestAccTransfer_serial/User/basic (190.77s)
        --- PASS: TestAccTransfer_serial/User/disappears (157.61s)
        --- PASS: TestAccTransfer_serial/User/tags (210.15s)
        --- PASS: TestAccTransfer_serial/User/HomeDirectoryMappings (201.15s)
        --- PASS: TestAccTransfer_serial/User/ModifyWithOptions (199.25s)
        --- PASS: TestAccTransfer_serial/User/Posix (162.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	1169.975s

[ewbankkit]

@mtt88 Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.