-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new resource: aws_ivs_channel #27726
Conversation
Community NoteVoting for Prioritization
For Submitters
|
- Remove multiple consecutive blank lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some implementation questions that I wanted to ask which may require some rework, so I wanted to get this PR tonight to grab some feedback. Please take a look. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIVSChannel_' PKG=ivs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ivs/... -v -count 1 -parallel 2 -run=TestAccIVSChannel_ -timeout 180m
=== RUN TestAccIVSChannel_basic
=== PAUSE TestAccIVSChannel_basic
=== RUN TestAccIVSChannel_tags
=== PAUSE TestAccIVSChannel_tags
=== RUN TestAccIVSChannel_update
=== PAUSE TestAccIVSChannel_update
=== RUN TestAccIVSChannel_disappears
=== PAUSE TestAccIVSChannel_disappears
=== RUN TestAccIVSChannel_recordingConfiguration
=== PAUSE TestAccIVSChannel_recordingConfiguration
=== CONT TestAccIVSChannel_basic
=== CONT TestAccIVSChannel_disappears
--- PASS: TestAccIVSChannel_disappears (18.36s)
=== CONT TestAccIVSChannel_update
--- PASS: TestAccIVSChannel_basic (23.41s)
=== CONT TestAccIVSChannel_tags
--- PASS: TestAccIVSChannel_update (34.64s)
=== CONT TestAccIVSChannel_recordingConfiguration
--- PASS: TestAccIVSChannel_tags (46.56s)
--- PASS: TestAccIVSChannel_recordingConfiguration (29.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ivs 86.816s
@KevinEady Thanks for the contribution 🎉 👏. |
Hi @ewbankkit , Thanks for the review! Comments sound good to me, so this can go ahead and be merged. I'll be pushing the final entity, Thanks, Kevin |
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add new resource for AWS IVS Channel: aws_ivs_channel. This PR is the third in a set to support the full AWS IVS entities:
Playback Key PairRecording ConfigurationRelations
Relates #17272
Output from Acceptance Testing