-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_sesv2: make use of enum.Validate #27783
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=sesv2 TESTS="TestAccSESV2ConfigurationSet_|TestAccSESV2EmailIdentity_" ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 4 -run='TestAccSESV2ConfigurationSet_|TestAccSESV2EmailIdentity_' -timeout 180m
=== RUN TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== RUN TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== RUN TestAccSESV2EmailIdentity_disappears
=== PAUSE TestAccSESV2EmailIdentity_disappears
=== RUN TestAccSESV2EmailIdentity_configurationSetName
=== PAUSE TestAccSESV2EmailIdentity_configurationSetName
=== RUN TestAccSESV2EmailIdentity_nextSigningKeyLength
=== PAUSE TestAccSESV2EmailIdentity_nextSigningKeyLength
=== RUN TestAccSESV2EmailIdentity_domainSigning
=== PAUSE TestAccSESV2EmailIdentity_domainSigning
=== RUN TestAccSESV2EmailIdentity_tags
=== PAUSE TestAccSESV2EmailIdentity_tags
=== CONT TestAccSESV2ConfigurationSet_basic
=== CONT TestAccSESV2EmailIdentity_basic_emailAddress
=== CONT TestAccSESV2ConfigurationSet_sendingEnabled
=== CONT TestAccSESV2ConfigurationSet_tags
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (18.68s)
=== CONT TestAccSESV2ConfigurationSet_suppressedReasons
--- PASS: TestAccSESV2ConfigurationSet_basic (18.72s)
=== CONT TestAccSESV2ConfigurationSet_tlsPolicy
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (29.48s)
=== CONT TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_tags (40.48s)
=== CONT TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (26.86s)
=== CONT TestAccSESV2EmailIdentity_nextSigningKeyLength
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (27.08s)
=== CONT TestAccSESV2EmailIdentity_tags
--- PASS: TestAccSESV2ConfigurationSet_disappears (10.96s)
=== CONT TestAccSESV2EmailIdentity_domainSigning
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (26.41s)
=== CONT TestAccSESV2EmailIdentity_disappears
--- PASS: TestAccSESV2EmailIdentity_disappears (11.47s)
=== CONT TestAccSESV2EmailIdentity_configurationSetName
--- PASS: TestAccSESV2EmailIdentity_nextSigningKeyLength (28.97s)
=== CONT TestAccSESV2EmailIdentity_basic_domain
--- PASS: TestAccSESV2EmailIdentity_domainSigning (28.05s)
--- PASS: TestAccSESV2EmailIdentity_tags (38.45s)
--- PASS: TestAccSESV2EmailIdentity_basic_domain (17.99s)
--- PASS: TestAccSESV2EmailIdentity_configurationSetName (28.33s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sesv2 98.805s
This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This PR makes use of the
enum.Validate
validator and removes the redundant functions for converting AWS SDK v2 enum types.Relations
Relates #26796.
Output from Acceptance Testing