Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_sesv2: make use of enum.Validate #27783

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

kamilturek
Copy link
Collaborator

Description

This PR makes use of the enum.Validate validator and removes the redundant functions for converting AWS SDK v2 enum types.

Relations

Relates #26796.

Output from Acceptance Testing

$ make testacc TESTARGS='-run="TestAccSESV2ConfigurationSet_|TestAccSESV2EmailIdentity_"' PKG=sesv2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
/bin/sh: line 0: [: missing `]'
/bin/sh: TestAccSESV2EmailIdentity_: command not found
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 2  -run="TestAccSESV2ConfigurationSet_|TestAccSESV2EmailIdentity_" -timeout 180m
=== RUN   TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN   TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN   TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN   TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN   TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== RUN   TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN   TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== RUN   TestAccSESV2EmailIdentity_disappears
=== PAUSE TestAccSESV2EmailIdentity_disappears
=== RUN   TestAccSESV2EmailIdentity_configurationSetName
=== PAUSE TestAccSESV2EmailIdentity_configurationSetName
=== RUN   TestAccSESV2EmailIdentity_nextSigningKeyLength
=== PAUSE TestAccSESV2EmailIdentity_nextSigningKeyLength
=== RUN   TestAccSESV2EmailIdentity_domainSigning
=== PAUSE TestAccSESV2EmailIdentity_domainSigning
=== RUN   TestAccSESV2EmailIdentity_tags
=== PAUSE TestAccSESV2EmailIdentity_tags
=== CONT  TestAccSESV2ConfigurationSet_basic
=== CONT  TestAccSESV2EmailIdentity_basic_emailAddress
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (28.14s)
=== CONT  TestAccSESV2ConfigurationSet_sendingEnabled
--- PASS: TestAccSESV2ConfigurationSet_basic (28.14s)
=== CONT  TestAccSESV2ConfigurationSet_tags
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (44.20s)
=== CONT  TestAccSESV2ConfigurationSet_tlsPolicy
--- PASS: TestAccSESV2ConfigurationSet_tags (62.12s)
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasons
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (42.55s)
=== CONT  TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (42.38s)
=== CONT  TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_disappears (17.30s)
=== CONT  TestAccSESV2EmailIdentity_disappears
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (42.12s)
=== CONT  TestAccSESV2EmailIdentity_configurationSetName
--- PASS: TestAccSESV2EmailIdentity_disappears (17.52s)
=== CONT  TestAccSESV2EmailIdentity_nextSigningKeyLength
--- PASS: TestAccSESV2EmailIdentity_configurationSetName (45.59s)
=== CONT  TestAccSESV2EmailIdentity_tags
--- PASS: TestAccSESV2EmailIdentity_nextSigningKeyLength (44.30s)
=== CONT  TestAccSESV2EmailIdentity_basic_domain
--- PASS: TestAccSESV2EmailIdentity_basic_domain (26.18s)
=== CONT  TestAccSESV2EmailIdentity_domainSigning
--- PASS: TestAccSESV2EmailIdentity_tags (61.16s)
--- PASS: TestAccSESV2EmailIdentity_domainSigning (42.93s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      282.713s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/sesv2 Issues and PRs that pertain to the sesv2 service. needs-triage Waiting for first response or review from a maintainer. size/S Managed by automation to categorize the size of a PR. labels Nov 13, 2022
@kamilturek kamilturek marked this pull request as ready for review November 14, 2022 07:57
@johnsonaj johnsonaj removed the needs-triage Waiting for first response or review from a maintainer. label Nov 14, 2022
@jar-b jar-b self-assigned this Nov 14, 2022
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc PKG=sesv2 TESTS="TestAccSESV2ConfigurationSet_|TestAccSESV2EmailIdentity_" ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sesv2/... -v -count 1 -parallel 4 -run='TestAccSESV2ConfigurationSet_|TestAccSESV2EmailIdentity_'  -timeout 180m
=== RUN   TestAccSESV2ConfigurationSet_basic
=== PAUSE TestAccSESV2ConfigurationSet_basic
=== RUN   TestAccSESV2ConfigurationSet_disappears
=== PAUSE TestAccSESV2ConfigurationSet_disappears
=== RUN   TestAccSESV2ConfigurationSet_tlsPolicy
=== PAUSE TestAccSESV2ConfigurationSet_tlsPolicy
=== RUN   TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== PAUSE TestAccSESV2ConfigurationSet_reputationMetricsEnabled
=== RUN   TestAccSESV2ConfigurationSet_sendingEnabled
=== PAUSE TestAccSESV2ConfigurationSet_sendingEnabled
=== RUN   TestAccSESV2ConfigurationSet_suppressedReasons
=== PAUSE TestAccSESV2ConfigurationSet_suppressedReasons
=== RUN   TestAccSESV2ConfigurationSet_tags
=== PAUSE TestAccSESV2ConfigurationSet_tags
=== RUN   TestAccSESV2EmailIdentity_basic_emailAddress
=== PAUSE TestAccSESV2EmailIdentity_basic_emailAddress
=== RUN   TestAccSESV2EmailIdentity_basic_domain
=== PAUSE TestAccSESV2EmailIdentity_basic_domain
=== RUN   TestAccSESV2EmailIdentity_disappears
=== PAUSE TestAccSESV2EmailIdentity_disappears
=== RUN   TestAccSESV2EmailIdentity_configurationSetName
=== PAUSE TestAccSESV2EmailIdentity_configurationSetName
=== RUN   TestAccSESV2EmailIdentity_nextSigningKeyLength
=== PAUSE TestAccSESV2EmailIdentity_nextSigningKeyLength
=== RUN   TestAccSESV2EmailIdentity_domainSigning
=== PAUSE TestAccSESV2EmailIdentity_domainSigning
=== RUN   TestAccSESV2EmailIdentity_tags
=== PAUSE TestAccSESV2EmailIdentity_tags
=== CONT  TestAccSESV2ConfigurationSet_basic
=== CONT  TestAccSESV2EmailIdentity_basic_emailAddress
=== CONT  TestAccSESV2ConfigurationSet_sendingEnabled
=== CONT  TestAccSESV2ConfigurationSet_tags
--- PASS: TestAccSESV2EmailIdentity_basic_emailAddress (18.68s)
=== CONT  TestAccSESV2ConfigurationSet_suppressedReasons
--- PASS: TestAccSESV2ConfigurationSet_basic (18.72s)
=== CONT  TestAccSESV2ConfigurationSet_tlsPolicy
--- PASS: TestAccSESV2ConfigurationSet_sendingEnabled (29.48s)
=== CONT  TestAccSESV2ConfigurationSet_reputationMetricsEnabled
--- PASS: TestAccSESV2ConfigurationSet_tags (40.48s)
=== CONT  TestAccSESV2ConfigurationSet_disappears
--- PASS: TestAccSESV2ConfigurationSet_tlsPolicy (26.86s)
=== CONT  TestAccSESV2EmailIdentity_nextSigningKeyLength
--- PASS: TestAccSESV2ConfigurationSet_suppressedReasons (27.08s)
=== CONT  TestAccSESV2EmailIdentity_tags
--- PASS: TestAccSESV2ConfigurationSet_disappears (10.96s)
=== CONT  TestAccSESV2EmailIdentity_domainSigning
--- PASS: TestAccSESV2ConfigurationSet_reputationMetricsEnabled (26.41s)
=== CONT  TestAccSESV2EmailIdentity_disappears
--- PASS: TestAccSESV2EmailIdentity_disappears (11.47s)
=== CONT  TestAccSESV2EmailIdentity_configurationSetName
--- PASS: TestAccSESV2EmailIdentity_nextSigningKeyLength (28.97s)
=== CONT  TestAccSESV2EmailIdentity_basic_domain
--- PASS: TestAccSESV2EmailIdentity_domainSigning (28.05s)
--- PASS: TestAccSESV2EmailIdentity_tags (38.45s)
--- PASS: TestAccSESV2EmailIdentity_basic_domain (17.99s)
--- PASS: TestAccSESV2EmailIdentity_configurationSetName (28.33s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sesv2      98.805s

@jar-b jar-b merged commit f23a9c4 into hashicorp:main Nov 14, 2022
@github-actions github-actions bot added this to the v4.40.0 milestone Nov 14, 2022
@kamilturek kamilturek deleted the td-aws-sesv2-enum-validation branch November 14, 2022 20:32
@github-actions
Copy link

This functionality has been released in v4.40.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/sesv2 Issues and PRs that pertain to the sesv2 service. size/S Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants