Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace will create a logging configuration if one does not exist d… #27956

Conversation

TheJacobWalters
Copy link

@TheJacobWalters TheJacobWalters commented Nov 22, 2022

Description

This pull request will change the functionality of the Amazon Managed Prometheus service. Right now there will be an error if a Amazon Managed Prometheus workspace is created without a logging configuration, then during an update of the workspace a logging configuration is added. After this change, during a workspace update a logging configuration will be created if one doesn't exist.

Closes #27472

Output from Acceptance Testing

$ AWS_PROFILE=default TF_ACC=1 go test ./internal/service/amp/... -parallel 8
ok      github.com/hashicorp/terraform-provider-aws/internal/service/amp        336.806s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. service/amp Issues and PRs that pertain to the amp service. needs-triage Waiting for first response or review from a maintainer. labels Nov 22, 2022
@TheJacobWalters TheJacobWalters marked this pull request as draft November 22, 2022 19:19
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @TheJacobWalters 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Nov 22, 2022
@TheJacobWalters
Copy link
Author

TheJacobWalters commented Nov 23, 2022

@ewbankkit Ok I had some issues with white spaces, and some problems with unidiomatic code. I have fixed both those issues. Also I've updated my MR to show the output of running the test suite locally.

Can you run the tests again?

@breathingdust breathingdust added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 24, 2022
@TheJacobWalters TheJacobWalters marked this pull request as ready for review November 30, 2022 15:13
Copy link

@rohang98 rohang98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@TheJacobWalters
Copy link
Author

@ewbankkit can you help me get this merged in.

@TheJacobWalters
Copy link
Author

I need close this go through an open source process with my employer and then repopen this to comply with some legal processes.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/amp Issues and PRs that pertain to the amp service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't enable logging configuration for existing AWS Prometheus workspace
3 participants