-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workspace will create a logging configuration if one does not exist d… #27956
workspace will create a logging configuration if one does not exist d… #27956
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @TheJacobWalters 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@ewbankkit Ok I had some issues with white spaces, and some problems with unidiomatic code. I have fixed both those issues. Also I've updated my MR to show the output of running the test suite locally. Can you run the tests again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for fixing this!
@ewbankkit can you help me get this merged in. |
I need close this go through an open source process with my employer and then repopen this to comply with some legal processes. |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request will change the functionality of the Amazon Managed Prometheus service. Right now there will be an error if a Amazon Managed Prometheus workspace is created without a logging configuration, then during an update of the workspace a logging configuration is added. After this change, during a workspace update a logging configuration will be created if one doesn't exist.
Closes #27472
Output from Acceptance Testing