service-dms-endpoint-s3Settings-compressionType is no longer supported for source endpoints

[rossbush]

Description

Remove default value of "NONE" for dms endpoint S3 compression. Source s3 endpoints no longer support compressionType. When not set, the aws default is no compression. This allows the target to continue to define a compressionType while source endpoints can get around the bug by not setting a value for this property. The only other work around is change source endpoint to target, deploy and the change it back to source and deploy, for each dms task, which is not ideal.

Relations

Relates #27852

References

#27283

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[sbuzan]

Do we have an ETA when this will be released?

[YakDriver]

Thank you so much for your work on this and interest! 🎉

Unfortunately, this fix would not be sufficient.

1. As noted in this comment, there are other attributes affected as well.
2. Removing the default is generally considered a breaking change (although here no value and NONE are equivalent).
3. Removing the default results in diffs. When COMPRESSION_TYPE is not included in the configuration, AWS returns NONE but the configuration is "", which causes a diff.

In order to address these problems and additional continuing challenges with the deprecation of extra connection attributes, we have created a new resource aws_dms_s3_endpoint (see #28130). Hopefully this will allow us to move forward in a much cleaner way than continuing to try to rework aws_dms_endpoint.

[github-actions]

This functionality has been released in v4.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.