Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_ce_cost_category - make effective_start an argument #28055

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

DrFaust92
Copy link
Collaborator

Description

Relations

Closes #28009

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccCECostCategory_ PKG=ce

--- PASS: TestAccCECostCategory_disappears (31.25s)
--- PASS: TestAccCECostCategory_basic (47.13s)
--- PASS: TestAccCECostCategory_complete (67.70s)
--- PASS: TestAccCECostCategory_effectiveStart (71.30s)
--- PASS: TestAccCECostCategory_splitCharge (72.68s)
--- PASS: TestAccCECostCategory_tags (96.73s)

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ce Issues and PRs that pertain to the ce service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. and removed documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. service/ce Issues and PRs that pertain to the ce service. labels Nov 28, 2022
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/ce Issues and PRs that pertain to the ce service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2022
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 28, 2022
@DrFaust92 DrFaust92 marked this pull request as ready for review November 28, 2022 21:05
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCECostCategory_' PKG=ce ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ce/... -v -count 1 -parallel 2  -run=TestAccCECostCategory_ -timeout 180m
=== RUN   TestAccCECostCategory_basic
=== PAUSE TestAccCECostCategory_basic
=== RUN   TestAccCECostCategory_effectiveStart
=== PAUSE TestAccCECostCategory_effectiveStart
=== RUN   TestAccCECostCategory_disappears
=== PAUSE TestAccCECostCategory_disappears
=== RUN   TestAccCECostCategory_complete
=== PAUSE TestAccCECostCategory_complete
=== RUN   TestAccCECostCategory_splitCharge
=== PAUSE TestAccCECostCategory_splitCharge
=== RUN   TestAccCECostCategory_tags
=== PAUSE TestAccCECostCategory_tags
=== CONT  TestAccCECostCategory_basic
=== CONT  TestAccCECostCategory_complete
--- PASS: TestAccCECostCategory_basic (22.78s)
=== CONT  TestAccCECostCategory_disappears
--- PASS: TestAccCECostCategory_complete (38.15s)
=== CONT  TestAccCECostCategory_tags
=== CONT  TestAccCECostCategory_splitCharge
--- PASS: TestAccCECostCategory_disappears (15.38s)
--- PASS: TestAccCECostCategory_splitCharge (37.87s)
=== CONT  TestAccCECostCategory_effectiveStart
--- PASS: TestAccCECostCategory_tags (46.18s)
--- PASS: TestAccCECostCategory_effectiveStart (30.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ce	112.187s

@ewbankkit
Copy link
Contributor

@DrFaust92 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 0e688d3 into hashicorp:main Nov 29, 2022
@github-actions github-actions bot added this to the v4.43.0 milestone Nov 29, 2022
@github-actions
Copy link

This functionality has been released in v4.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ce Issues and PRs that pertain to the ce service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Allow setting of effective_start on aws_ce_cost_category
2 participants