Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cidr_list_aliases to aws_lightsail_instance_public_ports #28376

Merged

Conversation

bschaatsbergen
Copy link
Member

@bschaatsbergen bschaatsbergen commented Dec 15, 2022

Description

Relations

Closes #28285

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccLightsailInstancePublicPorts_ PKG=lightsail
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 20 -run='TestAccLightsailInstancePublicPorts_'  -timeout 180m
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstancePublicPorts_multiple
=== PAUSE TestAccLightsailInstancePublicPorts_multiple
=== RUN   TestAccLightsailInstancePublicPorts_cidrs
=== PAUSE TestAccLightsailInstancePublicPorts_cidrs
=== RUN   TestAccLightsailInstancePublicPorts_cidrListAliases
=== PAUSE TestAccLightsailInstancePublicPorts_cidrListAliases
=== RUN   TestAccLightsailInstancePublicPorts_disappears
=== PAUSE TestAccLightsailInstancePublicPorts_disappears
=== RUN   TestAccLightsailInstancePublicPorts_disappears_Instance
=== PAUSE TestAccLightsailInstancePublicPorts_disappears_Instance
=== CONT  TestAccLightsailInstancePublicPorts_basic
=== CONT  TestAccLightsailInstancePublicPorts_cidrListAliases
=== CONT  TestAccLightsailInstancePublicPorts_disappears_Instance
=== CONT  TestAccLightsailInstancePublicPorts_cidrs
=== CONT  TestAccLightsailInstancePublicPorts_multiple
=== CONT  TestAccLightsailInstancePublicPorts_disappears
--- PASS: TestAccLightsailInstancePublicPorts_multiple (55.65s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (59.39s)
--- PASS: TestAccLightsailInstancePublicPorts_disappears (61.95s)
--- PASS: TestAccLightsailInstancePublicPorts_basic (62.48s)
--- PASS: TestAccLightsailInstancePublicPorts_cidrListAliases (62.58s)
--- PASS: TestAccLightsailInstancePublicPorts_cidrs (62.99s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/lightsail  64.991s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XS Managed by automation to categorize the size of a PR. service/lightsail Issues and PRs that pertain to the lightsail service. labels Dec 15, 2022
@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed size/XS Managed by automation to categorize the size of a PR. labels Dec 15, 2022
@bschaatsbergen bschaatsbergen force-pushed the lightsail-public-ports-cidr-aliases branch from 58089c9 to 29ef95a Compare December 15, 2022 12:58
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 15, 2022
@bschaatsbergen bschaatsbergen marked this pull request as ready for review December 15, 2022 13:02
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Dec 21, 2022
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 21, 2022
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccLightsailInstancePublicPorts_' PKG=lightsail ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lightsail/... -v -count 1 -parallel 3  -run=TestAccLightsailInstancePublicPorts_ -timeout 180m
=== RUN   TestAccLightsailInstancePublicPorts_basic
=== PAUSE TestAccLightsailInstancePublicPorts_basic
=== RUN   TestAccLightsailInstancePublicPorts_multiple
=== PAUSE TestAccLightsailInstancePublicPorts_multiple
=== RUN   TestAccLightsailInstancePublicPorts_cidrs
=== PAUSE TestAccLightsailInstancePublicPorts_cidrs
=== RUN   TestAccLightsailInstancePublicPorts_cidrListAliases
=== PAUSE TestAccLightsailInstancePublicPorts_cidrListAliases
=== RUN   TestAccLightsailInstancePublicPorts_disappears
=== PAUSE TestAccLightsailInstancePublicPorts_disappears
=== RUN   TestAccLightsailInstancePublicPorts_disappears_Instance
=== PAUSE TestAccLightsailInstancePublicPorts_disappears_Instance
=== CONT  TestAccLightsailInstancePublicPorts_basic
=== CONT  TestAccLightsailInstancePublicPorts_cidrListAliases
=== CONT  TestAccLightsailInstancePublicPorts_disappears_Instance
--- PASS: TestAccLightsailInstancePublicPorts_disappears_Instance (54.42s)
=== CONT  TestAccLightsailInstancePublicPorts_disappears
--- PASS: TestAccLightsailInstancePublicPorts_basic (57.34s)
=== CONT  TestAccLightsailInstancePublicPorts_cidrs
--- PASS: TestAccLightsailInstancePublicPorts_cidrListAliases (57.86s)
=== CONT  TestAccLightsailInstancePublicPorts_multiple
--- PASS: TestAccLightsailInstancePublicPorts_disappears (54.48s)
--- PASS: TestAccLightsailInstancePublicPorts_cidrs (54.41s)
--- PASS: TestAccLightsailInstancePublicPorts_multiple (56.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lightsail	119.625s

@ewbankkit
Copy link
Contributor

@bschaatsbergen Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1e7e782 into hashicorp:main Dec 21, 2022
@github-actions github-actions bot added this to the v4.49.0 milestone Dec 21, 2022
@bschaatsbergen bschaatsbergen deleted the lightsail-public-ports-cidr-aliases branch December 21, 2022 16:15
@github-actions
Copy link

github-actions bot commented Jan 5, 2023

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Feb 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/lightsail Issues and PRs that pertain to the lightsail service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: aws_lightsail_instance_public_ports.port_info should contain "cidrListAliases" too
2 participants