aws_dms_endpoint.ignore_header_rows typo

[bennylu2]

Description

Fix typo in setting, should be ignore_header_rows not ignore_headers_row

Relations

Closes #26957

References

https://docs.aws.amazon.com/dms/latest/APIReference/API_S3Settings.html

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[YakDriver]

What we should do here is add the new correct setting and keep the old with a deprecation (and "btw this setting does nothing") warning. That way, people's configurations won't break but we can move forward with the right stuff. Then we can make an issue for v5 to remove the deprecated, erroneous setting.

[bennylu2]

What we should do here is add the new correct setting and keep the old with a deprecation (and "btw this setting does nothing") warning. That way, people's configurations won't break but we can move forward with the right stuff. Then we can make an issue for v5 to remove the deprecated, erroneous setting.

@YakDriver did you want me to make these changes or were you taking it? Was unsure but I can get to this later this week

[YakDriver]

@bennylu2 Thanks for your work on this! I added the deprecated setting back.

[YakDriver]

LGTM 🎉

% make testacc TESTS=TestAccDMSEndpoint_S3 PKG=dms
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_S3'  -timeout 180m
=== RUN   TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN   TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== CONT  TestAccDMSEndpoint_S3_basic
=== CONT  TestAccDMSEndpoint_S3_extraConnectionAttributes
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (52.43s)
--- PASS: TestAccDMSEndpoint_S3_basic (65.12s)

[github-actions]

This functionality has been released in v4.49.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.