-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug in validation regex of aws_appflow_connector_profile resource #28608
Fixed bug in validation regex of aws_appflow_connector_profile resource #28608
Conversation
…ce causing any given value for the sapo_data's profile properties logon_language field to be denied
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc PKG=appflow TESTS=TestAccAppFlowConnectorProfile_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/appflow/... -v -count 1 -parallel 20 -run='TestAccAppFlowConnectorProfile_' -timeout 180m
=== RUN TestAccAppFlowConnectorProfile_basic
=== PAUSE TestAccAppFlowConnectorProfile_basic
=== RUN TestAccAppFlowConnectorProfile_update
=== PAUSE TestAccAppFlowConnectorProfile_update
=== RUN TestAccAppFlowConnectorProfile_disappears
=== PAUSE TestAccAppFlowConnectorProfile_disappears
=== CONT TestAccAppFlowConnectorProfile_basic
=== CONT TestAccAppFlowConnectorProfile_disappears
=== CONT TestAccAppFlowConnectorProfile_update
--- PASS: TestAccAppFlowConnectorProfile_disappears (241.68s)
--- PASS: TestAccAppFlowConnectorProfile_update (289.88s)
--- PASS: TestAccAppFlowConnectorProfile_basic (319.68s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/appflow 322.786s
Thanks for your contribution, @jclRatepay! 👍 |
This functionality has been released in v4.55.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixed bug in validation regex of "aws_appflow_connector_profile" resource causing any given value for the "connector_profile_config.0.connector_profile_properties.0.sapo_data.0.logon_language" field to be denied
Relations
Closes #28550
References
Output from Acceptance Testing
Checking the available acceptance tests I quickly realized that due to the huge amount of possible argument combinations on the one hand and the necessity for having a huge bunch of third party applications like Salesforce or SAP available no specific tests for that scenario exists.
However, to test the fix I used my local development environment and checked whether setting an AppFlow Connector's SAP logon language via the updated Terraform Provider code is now possible when using a valid value (e.g. EN), and it worked as expected and is not failing with validation errors during planning anymore.