Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_apprunner_service observability_configuration_arn optional #28620

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

bennylu2
Copy link
Contributor

Description

Make observability_configuration_arn optional

Relations

Closes #27733

References

https://docs.aws.amazon.com/apprunner/latest/api/API_ServiceObservabilityConfiguration.html

Output from Acceptance Testing

make testacc TESTS='TestAccAppRunnerService_ImageRepository_observabilityConfiguration' PKG=apprunner
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 20 -run='TestAccAppRunnerService_ImageRepository_observabilityConfiguration'  -timeout 180m
=== RUN   TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== CONT  TestAccAppRunnerService_ImageRepository_observabilityConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_observabilityConfiguration (546.44s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/apprunner  560.685s

@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/apprunner Issues and PRs that pertain to the apprunner service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Dec 30, 2022
@bennylu2 bennylu2 changed the title B aws apprunner service 27733 aws_apprunner_service observability_configuration_arn optional Dec 30, 2022
@DrFaust92 DrFaust92 added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 31, 2022
@bschaatsbergen bschaatsbergen self-requested a review December 31, 2022 20:00
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAppRunnerService_' PKG=apprunner ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/apprunner/... -v -count 1 -parallel 3  -run=TestAccAppRunnerService_ -timeout 180m
=== RUN   TestAccAppRunnerService_ImageRepository_basic
=== PAUSE TestAccAppRunnerService_ImageRepository_basic
=== RUN   TestAccAppRunnerService_ImageRepository_autoScaling
=== PAUSE TestAccAppRunnerService_ImageRepository_autoScaling
=== RUN   TestAccAppRunnerService_ImageRepository_encryption
=== PAUSE TestAccAppRunnerService_ImageRepository_encryption
=== RUN   TestAccAppRunnerService_ImageRepository_healthCheck
=== PAUSE TestAccAppRunnerService_ImageRepository_healthCheck
=== RUN   TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
=== RUN   TestAccAppRunnerService_ImageRepository_instance_Update
=== PAUSE TestAccAppRunnerService_ImageRepository_instance_Update
=== RUN   TestAccAppRunnerService_ImageRepository_networkConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_networkConfiguration
=== RUN   TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== PAUSE TestAccAppRunnerService_ImageRepository_observabilityConfiguration
=== RUN   TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== PAUSE TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
=== RUN   TestAccAppRunnerService_disappears
=== PAUSE TestAccAppRunnerService_disappears
=== RUN   TestAccAppRunnerService_tags
=== PAUSE TestAccAppRunnerService_tags
=== CONT  TestAccAppRunnerService_ImageRepository_basic
=== CONT  TestAccAppRunnerService_ImageRepository_networkConfiguration
=== CONT  TestAccAppRunnerService_ImageRepository_healthCheck
--- PASS: TestAccAppRunnerService_ImageRepository_basic (301.50s)
=== CONT  TestAccAppRunnerService_ImageRepository_encryption
--- PASS: TestAccAppRunnerService_ImageRepository_networkConfiguration (463.24s)
=== CONT  TestAccAppRunnerService_ImageRepository_autoScaling
--- PASS: TestAccAppRunnerService_ImageRepository_healthCheck (556.06s)
=== CONT  TestAccAppRunnerService_disappears
--- PASS: TestAccAppRunnerService_disappears (254.38s)
=== CONT  TestAccAppRunnerService_tags
--- PASS: TestAccAppRunnerService_ImageRepository_encryption (550.76s)
=== CONT  TestAccAppRunnerService_ImageRepository_instance_Update
--- PASS: TestAccAppRunnerService_ImageRepository_autoScaling (434.83s)
=== CONT  TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars
--- PASS: TestAccAppRunnerService_tags (307.85s)
=== CONT  TestAccAppRunnerService_ImageRepository_observabilityConfiguration
--- PASS: TestAccAppRunnerService_ImageRepository_runtimeEnvironmentVars (266.34s)
=== CONT  TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole
--- PASS: TestAccAppRunnerService_ImageRepository_instance_Update (458.98s)
--- PASS: TestAccAppRunnerService_ImageRepository_instance_NoInstanceRole (265.44s)
--- PASS: TestAccAppRunnerService_ImageRepository_observabilityConfiguration (640.98s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/apprunner	1767.321s

@ewbankkit
Copy link
Contributor

@bennylu2 Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 86bf014 into hashicorp:main Jan 10, 2023
@github-actions github-actions bot added this to the v4.50.0 milestone Jan 10, 2023
@github-actions
Copy link

This functionality has been released in v4.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/apprunner Issues and PRs that pertain to the apprunner service. size/S Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App Runner Observability catch-22
3 participants