-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_evidently_launch #28752
r/aws_evidently_launch #28752
Conversation
Community NoteVoting for Prioritization
For Submitters
|
add `Context` param to `acctest.CheckResourceDisappears`
7c935e3
to
5f0ede3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small nitpick
also, i believe internal markdown links should be proper URLs to work better with the registry although im not 100% sure on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
$ make testacc TESTARGS='-run=TestAccEvidentlyLaunch' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20 -run=TestAccEvidentlyLaunch -timeout 180m
=== RUN TestAccEvidentlyLaunch_basic
=== PAUSE TestAccEvidentlyLaunch_basic
=== RUN TestAccEvidentlyLaunch_updateDescription
=== PAUSE TestAccEvidentlyLaunch_updateDescription
=== RUN TestAccEvidentlyLaunch_updateGroups
=== PAUSE TestAccEvidentlyLaunch_updateGroups
=== RUN TestAccEvidentlyLaunch_updateMetricMonitors
=== PAUSE TestAccEvidentlyLaunch_updateMetricMonitors
=== RUN TestAccEvidentlyLaunch_updateRandomizationSalt
=== PAUSE TestAccEvidentlyLaunch_updateRandomizationSalt
=== RUN TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== PAUSE TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== RUN TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== PAUSE TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== RUN TestAccEvidentlyLaunch_tags
=== PAUSE TestAccEvidentlyLaunch_tags
=== RUN TestAccEvidentlyLaunch_disappears
=== PAUSE TestAccEvidentlyLaunch_disappears
=== CONT TestAccEvidentlyLaunch_basic
=== CONT TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== CONT TestAccEvidentlyLaunch_tags
=== CONT TestAccEvidentlyLaunch_updateMetricMonitors
=== CONT TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== CONT TestAccEvidentlyLaunch_updateGroups
=== CONT TestAccEvidentlyLaunch_disappears
=== CONT TestAccEvidentlyLaunch_updateRandomizationSalt
=== CONT TestAccEvidentlyLaunch_updateDescription
--- PASS: TestAccEvidentlyLaunch_disappears (22.81s)
--- PASS: TestAccEvidentlyLaunch_basic (26.40s)
--- PASS: TestAccEvidentlyLaunch_updateDescription (33.86s)
--- PASS: TestAccEvidentlyLaunch_updateRandomizationSalt (33.88s)
--- PASS: TestAccEvidentlyLaunch_tags (45.76s)
--- PASS: TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps (53.44s)
--- PASS: TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides (54.54s)
--- PASS: TestAccEvidentlyLaunch_updateMetricMonitors (54.99s)
--- PASS: TestAccEvidentlyLaunch_updateGroups (58.32s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/evidently 61.462s
This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
aws_evidently_launch
resourceRelations
Relates #22624
References
Output from Acceptance Testing