Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_evidently_launch #28752

Merged
merged 24 commits into from
Feb 8, 2023
Merged

r/aws_evidently_launch #28752

merged 24 commits into from
Feb 8, 2023

Conversation

GlennChia
Copy link
Collaborator

Description

aws_evidently_launch resource

Relations

Relates #22624

References

Output from Acceptance Testing

$ make testacc TESTARGS='-run=TestAccEvidentlyLaunch' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyLaunch -timeout 180m
=== RUN   TestAccEvidentlyLaunch_basic
=== PAUSE TestAccEvidentlyLaunch_basic
=== RUN   TestAccEvidentlyLaunch_updateDescription
=== PAUSE TestAccEvidentlyLaunch_updateDescription
=== RUN   TestAccEvidentlyLaunch_updateGroups
=== PAUSE TestAccEvidentlyLaunch_updateGroups
=== RUN   TestAccEvidentlyLaunch_updateMetricMonitors
=== PAUSE TestAccEvidentlyLaunch_updateMetricMonitors
=== RUN   TestAccEvidentlyLaunch_updateRandomizationSalt
=== PAUSE TestAccEvidentlyLaunch_updateRandomizationSalt
=== RUN   TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== PAUSE TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== RUN   TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== PAUSE TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== RUN   TestAccEvidentlyLaunch_tags
=== PAUSE TestAccEvidentlyLaunch_tags
=== RUN   TestAccEvidentlyLaunch_disappears
=== PAUSE TestAccEvidentlyLaunch_disappears
=== CONT  TestAccEvidentlyLaunch_basic
=== CONT  TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== CONT  TestAccEvidentlyLaunch_disappears
=== CONT  TestAccEvidentlyLaunch_updateGroups
=== CONT  TestAccEvidentlyLaunch_tags
=== CONT  TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== CONT  TestAccEvidentlyLaunch_updateRandomizationSalt
=== CONT  TestAccEvidentlyLaunch_updateMetricMonitors
=== CONT  TestAccEvidentlyLaunch_updateDescription
--- PASS: TestAccEvidentlyLaunch_disappears (29.87s)
--- PASS: TestAccEvidentlyLaunch_basic (33.36s)
--- PASS: TestAccEvidentlyLaunch_updateDescription (50.54s)
--- PASS: TestAccEvidentlyLaunch_updateRandomizationSalt (51.83s)
--- PASS: TestAccEvidentlyLaunch_tags (65.68s)
--- PASS: TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps (83.80s)
--- PASS: TestAccEvidentlyLaunch_updateMetricMonitors (85.43s)
--- PASS: TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides (85.67s)
--- PASS: TestAccEvidentlyLaunch_updateGroups (86.47s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  86.585s

...

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. flex Pertains to FLatteners and EXpanders. provider Pertains to the provider itself, rather than any interaction with AWS. service/evidently Issues and PRs that pertain to the evidently service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 7, 2023
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 13, 2023
@GlennChia GlennChia force-pushed the f-aws_evidently_launch branch from 7c935e3 to 5f0ede3 Compare January 21, 2023 01:37
Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small nitpick

also, i believe internal markdown links should be proper URLs to work better with the registry although im not 100% sure on that

website/docs/r/evidently_launch.html.markdown Show resolved Hide resolved
website/docs/r/evidently_launch.html.markdown Show resolved Hide resolved
website/docs/r/evidently_launch.html.markdown Show resolved Hide resolved
website/docs/r/evidently_launch.html.markdown Show resolved Hide resolved
website/docs/r/evidently_launch.html.markdown Show resolved Hide resolved
website/docs/r/evidently_launch.html.markdown Show resolved Hide resolved
website/docs/r/evidently_launch.html.markdown Outdated Show resolved Hide resolved
Copy link
Collaborator

@drewmullen drewmullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

$ make testacc TESTARGS='-run=TestAccEvidentlyLaunch' PKG=evidently
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/evidently/... -v -count 1 -parallel 20  -run=TestAccEvidentlyLaunch -timeout 180m
=== RUN   TestAccEvidentlyLaunch_basic
=== PAUSE TestAccEvidentlyLaunch_basic
=== RUN   TestAccEvidentlyLaunch_updateDescription
=== PAUSE TestAccEvidentlyLaunch_updateDescription
=== RUN   TestAccEvidentlyLaunch_updateGroups
=== PAUSE TestAccEvidentlyLaunch_updateGroups
=== RUN   TestAccEvidentlyLaunch_updateMetricMonitors
=== PAUSE TestAccEvidentlyLaunch_updateMetricMonitors
=== RUN   TestAccEvidentlyLaunch_updateRandomizationSalt
=== PAUSE TestAccEvidentlyLaunch_updateRandomizationSalt
=== RUN   TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== PAUSE TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== RUN   TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== PAUSE TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== RUN   TestAccEvidentlyLaunch_tags
=== PAUSE TestAccEvidentlyLaunch_tags
=== RUN   TestAccEvidentlyLaunch_disappears
=== PAUSE TestAccEvidentlyLaunch_disappears
=== CONT  TestAccEvidentlyLaunch_basic
=== CONT  TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps
=== CONT  TestAccEvidentlyLaunch_tags
=== CONT  TestAccEvidentlyLaunch_updateMetricMonitors
=== CONT  TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides
=== CONT  TestAccEvidentlyLaunch_updateGroups
=== CONT  TestAccEvidentlyLaunch_disappears
=== CONT  TestAccEvidentlyLaunch_updateRandomizationSalt
=== CONT  TestAccEvidentlyLaunch_updateDescription
--- PASS: TestAccEvidentlyLaunch_disappears (22.81s)
--- PASS: TestAccEvidentlyLaunch_basic (26.40s)
--- PASS: TestAccEvidentlyLaunch_updateDescription (33.86s)
--- PASS: TestAccEvidentlyLaunch_updateRandomizationSalt (33.88s)
--- PASS: TestAccEvidentlyLaunch_tags (45.76s)
--- PASS: TestAccEvidentlyLaunch_scheduledSplitsConfig_updateSteps (53.44s)
--- PASS: TestAccEvidentlyLaunch_scheduledSplitsConfig_steps_updateSegmentOverrides (54.54s)
--- PASS: TestAccEvidentlyLaunch_updateMetricMonitors (54.99s)
--- PASS: TestAccEvidentlyLaunch_updateGroups (58.32s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/evidently  61.462s

@jar-b jar-b merged commit 00c362c into hashicorp:main Feb 8, 2023
@github-actions github-actions bot added this to the v4.54.0 milestone Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This functionality has been released in v4.54.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
@justinretzolk justinretzolk added the partner Contribution from a partner. label May 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. flex Pertains to FLatteners and EXpanders. new-resource Introduces a new resource. partner Contribution from a partner. provider Pertains to the provider itself, rather than any interaction with AWS. service/evidently Issues and PRs that pertain to the evidently service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants