Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws_opensearchserverless_security_config resource #28776

Conversation

mattburgess
Copy link
Collaborator

Description

Adds support for OpenSearch Serverless Security Config resources.

Relations

Closes #28465

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccOpenSearchServerlessSecurityConfig_ PKG=opensearchserverless
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessSecurityConfig_'  -timeout 180m
=== RUN   TestAccOpenSearchServerlessSecurityConfig_basic
=== PAUSE TestAccOpenSearchServerlessSecurityConfig_basic
=== RUN   TestAccOpenSearchServerlessSecurityConfig_disappears
=== PAUSE TestAccOpenSearchServerlessSecurityConfig_disappears
=== CONT  TestAccOpenSearchServerlessSecurityConfig_basic
=== CONT  TestAccOpenSearchServerlessSecurityConfig_disappears
--- PASS: TestAccOpenSearchServerlessSecurityConfig_disappears (10.51s)
--- PASS: TestAccOpenSearchServerlessSecurityConfig_basic (13.83s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	13.925s

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 9, 2023
@mattburgess mattburgess force-pushed the opensearchserverless-security-config-resource branch from cfc88c7 to c1e6787 Compare January 9, 2023 22:53
@justinretzolk justinretzolk added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 9, 2023
@mattburgess mattburgess force-pushed the opensearchserverless-security-config-resource branch 2 times, most recently from b472fc7 to fd6bc41 Compare January 9, 2023 23:37
@mattburgess mattburgess force-pushed the opensearchserverless-security-config-resource branch from fd6bc41 to f5120a0 Compare March 26, 2023 15:27
@github-actions github-actions bot removed the provider Pertains to the provider itself, rather than any interaction with AWS. label Mar 26, 2023
@github-actions github-actions bot added generators Relates to code generators. and removed generators Relates to code generators. labels Mar 27, 2023
@mattburgess mattburgess force-pushed the opensearchserverless-security-config-resource branch from 2e783b0 to 8b220ef Compare March 28, 2023 20:33
@mattburgess mattburgess force-pushed the opensearchserverless-security-config-resource branch from 8b220ef to 8d00664 Compare March 28, 2023 20:45
@AdamTylerLynch AdamTylerLynch self-requested a review April 4, 2023 20:05
@johnsonaj johnsonaj self-assigned this Jun 15, 2023
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

$ make testacc TESTS=TestAccOpenSearchServerlessSecurityConfig_ PKG=opensearchserverless

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/opensearchserverless/... -v -count 1 -parallel 20 -run='TestAccOpenSearchServerlessSecurityConfig_'  -timeout 180m
--- PASS: TestAccOpenSearchServerlessSecurityConfig_disappears (15.43s)
--- PASS: TestAccOpenSearchServerlessSecurityConfig_basic (21.02s)
--- PASS: TestAccOpenSearchServerlessSecurityConfig_update (30.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/opensearchserverless	34.519s

@github-actions github-actions bot added the sweeper Pertains to changes to or issues with the sweeper. label Jun 15, 2023
@johnsonaj
Copy link
Contributor

@mattburgess thanks for the contribution! 🎉

@johnsonaj johnsonaj merged commit da1efa0 into hashicorp:main Jun 15, 2023
@github-actions github-actions bot added this to the v5.4.0 milestone Jun 15, 2023
@github-actions
Copy link

This functionality has been released in v5.4.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-resource Introduces a new resource. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. size/XL Managed by automation to categorize the size of a PR. sweeper Pertains to changes to or issues with the sweeper. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Resource]: OpenSearch Serverless Security Config
4 participants