Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous nil checks before d.Set() #28902

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Remove extraneous nil checks before d.Set() #28902

merged 4 commits into from
Jan 17, 2023

Conversation

mattburgess
Copy link
Collaborator

Description

  • fix semgrep rule to scan the correct directory
  • fix semgrep invocation to avoid deprecation warning
  • fix or ignore new semgrep check

Relations

Closes #15893

References

Output from Acceptance Testing

$ make testacc TESTS=TestAccXXX PKG=ec2

...

@mattburgess
Remove extraneous nil checks before d.Set()
2e0ed3d 
* fix semgrep rule to scan the correct directory
* fix semgrep invocation to avoid deprecation warning
* fix or ignore new semgrep check
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticache Issues and PRs that pertain to the elasticache service. service/fsx Issues and PRs that pertain to the fsx service. service/grafana Issues and PRs that pertain to the grafana service. service/ipam Issues and PRs that pertain to the ipam service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/opsworks Issues and PRs that pertain to the opsworks service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/shield Issues and PRs that pertain to the shield service. and removed service/ec2 Issues and PRs that pertain to the ec2 service. service/s3 Issues and PRs that pertain to the s3 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/rds Issues and PRs that pertain to the rds service. service/directconnect Issues and PRs that pertain to the directconnect service. service/opsworks Issues and PRs that pertain to the opsworks service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/shield Issues and PRs that pertain to the shield service. service/elasticache Issues and PRs that pertain to the elasticache service. service/lexmodels Issues and PRs that pertain to the lexmodels service. labels Jan 14, 2023
@github-actions github-actions bot removed service/ipam Issues and PRs that pertain to the ipam service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. labels Jan 14, 2023
@ewbankkit ewbankkit added technical-debt Addresses areas of the codebase that need refactoring or redesign. linter Pertains to changes to or issues with the various linters. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 14, 2023
@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticache Issues and PRs that pertain to the elasticache service. service/fsx Issues and PRs that pertain to the fsx service. service/grafana Issues and PRs that pertain to the grafana service. service/ipam Issues and PRs that pertain to the ipam service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/opsworks Issues and PRs that pertain to the opsworks service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/shield Issues and PRs that pertain to the shield service. and removed linter Pertains to changes to or issues with the various linters. labels Jan 16, 2023
ewbankkit
ewbankkit approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAutoScalingSchedule_basic' PKG=autoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/autoscaling/... -v -count 1 -parallel 3  -run=TestAccAutoScalingSchedule_basic -timeout 180m
=== RUN   TestAccAutoScalingSchedule_basic
=== PAUSE TestAccAutoScalingSchedule_basic
=== CONT  TestAccAutoScalingSchedule_basic
--- PASS: TestAccAutoScalingSchedule_basic (201.51s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling	206.820s
% make testacc TESTARGS='-run=TestAccEC2SpotFleetRequest_basic' PKG=ec2 ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 3  -run=TestAccEC2SpotFleetRequest_basic -timeout 180m
=== RUN   TestAccEC2SpotFleetRequest_basic
=== PAUSE TestAccEC2SpotFleetRequest_basic
=== CONT  TestAccEC2SpotFleetRequest_basic
--- PASS: TestAccEC2SpotFleetRequest_basic (140.41s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	145.664s

@ewbankkit
Copy link
Contributor

@mattburgess Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 5f041ec into hashicorp:main Jan 17, 2023
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 17, 2023
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/apigateway Issues and PRs that pertain to the apigateway service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ec2 Issues and PRs that pertain to the ec2 service. service/elasticache Issues and PRs that pertain to the elasticache service. service/fsx Issues and PRs that pertain to the fsx service. service/grafana Issues and PRs that pertain to the grafana service. service/ipam Issues and PRs that pertain to the ipam service. service/lexmodels Issues and PRs that pertain to the lexmodels service. service/opsworks Issues and PRs that pertain to the opsworks service. service/rds Issues and PRs that pertain to the rds service. service/s3 Issues and PRs that pertain to the s3 service. service/shield Issues and PRs that pertain to the shield service. size/L Managed by automation to categorize the size of a PR. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Milestone
v4.51.0
Development

Successfully merging this pull request may close these issues.

provider: Remove extraneous nil checks before d.Set()
2 participants
@mattburgess @ewbankkit