Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/aws_lambda_function: Remove any qualifier from invoke_arn #28963

Merged
merged 15 commits into from
Jan 19, 2023
Merged

d/aws_lambda_function: Remove any qualifier from invoke_arn #28963

merged 15 commits into from
Jan 19, 2023

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jan 18, 2023 •
edited
Loading

Description

Removes any qualifier when constructing invoke_arn.

Relations

Closes #26619.
Closes #23622.
Closes #25440.
Closes #18661.
Closes #25886.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccLambdaFunction_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunction_ -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_disappears
=== PAUSE TestAccLambdaFunction_disappears
=== RUN   TestAccLambdaFunction_tags
=== PAUSE TestAccLambdaFunction_tags
=== RUN   TestAccLambdaFunction_unpublishedCodeUpdate
=== PAUSE TestAccLambdaFunction_unpublishedCodeUpdate
=== RUN   TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== RUN   TestAccLambdaFunction_concurrency
=== PAUSE TestAccLambdaFunction_concurrency
=== RUN   TestAccLambdaFunction_concurrencyCycle
=== PAUSE TestAccLambdaFunction_concurrencyCycle
=== RUN   TestAccLambdaFunction_expectFilenameAndS3Attributes
=== PAUSE TestAccLambdaFunction_expectFilenameAndS3Attributes
=== RUN   TestAccLambdaFunction_envVariables
=== PAUSE TestAccLambdaFunction_envVariables
=== RUN   TestAccLambdaFunction_EnvironmentVariables_noValue
=== PAUSE TestAccLambdaFunction_EnvironmentVariables_noValue
=== RUN   TestAccLambdaFunction_encryptedEnvVariables
=== PAUSE TestAccLambdaFunction_encryptedEnvVariables
=== RUN   TestAccLambdaFunction_nameValidation
=== PAUSE TestAccLambdaFunction_nameValidation
=== RUN   TestAccLambdaFunction_versioned
=== PAUSE TestAccLambdaFunction_versioned
=== RUN   TestAccLambdaFunction_versionedUpdate
=== PAUSE TestAccLambdaFunction_versionedUpdate
=== RUN   TestAccLambdaFunction_enablePublish
=== PAUSE TestAccLambdaFunction_enablePublish
=== RUN   TestAccLambdaFunction_disablePublish
=== PAUSE TestAccLambdaFunction_disablePublish
=== RUN   TestAccLambdaFunction_deadLetter
=== PAUSE TestAccLambdaFunction_deadLetter
=== RUN   TestAccLambdaFunction_deadLetterUpdated
=== PAUSE TestAccLambdaFunction_deadLetterUpdated
=== RUN   TestAccLambdaFunction_nilDeadLetter
=== PAUSE TestAccLambdaFunction_nilDeadLetter
=== RUN   TestAccLambdaFunction_fileSystem
=== PAUSE TestAccLambdaFunction_fileSystem
=== RUN   TestAccLambdaFunction_image
    function_test.go:901: Environment variable AWS_LAMBDA_IMAGE_LATEST_ID is not set
--- SKIP: TestAccLambdaFunction_image (0.00s)
=== RUN   TestAccLambdaFunction_architectures
=== PAUSE TestAccLambdaFunction_architectures
=== RUN   TestAccLambdaFunction_architecturesUpdate
=== PAUSE TestAccLambdaFunction_architecturesUpdate
=== RUN   TestAccLambdaFunction_architecturesWithLayer
=== PAUSE TestAccLambdaFunction_architecturesWithLayer
=== RUN   TestAccLambdaFunction_ephemeralStorage
=== PAUSE TestAccLambdaFunction_ephemeralStorage
=== RUN   TestAccLambdaFunction_tracing
=== PAUSE TestAccLambdaFunction_tracing
=== RUN   TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== PAUSE TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== RUN   TestAccLambdaFunction_layers
=== PAUSE TestAccLambdaFunction_layers
=== RUN   TestAccLambdaFunction_layersUpdate
=== PAUSE TestAccLambdaFunction_layersUpdate
=== RUN   TestAccLambdaFunction_vpc
=== PAUSE TestAccLambdaFunction_vpc
=== RUN   TestAccLambdaFunction_vpcRemoval
=== PAUSE TestAccLambdaFunction_vpcRemoval
=== RUN   TestAccLambdaFunction_vpcUpdate
=== PAUSE TestAccLambdaFunction_vpcUpdate
=== RUN   TestAccLambdaFunction_VPC_withInvocation
=== PAUSE TestAccLambdaFunction_VPC_withInvocation
=== RUN   TestAccLambdaFunction_VPCPublishNo_changes
=== PAUSE TestAccLambdaFunction_VPCPublishNo_changes
=== RUN   TestAccLambdaFunction_VPCPublishHas_changes
=== PAUSE TestAccLambdaFunction_VPCPublishHas_changes
=== RUN   TestAccLambdaFunction_VPC_properIAMDependencies
=== PAUSE TestAccLambdaFunction_VPC_properIAMDependencies
=== RUN   TestAccLambdaFunction_emptyVPC
=== PAUSE TestAccLambdaFunction_emptyVPC
=== RUN   TestAccLambdaFunction_s3
=== PAUSE TestAccLambdaFunction_s3
=== RUN   TestAccLambdaFunction_localUpdate
=== PAUSE TestAccLambdaFunction_localUpdate
=== RUN   TestAccLambdaFunction_LocalUpdate_nameOnly
=== PAUSE TestAccLambdaFunction_LocalUpdate_nameOnly
=== RUN   TestAccLambdaFunction_S3Update_basic
=== PAUSE TestAccLambdaFunction_S3Update_basic
=== RUN   TestAccLambdaFunction_S3Update_unversioned
=== PAUSE TestAccLambdaFunction_S3Update_unversioned
=== RUN   TestAccLambdaFunction_snapStart
=== PAUSE TestAccLambdaFunction_snapStart
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== RUN   TestAccLambdaFunction_Zip_validation
=== PAUSE TestAccLambdaFunction_Zip_validation
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_architecturesWithLayer
=== CONT  TestAccLambdaFunction_nameValidation
--- PASS: TestAccLambdaFunction_nameValidation (2.98s)
=== CONT  TestAccLambdaFunction_architecturesUpdate
--- PASS: TestAccLambdaFunction_basic (46.57s)
=== CONT  TestAccLambdaFunction_architectures
--- PASS: TestAccLambdaFunction_architecturesWithLayer (88.08s)
=== CONT  TestAccLambdaFunction_fileSystem
--- PASS: TestAccLambdaFunction_architecturesUpdate (91.43s)
=== CONT  TestAccLambdaFunction_nilDeadLetter
--- PASS: TestAccLambdaFunction_architectures (52.26s)
=== CONT  TestAccLambdaFunction_deadLetterUpdated
--- PASS: TestAccLambdaFunction_nilDeadLetter (14.96s)
=== CONT  TestAccLambdaFunction_deadLetter
--- PASS: TestAccLambdaFunction_deadLetterUpdated (56.43s)
=== CONT  TestAccLambdaFunction_disablePublish
--- PASS: TestAccLambdaFunction_deadLetter (60.62s)
=== CONT  TestAccLambdaFunction_enablePublish
--- PASS: TestAccLambdaFunction_disablePublish (60.65s)
=== CONT  TestAccLambdaFunction_versionedUpdate
--- PASS: TestAccLambdaFunction_enablePublish (74.59s)
=== CONT  TestAccLambdaFunction_versioned
--- PASS: TestAccLambdaFunction_versioned (162.61s)
=== CONT  TestAccLambdaFunction_VPCPublishHas_changes
--- PASS: TestAccLambdaFunction_versionedUpdate (233.28s)
=== CONT  TestAccLambdaFunction_Zip_validation
--- PASS: TestAccLambdaFunction_Zip_validation (4.88s)
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_fileSystem (674.35s)
=== CONT  TestAccLambdaFunction_snapStart
--- PASS: TestAccLambdaFunction_snapStart (70.94s)
=== CONT  TestAccLambdaFunction_S3Update_unversioned
--- PASS: TestAccLambdaFunction_S3Update_unversioned (67.12s)
=== CONT  TestAccLambdaFunction_S3Update_basic
--- PASS: TestAccLambdaFunction_S3Update_basic (74.43s)
=== CONT  TestAccLambdaFunction_LocalUpdate_nameOnly
--- PASS: TestAccLambdaFunction_runtimes (539.16s)
=== CONT  TestAccLambdaFunction_localUpdate
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (65.97s)
=== CONT  TestAccLambdaFunction_s3
--- PASS: TestAccLambdaFunction_localUpdate (62.07s)
=== CONT  TestAccLambdaFunction_emptyVPC
--- PASS: TestAccLambdaFunction_s3 (40.35s)
=== CONT  TestAccLambdaFunction_VPC_properIAMDependencies
--- PASS: TestAccLambdaFunction_emptyVPC (47.71s)
=== CONT  TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
--- PASS: TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables (210.38s)
=== CONT  TestAccLambdaFunction_layersUpdate
--- PASS: TestAccLambdaFunction_VPC_properIAMDependencies (242.82s)
=== CONT  TestAccLambdaFunction_layers
--- PASS: TestAccLambdaFunction_layers (38.90s)
=== CONT  TestAccLambdaFunction_VPC_withInvocation
--- PASS: TestAccLambdaFunction_layersUpdate (66.10s)
=== CONT  TestAccLambdaFunction_VPCPublishNo_changes
--- PASS: TestAccLambdaFunction_VPC_withInvocation (571.48s)
=== CONT  TestAccLambdaFunction_concurrencyCycle
--- PASS: TestAccLambdaFunction_VPCPublishHas_changes (1550.79s)
=== CONT  TestAccLambdaFunction_encryptedEnvVariables
--- PASS: TestAccLambdaFunction_concurrencyCycle (70.85s)
=== CONT  TestAccLambdaFunction_EnvironmentVariables_noValue
--- PASS: TestAccLambdaFunction_encryptedEnvVariables (79.65s)
=== CONT  TestAccLambdaFunction_envVariables
--- PASS: TestAccLambdaFunction_EnvironmentVariables_noValue (34.55s)
=== CONT  TestAccLambdaFunction_expectFilenameAndS3Attributes
--- PASS: TestAccLambdaFunction_expectFilenameAndS3Attributes (1.26s)
=== CONT  TestAccLambdaFunction_vpcUpdate
--- PASS: TestAccLambdaFunction_envVariables (100.49s)
=== CONT  TestAccLambdaFunction_unpublishedCodeUpdate
--- PASS: TestAccLambdaFunction_unpublishedCodeUpdate (158.78s)
=== CONT  TestAccLambdaFunction_concurrency
--- PASS: TestAccLambdaFunction_concurrency (55.92s)
=== CONT  TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_codeSigning (65.77s)
=== CONT  TestAccLambdaFunction_vpcRemoval
--- PASS: TestAccLambdaFunction_vpcRemoval (253.59s)
=== CONT  TestAccLambdaFunction_tracing
--- PASS: TestAccLambdaFunction_tracing (53.04s)
=== CONT  TestAccLambdaFunction_tags
--- PASS: TestAccLambdaFunction_tags (70.99s)
=== CONT  TestAccLambdaFunction_disappears
--- PASS: TestAccLambdaFunction_vpcUpdate (788.10s)
=== CONT  TestAccLambdaFunction_ephemeralStorage
--- PASS: TestAccLambdaFunction_disappears (39.80s)
=== CONT  TestAccLambdaFunction_vpc        
--- PASS: TestAccLambdaFunction_ephemeralStorage (53.01s)
--- PASS: TestAccLambdaFunction_vpc (247.76s)
--- PASS: TestAccLambdaFunction_VPCPublishNo_changes (1686.26s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	3071.447s
% make testacc TESTARGS='-run=TestAccLambdaFunctionDataSource_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunctionDataSource_ -timeout 180m
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionDataSource_version
=== PAUSE TestAccLambdaFunctionDataSource_version
=== RUN   TestAccLambdaFunctionDataSource_latestVersion
=== PAUSE TestAccLambdaFunctionDataSource_latestVersion
=== RUN   TestAccLambdaFunctionDataSource_unpublishedVersion
=== PAUSE TestAccLambdaFunctionDataSource_unpublishedVersion
=== RUN   TestAccLambdaFunctionDataSource_alias
=== PAUSE TestAccLambdaFunctionDataSource_alias
=== RUN   TestAccLambdaFunctionDataSource_layers
=== PAUSE TestAccLambdaFunctionDataSource_layers
=== RUN   TestAccLambdaFunctionDataSource_vpc
=== PAUSE TestAccLambdaFunctionDataSource_vpc
=== RUN   TestAccLambdaFunctionDataSource_environment
=== PAUSE TestAccLambdaFunctionDataSource_environment
=== RUN   TestAccLambdaFunctionDataSource_fileSystem
=== PAUSE TestAccLambdaFunctionDataSource_fileSystem
=== RUN   TestAccLambdaFunctionDataSource_image
=== PAUSE TestAccLambdaFunctionDataSource_image
=== RUN   TestAccLambdaFunctionDataSource_architectures
=== PAUSE TestAccLambdaFunctionDataSource_architectures
=== RUN   TestAccLambdaFunctionDataSource_ephemeralStorage
=== PAUSE TestAccLambdaFunctionDataSource_ephemeralStorage
=== CONT  TestAccLambdaFunctionDataSource_basic
=== CONT  TestAccLambdaFunctionDataSource_vpc
=== CONT  TestAccLambdaFunctionDataSource_unpublishedVersion
--- PASS: TestAccLambdaFunctionDataSource_basic (39.77s)
=== CONT  TestAccLambdaFunctionDataSource_latestVersion
--- PASS: TestAccLambdaFunctionDataSource_unpublishedVersion (45.67s)
=== CONT  TestAccLambdaFunctionDataSource_image
    function_data_source_test.go:325: AWS_LAMBDA_IMAGE_LATEST_ID env var must be set for Lambda Function Data Source Image Support acceptance tests.
--- SKIP: TestAccLambdaFunctionDataSource_image (0.00s)
=== CONT  TestAccLambdaFunctionDataSource_ephemeralStorage
--- PASS: TestAccLambdaFunctionDataSource_latestVersion (32.02s)
=== CONT  TestAccLambdaFunctionDataSource_architectures
--- PASS: TestAccLambdaFunctionDataSource_ephemeralStorage (203.63s)
=== CONT  TestAccLambdaFunctionDataSource_version
--- PASS: TestAccLambdaFunctionDataSource_vpc (261.02s)
=== CONT  TestAccLambdaFunctionDataSource_fileSystem
--- PASS: TestAccLambdaFunctionDataSource_architectures (29.74s)
=== CONT  TestAccLambdaFunctionDataSource_layers
--- PASS: TestAccLambdaFunctionDataSource_version (37.62s)
=== CONT  TestAccLambdaFunctionDataSource_environment
--- PASS: TestAccLambdaFunctionDataSource_layers (33.72s)
=== CONT  TestAccLambdaFunctionDataSource_alias
--- PASS: TestAccLambdaFunctionDataSource_environment (33.43s)
--- PASS: TestAccLambdaFunctionDataSource_alias (29.16s)
--- PASS: TestAccLambdaFunctionDataSource_fileSystem (1567.72s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	1833.901s

@ewbankkit
r/aws_lambda_function: Tidy up resource Read.
8a853f5 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccLambdaFunction_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunction_ -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_disappears
=== PAUSE TestAccLambdaFunction_disappears
=== RUN   TestAccLambdaFunction_tags
=== PAUSE TestAccLambdaFunction_tags
=== RUN   TestAccLambdaFunction_unpublishedCodeUpdate
=== PAUSE TestAccLambdaFunction_unpublishedCodeUpdate
=== RUN   TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== RUN   TestAccLambdaFunction_concurrency
=== PAUSE TestAccLambdaFunction_concurrency
=== RUN   TestAccLambdaFunction_concurrencyCycle
=== PAUSE TestAccLambdaFunction_concurrencyCycle
=== RUN   TestAccLambdaFunction_expectFilenameAndS3Attributes
=== PAUSE TestAccLambdaFunction_expectFilenameAndS3Attributes
=== RUN   TestAccLambdaFunction_envVariables
=== PAUSE TestAccLambdaFunction_envVariables
=== RUN   TestAccLambdaFunction_EnvironmentVariables_noValue
=== PAUSE TestAccLambdaFunction_EnvironmentVariables_noValue
=== RUN   TestAccLambdaFunction_encryptedEnvVariables
=== PAUSE TestAccLambdaFunction_encryptedEnvVariables
=== RUN   TestAccLambdaFunction_nameValidation
=== PAUSE TestAccLambdaFunction_nameValidation
=== RUN   TestAccLambdaFunction_versioned
=== PAUSE TestAccLambdaFunction_versioned
=== RUN   TestAccLambdaFunction_versionedUpdate
=== PAUSE TestAccLambdaFunction_versionedUpdate
=== RUN   TestAccLambdaFunction_enablePublish
=== PAUSE TestAccLambdaFunction_enablePublish
=== RUN   TestAccLambdaFunction_disablePublish
=== PAUSE TestAccLambdaFunction_disablePublish
=== RUN   TestAccLambdaFunction_deadLetter
=== PAUSE TestAccLambdaFunction_deadLetter
=== RUN   TestAccLambdaFunction_deadLetterUpdated
=== PAUSE TestAccLambdaFunction_deadLetterUpdated
=== RUN   TestAccLambdaFunction_nilDeadLetter
=== PAUSE TestAccLambdaFunction_nilDeadLetter
=== RUN   TestAccLambdaFunction_fileSystem
=== PAUSE TestAccLambdaFunction_fileSystem
=== RUN   TestAccLambdaFunction_image
    function_test.go:901: Environment variable AWS_LAMBDA_IMAGE_LATEST_ID is not set
--- SKIP: TestAccLambdaFunction_image (0.00s)
=== RUN   TestAccLambdaFunction_architectures
=== PAUSE TestAccLambdaFunction_architectures
=== RUN   TestAccLambdaFunction_architecturesUpdate
=== PAUSE TestAccLambdaFunction_architecturesUpdate
=== RUN   TestAccLambdaFunction_architecturesWithLayer
=== PAUSE TestAccLambdaFunction_architecturesWithLayer
=== RUN   TestAccLambdaFunction_ephemeralStorage
=== PAUSE TestAccLambdaFunction_ephemeralStorage
=== RUN   TestAccLambdaFunction_tracing
=== PAUSE TestAccLambdaFunction_tracing
=== RUN   TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== PAUSE TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== RUN   TestAccLambdaFunction_layers
=== PAUSE TestAccLambdaFunction_layers
=== RUN   TestAccLambdaFunction_layersUpdate
=== PAUSE TestAccLambdaFunction_layersUpdate
=== RUN   TestAccLambdaFunction_vpc
=== PAUSE TestAccLambdaFunction_vpc
=== RUN   TestAccLambdaFunction_vpcRemoval
=== PAUSE TestAccLambdaFunction_vpcRemoval
=== RUN   TestAccLambdaFunction_vpcUpdate
=== PAUSE TestAccLambdaFunction_vpcUpdate
=== RUN   TestAccLambdaFunction_VPC_withInvocation
=== PAUSE TestAccLambdaFunction_VPC_withInvocation
=== RUN   TestAccLambdaFunction_VPCPublishNo_changes
=== PAUSE TestAccLambdaFunction_VPCPublishNo_changes
=== RUN   TestAccLambdaFunction_VPCPublishHas_changes
=== PAUSE TestAccLambdaFunction_VPCPublishHas_changes
=== RUN   TestAccLambdaFunction_VPC_properIAMDependencies
=== PAUSE TestAccLambdaFunction_VPC_properIAMDependencies
=== RUN   TestAccLambdaFunction_emptyVPC
=== PAUSE TestAccLambdaFunction_emptyVPC
=== RUN   TestAccLambdaFunction_s3
=== PAUSE TestAccLambdaFunction_s3
=== RUN   TestAccLambdaFunction_localUpdate
=== PAUSE TestAccLambdaFunction_localUpdate
=== RUN   TestAccLambdaFunction_LocalUpdate_nameOnly
=== PAUSE TestAccLambdaFunction_LocalUpdate_nameOnly
=== RUN   TestAccLambdaFunction_S3Update_basic
=== PAUSE TestAccLambdaFunction_S3Update_basic
=== RUN   TestAccLambdaFunction_S3Update_unversioned
=== PAUSE TestAccLambdaFunction_S3Update_unversioned
=== RUN   TestAccLambdaFunction_snapStart
=== PAUSE TestAccLambdaFunction_snapStart
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== RUN   TestAccLambdaFunction_Zip_validation
=== PAUSE TestAccLambdaFunction_Zip_validation
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_architecturesWithLayer
=== CONT  TestAccLambdaFunction_nameValidation
--- PASS: TestAccLambdaFunction_nameValidation (2.44s)
=== CONT  TestAccLambdaFunction_architecturesUpdate
--- PASS: TestAccLambdaFunction_basic (69.71s)
=== CONT  TestAccLambdaFunction_architectures
--- PASS: TestAccLambdaFunction_architecturesUpdate (138.92s)
=== CONT  TestAccLambdaFunction_fileSystem
--- PASS: TestAccLambdaFunction_architecturesWithLayer (151.45s)
=== CONT  TestAccLambdaFunction_nilDeadLetter
--- PASS: TestAccLambdaFunction_architectures (82.00s)
=== CONT  TestAccLambdaFunction_deadLetterUpdated
--- PASS: TestAccLambdaFunction_nilDeadLetter (14.39s)
=== CONT  TestAccLambdaFunction_deadLetter
--- PASS: TestAccLambdaFunction_deadLetterUpdated (107.31s)
=== CONT  TestAccLambdaFunction_disablePublish
--- PASS: TestAccLambdaFunction_deadLetter (103.17s)
=== CONT  TestAccLambdaFunction_enablePublish
--- PASS: TestAccLambdaFunction_disablePublish (227.25s)
=== CONT  TestAccLambdaFunction_versionedUpdate
--- PASS: TestAccLambdaFunction_enablePublish (236.13s)
=== CONT  TestAccLambdaFunction_versioned
--- PASS: TestAccLambdaFunction_versioned (33.01s)
=== CONT  TestAccLambdaFunction_concurrencyCycle
--- PASS: TestAccLambdaFunction_versionedUpdate (82.73s)
=== CONT  TestAccLambdaFunction_encryptedEnvVariables
--- PASS: TestAccLambdaFunction_concurrencyCycle (63.53s)
=== CONT  TestAccLambdaFunction_EnvironmentVariables_noValue
--- PASS: TestAccLambdaFunction_EnvironmentVariables_noValue (42.59s)
=== CONT  TestAccLambdaFunction_expectFilenameAndS3Attributes
--- PASS: TestAccLambdaFunction_encryptedEnvVariables (80.61s)
=== CONT  TestAccLambdaFunction_VPCPublishHas_changes
--- PASS: TestAccLambdaFunction_expectFilenameAndS3Attributes (14.33s)
=== CONT  TestAccLambdaFunction_Zip_validation
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_Zip_validation (3.89s)
--- PASS: TestAccLambdaFunction_fileSystem (877.50s)
=== CONT  TestAccLambdaFunction_snapStart
--- PASS: TestAccLambdaFunction_snapStart (61.76s)
=== CONT  TestAccLambdaFunction_S3Update_unversioned
--- PASS: TestAccLambdaFunction_S3Update_unversioned (56.36s)
=== CONT  TestAccLambdaFunction_S3Update_basic
--- PASS: TestAccLambdaFunction_runtimes (523.54s)
=== CONT  TestAccLambdaFunction_LocalUpdate_nameOnly
--- PASS: TestAccLambdaFunction_S3Update_basic (68.42s)
=== CONT  TestAccLambdaFunction_localUpdate
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (55.64s)
=== CONT  TestAccLambdaFunction_s3
--- PASS: TestAccLambdaFunction_localUpdate (50.28s)
=== CONT  TestAccLambdaFunction_emptyVPC
--- PASS: TestAccLambdaFunction_s3 (41.50s)
=== CONT  TestAccLambdaFunction_VPC_properIAMDependencies
--- PASS: TestAccLambdaFunction_emptyVPC (42.21s)
=== CONT  TestAccLambdaFunction_vpc
--- PASS: TestAccLambdaFunction_VPC_properIAMDependencies (239.85s)
=== CONT  TestAccLambdaFunction_VPCPublishNo_changes
--- PASS: TestAccLambdaFunction_vpc (563.48s)
=== CONT  TestAccLambdaFunction_VPC_withInvocation
--- PASS: TestAccLambdaFunction_VPCPublishNo_changes (371.06s)
=== CONT  TestAccLambdaFunction_vpcUpdate
=== CONT  TestAccLambdaFunction_VPC_withInvocation
--- PASS: TestAccLambdaFunction_VPC_withInvocation (1496.06s)
=== CONT  TestAccLambdaFunction_vpcRemoval
--- PASS: TestAccLambdaFunction_VPCPublishHas_changes (1545.23s)
=== CONT  TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
--- PASS: TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables (119.80s)
=== CONT  TestAccLambdaFunction_layersUpdate
--- PASS: TestAccLambdaFunction_vpcRemoval (441.81s)
=== CONT  TestAccLambdaFunction_layers
--- PASS: TestAccLambdaFunction_layersUpdate (58.55s)
=== CONT  TestAccLambdaFunction_unpublishedCodeUpdate
--- PASS: TestAccLambdaFunction_layers (35.67s)
=== CONT  TestAccLambdaFunction_concurrency
--- PASS: TestAccLambdaFunction_unpublishedCodeUpdate (62.59s)
=== CONT  TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_concurrency (52.64s)
=== CONT  TestAccLambdaFunction_tracing
--- PASS: TestAccLambdaFunction_codeSigning (58.92s)
=== CONT  TestAccLambdaFunction_tags
--- PASS: TestAccLambdaFunction_tracing (56.39s)
=== CONT  TestAccLambdaFunction_ephemeralStorage
--- PASS: TestAccLambdaFunction_vpcUpdate (638.28s)
=== CONT  TestAccLambdaFunction_disappears
--- PASS: TestAccLambdaFunction_ephemeralStorage (65.87s)
=== CONT  TestAccLambdaFunction_envVariables
--- PASS: TestAccLambdaFunction_tags (70.89s)
--- PASS: TestAccLambdaFunction_disappears (40.06s)
--- PASS: TestAccLambdaFunction_envVariables (102.88s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	2670.943s
@ewbankkit
d/aws_lambda_function: Tidy up Read.
1a5e317 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccLambdaFunctionDataSource_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunctionDataSource_ -timeout 180m
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionDataSource_version
=== PAUSE TestAccLambdaFunctionDataSource_version
=== RUN   TestAccLambdaFunctionDataSource_latestVersion
=== PAUSE TestAccLambdaFunctionDataSource_latestVersion
=== RUN   TestAccLambdaFunctionDataSource_unpublishedVersion
=== PAUSE TestAccLambdaFunctionDataSource_unpublishedVersion
=== RUN   TestAccLambdaFunctionDataSource_alias
=== PAUSE TestAccLambdaFunctionDataSource_alias
=== RUN   TestAccLambdaFunctionDataSource_layers
=== PAUSE TestAccLambdaFunctionDataSource_layers
=== RUN   TestAccLambdaFunctionDataSource_vpc
=== PAUSE TestAccLambdaFunctionDataSource_vpc
=== RUN   TestAccLambdaFunctionDataSource_environment
=== PAUSE TestAccLambdaFunctionDataSource_environment
=== RUN   TestAccLambdaFunctionDataSource_fileSystem
=== PAUSE TestAccLambdaFunctionDataSource_fileSystem
=== RUN   TestAccLambdaFunctionDataSource_image
=== PAUSE TestAccLambdaFunctionDataSource_image
=== RUN   TestAccLambdaFunctionDataSource_architectures
=== PAUSE TestAccLambdaFunctionDataSource_architectures
=== RUN   TestAccLambdaFunctionDataSource_ephemeralStorage
=== PAUSE TestAccLambdaFunctionDataSource_ephemeralStorage
=== CONT  TestAccLambdaFunctionDataSource_basic
=== CONT  TestAccLambdaFunctionDataSource_vpc
=== CONT  TestAccLambdaFunctionDataSource_unpublishedVersion
--- PASS: TestAccLambdaFunctionDataSource_basic (39.77s)
=== CONT  TestAccLambdaFunctionDataSource_latestVersion
--- PASS: TestAccLambdaFunctionDataSource_unpublishedVersion (45.67s)
=== CONT  TestAccLambdaFunctionDataSource_image
    function_data_source_test.go:325: AWS_LAMBDA_IMAGE_LATEST_ID env var must be set for Lambda Function Data Source Image Support acceptance tests.
--- SKIP: TestAccLambdaFunctionDataSource_image (0.00s)
=== CONT  TestAccLambdaFunctionDataSource_ephemeralStorage
=== CONT  TestAccLambdaFunctionDataSource_latestVersion
    function_data_source_test.go:92: Step 1/1 error: Check failed: 1 error occurred:
        	* Check 2/5 error: data.aws_lambda_function.test: Attribute 'invoke_arn' expected "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-4459761768906567804/invocations", got "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-4459761768906567804:1/invocations"

--- FAIL: TestAccLambdaFunctionDataSource_latestVersion (196.55s)
=== CONT  TestAccLambdaFunctionDataSource_architectures
--- PASS: TestAccLambdaFunctionDataSource_ephemeralStorage (203.63s)
=== CONT  TestAccLambdaFunctionDataSource_version
--- PASS: TestAccLambdaFunctionDataSource_vpc (261.02s)
=== CONT  TestAccLambdaFunctionDataSource_fileSystem
--- PASS: TestAccLambdaFunctionDataSource_architectures (29.74s)
=== CONT  TestAccLambdaFunctionDataSource_layers
=== CONT  TestAccLambdaFunctionDataSource_version
    function_data_source_test.go:67: Step 1/1 error: Check failed: 1 error occurred:
        	* Check 2/6 error: data.aws_lambda_function.test: Attribute 'invoke_arn' expected "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-7298917487192969324/invocations", got "arn:aws:apigateway:us-west-2:lambda:path/2015-03-31/functions/arn:aws:lambda:us-west-2:123456789012:function:tf-acc-test-7298917487192969324:1/invocations"

--- FAIL: TestAccLambdaFunctionDataSource_version (31.47s)
=== CONT  TestAccLambdaFunctionDataSource_environment
--- PASS: TestAccLambdaFunctionDataSource_layers (33.72s)
=== CONT  TestAccLambdaFunctionDataSource_alias
--- PASS: TestAccLambdaFunctionDataSource_environment (33.43s)
--- PASS: TestAccLambdaFunctionDataSource_alias (29.16s)
--- PASS: TestAccLambdaFunctionDataSource_fileSystem (1567.72s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	1833.901s
FAIL
make: *** [testacc] Error 1
@ewbankkit
d/aws_lambda_function: Calculate 'invoke_arn' from the unqualified fu…
b7d94a0 
…nction ARN.
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. service/lambda Issues and PRs that pertain to the lambda service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 18, 2023
@ewbankkit
Add CHANGELOG entry.
9f897eb
@ewbankkit
Fix semgrep 'ci.data-source-with-resource-read'.
b3bb6f2
@ewbankkit
Fix golangci-lint 'unparam'.
4e16d81
@ewbankkit
Acceptance test output:
025a74a 
% AWS_DEFAULT_REGION=ap-northeast-3 make testacc TESTARGS='-short -run=TestAccLambdaFunctionDataSource_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -short -run=TestAccLambdaFunctionDataSource_ -timeout 180m
=== RUN   TestAccLambdaFunctionDataSource_basic
=== PAUSE TestAccLambdaFunctionDataSource_basic
=== RUN   TestAccLambdaFunctionDataSource_version
=== PAUSE TestAccLambdaFunctionDataSource_version
=== RUN   TestAccLambdaFunctionDataSource_latestVersion
=== PAUSE TestAccLambdaFunctionDataSource_latestVersion
=== RUN   TestAccLambdaFunctionDataSource_unpublishedVersion
=== PAUSE TestAccLambdaFunctionDataSource_unpublishedVersion
=== RUN   TestAccLambdaFunctionDataSource_alias
=== PAUSE TestAccLambdaFunctionDataSource_alias
=== RUN   TestAccLambdaFunctionDataSource_layers
=== PAUSE TestAccLambdaFunctionDataSource_layers
=== RUN   TestAccLambdaFunctionDataSource_vpc
    function_data_source_test.go:178: skipping long-running test in short mode
--- SKIP: TestAccLambdaFunctionDataSource_vpc (0.00s)
=== RUN   TestAccLambdaFunctionDataSource_environment
=== PAUSE TestAccLambdaFunctionDataSource_environment
=== RUN   TestAccLambdaFunctionDataSource_fileSystem
    function_data_source_test.go:229: skipping long-running test in short mode
--- SKIP: TestAccLambdaFunctionDataSource_fileSystem (0.00s)
=== RUN   TestAccLambdaFunctionDataSource_image
=== PAUSE TestAccLambdaFunctionDataSource_image
=== RUN   TestAccLambdaFunctionDataSource_architectures
=== PAUSE TestAccLambdaFunctionDataSource_architectures
=== RUN   TestAccLambdaFunctionDataSource_ephemeralStorage
=== PAUSE TestAccLambdaFunctionDataSource_ephemeralStorage
=== CONT  TestAccLambdaFunctionDataSource_basic
=== CONT  TestAccLambdaFunctionDataSource_layers
=== CONT  TestAccLambdaFunctionDataSource_architectures
--- PASS: TestAccLambdaFunctionDataSource_architectures (47.11s)
=== CONT  TestAccLambdaFunctionDataSource_ephemeralStorage
--- PASS: TestAccLambdaFunctionDataSource_basic (53.92s)
=== CONT  TestAccLambdaFunctionDataSource_latestVersion
--- PASS: TestAccLambdaFunctionDataSource_layers (60.82s)
=== CONT  TestAccLambdaFunctionDataSource_image
    function_data_source_test.go:321: AWS_LAMBDA_IMAGE_LATEST_ID env var must be set for Lambda Function Data Source Image Support acceptance tests.
--- SKIP: TestAccLambdaFunctionDataSource_image (0.00s)
=== CONT  TestAccLambdaFunctionDataSource_alias
--- PASS: TestAccLambdaFunctionDataSource_ephemeralStorage (45.12s)
=== CONT  TestAccLambdaFunctionDataSource_version
--- PASS: TestAccLambdaFunctionDataSource_latestVersion (45.17s)
=== CONT  TestAccLambdaFunctionDataSource_environment
--- PASS: TestAccLambdaFunctionDataSource_alias (45.30s)
=== CONT  TestAccLambdaFunctionDataSource_unpublishedVersion
--- PASS: TestAccLambdaFunctionDataSource_version (45.17s)
--- PASS: TestAccLambdaFunctionDataSource_environment (45.97s)
--- PASS: TestAccLambdaFunctionDataSource_unpublishedVersion (45.07s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	156.367s
@ewbankkit
r/aws_lambda_function: Use 'ExactlyOneOf' and 'RequiredWith' for plan…
04997fe 
…-time argument verification.
@ewbankkit
Revert "r/aws_lambda_function: Use 'ExactlyOneOf' and 'RequiredWith' …
274698a 
…for plan-time argument verification."

This reverts commit 04997fe.
@ewbankkit
Revert "Revert "r/aws_lambda_function: Use 'ExactlyOneOf' and 'Requir…
bd986c7 
…edWith' for plan-time argument verification.""

This reverts commit 274698a.
@ewbankkit
r/aws_lambda_function: Tidy up resource Create.
f6acc05 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccLambdaFunction_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunction_ -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_disappears
=== PAUSE TestAccLambdaFunction_disappears
=== RUN   TestAccLambdaFunction_tags
=== PAUSE TestAccLambdaFunction_tags
=== RUN   TestAccLambdaFunction_unpublishedCodeUpdate
=== PAUSE TestAccLambdaFunction_unpublishedCodeUpdate
=== RUN   TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== RUN   TestAccLambdaFunction_concurrency
=== PAUSE TestAccLambdaFunction_concurrency
=== RUN   TestAccLambdaFunction_concurrencyCycle
=== PAUSE TestAccLambdaFunction_concurrencyCycle
=== RUN   TestAccLambdaFunction_expectFilenameAndS3Attributes
=== PAUSE TestAccLambdaFunction_expectFilenameAndS3Attributes
=== RUN   TestAccLambdaFunction_envVariables
=== PAUSE TestAccLambdaFunction_envVariables
=== RUN   TestAccLambdaFunction_EnvironmentVariables_noValue
=== PAUSE TestAccLambdaFunction_EnvironmentVariables_noValue
=== RUN   TestAccLambdaFunction_encryptedEnvVariables
=== PAUSE TestAccLambdaFunction_encryptedEnvVariables
=== RUN   TestAccLambdaFunction_nameValidation
=== PAUSE TestAccLambdaFunction_nameValidation
=== RUN   TestAccLambdaFunction_versioned
=== PAUSE TestAccLambdaFunction_versioned
=== RUN   TestAccLambdaFunction_versionedUpdate
=== PAUSE TestAccLambdaFunction_versionedUpdate
=== RUN   TestAccLambdaFunction_enablePublish
=== PAUSE TestAccLambdaFunction_enablePublish
=== RUN   TestAccLambdaFunction_disablePublish
=== PAUSE TestAccLambdaFunction_disablePublish
=== RUN   TestAccLambdaFunction_deadLetter
=== PAUSE TestAccLambdaFunction_deadLetter
=== RUN   TestAccLambdaFunction_deadLetterUpdated
=== PAUSE TestAccLambdaFunction_deadLetterUpdated
=== RUN   TestAccLambdaFunction_nilDeadLetter
=== PAUSE TestAccLambdaFunction_nilDeadLetter
=== RUN   TestAccLambdaFunction_fileSystem
=== PAUSE TestAccLambdaFunction_fileSystem
=== RUN   TestAccLambdaFunction_image
    function_test.go:901: Environment variable AWS_LAMBDA_IMAGE_LATEST_ID is not set
--- SKIP: TestAccLambdaFunction_image (0.00s)
=== RUN   TestAccLambdaFunction_architectures
=== PAUSE TestAccLambdaFunction_architectures
=== RUN   TestAccLambdaFunction_architecturesUpdate
=== PAUSE TestAccLambdaFunction_architecturesUpdate
=== RUN   TestAccLambdaFunction_architecturesWithLayer
=== PAUSE TestAccLambdaFunction_architecturesWithLayer
=== RUN   TestAccLambdaFunction_ephemeralStorage
=== PAUSE TestAccLambdaFunction_ephemeralStorage
=== RUN   TestAccLambdaFunction_tracing
=== PAUSE TestAccLambdaFunction_tracing
=== RUN   TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== PAUSE TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== RUN   TestAccLambdaFunction_layers
=== PAUSE TestAccLambdaFunction_layers
=== RUN   TestAccLambdaFunction_layersUpdate
=== PAUSE TestAccLambdaFunction_layersUpdate
=== RUN   TestAccLambdaFunction_vpc
=== PAUSE TestAccLambdaFunction_vpc
=== RUN   TestAccLambdaFunction_vpcRemoval
=== PAUSE TestAccLambdaFunction_vpcRemoval
=== RUN   TestAccLambdaFunction_vpcUpdate
=== PAUSE TestAccLambdaFunction_vpcUpdate
=== RUN   TestAccLambdaFunction_VPC_withInvocation
=== PAUSE TestAccLambdaFunction_VPC_withInvocation
=== RUN   TestAccLambdaFunction_VPCPublishNo_changes
=== PAUSE TestAccLambdaFunction_VPCPublishNo_changes
=== RUN   TestAccLambdaFunction_VPCPublishHas_changes
=== PAUSE TestAccLambdaFunction_VPCPublishHas_changes
=== RUN   TestAccLambdaFunction_VPC_properIAMDependencies
=== PAUSE TestAccLambdaFunction_VPC_properIAMDependencies
=== RUN   TestAccLambdaFunction_emptyVPC
=== PAUSE TestAccLambdaFunction_emptyVPC
=== RUN   TestAccLambdaFunction_s3
=== PAUSE TestAccLambdaFunction_s3
=== RUN   TestAccLambdaFunction_localUpdate
=== PAUSE TestAccLambdaFunction_localUpdate
=== RUN   TestAccLambdaFunction_LocalUpdate_nameOnly
=== PAUSE TestAccLambdaFunction_LocalUpdate_nameOnly
=== RUN   TestAccLambdaFunction_S3Update_basic
=== PAUSE TestAccLambdaFunction_S3Update_basic
=== RUN   TestAccLambdaFunction_S3Update_unversioned
=== PAUSE TestAccLambdaFunction_S3Update_unversioned
=== RUN   TestAccLambdaFunction_snapStart
=== PAUSE TestAccLambdaFunction_snapStart
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== RUN   TestAccLambdaFunction_Zip_validation
=== PAUSE TestAccLambdaFunction_Zip_validation
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_architecturesWithLayer
=== CONT  TestAccLambdaFunction_VPCPublishHas_changes
--- PASS: TestAccLambdaFunction_basic (44.73s)
--- PASS: TestAccLambdaFunction_Zip_validation (4.73s)
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_architecturesWithLayer (248.58s)
=== CONT  TestAccLambdaFunction_snapStart
--- PASS: TestAccLambdaFunction_snapStart (61.82s)
=== CONT  TestAccLambdaFunction_S3Update_unversioned
--- PASS: TestAccLambdaFunction_S3Update_unversioned (55.89s)
=== CONT  TestAccLambdaFunction_S3Update_basic
--- PASS: TestAccLambdaFunction_S3Update_basic (62.93s)
=== CONT  TestAccLambdaFunction_LocalUpdate_nameOnly
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (55.95s)
=== CONT  TestAccLambdaFunction_localUpdate
--- PASS: TestAccLambdaFunction_VPCPublishHas_changes (493.56s)
=== CONT  TestAccLambdaFunction_s3
--- PASS: TestAccLambdaFunction_s3 (34.77s)
=== CONT  TestAccLambdaFunction_emptyVPC
--- PASS: TestAccLambdaFunction_runtimes (488.48s)
=== CONT  TestAccLambdaFunction_VPC_properIAMDependencies
--- PASS: TestAccLambdaFunction_localUpdate (56.08s)
=== CONT  TestAccLambdaFunction_nameValidation
--- PASS: TestAccLambdaFunction_nameValidation (1.22s)
=== CONT  TestAccLambdaFunction_architecturesUpdate
--- PASS: TestAccLambdaFunction_emptyVPC (42.45s)
=== CONT  TestAccLambdaFunction_architectures
--- PASS: TestAccLambdaFunction_architectures (206.07s)
=== CONT  TestAccLambdaFunction_fileSystem
--- PASS: TestAccLambdaFunction_architecturesUpdate (235.46s)
=== CONT  TestAccLambdaFunction_concurrencyCycle
--- PASS: TestAccLambdaFunction_VPC_properIAMDependencies (256.81s)
=== CONT  TestAccLambdaFunction_encryptedEnvVariables
--- PASS: TestAccLambdaFunction_concurrencyCycle (65.18s)
=== CONT  TestAccLambdaFunction_EnvironmentVariables_noValue
--- PASS: TestAccLambdaFunction_encryptedEnvVariables (77.80s)
=== CONT  TestAccLambdaFunction_envVariables
--- PASS: TestAccLambdaFunction_EnvironmentVariables_noValue (43.23s)
--- PASS: TestAccLambdaFunction_expectFilenameAndS3Attributes (2.37s)
=== CONT  TestAccLambdaFunction_disablePublish
--- PASS: TestAccLambdaFunction_disablePublish (220.12s)
=== CONT  TestAccLambdaFunction_deadLetterUpdated
--- PASS: TestAccLambdaFunction_envVariables (276.91s)
=== CONT  TestAccLambdaFunction_deadLetter
--- PASS: TestAccLambdaFunction_deadLetterUpdated (62.54s)
=== CONT  TestAccLambdaFunction_unpublishedCodeUpdate
--- PASS: TestAccLambdaFunction_deadLetter (62.47s)
=== CONT  TestAccLambdaFunction_concurrency
--- PASS: TestAccLambdaFunction_unpublishedCodeUpdate (62.20s)
=== CONT  TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_concurrency (52.45s)
=== CONT  TestAccLambdaFunction_vpc
--- PASS: TestAccLambdaFunction_codeSigning (67.42s)
=== CONT  TestAccLambdaFunction_VPCPublishNo_changes
--- PASS: TestAccLambdaFunction_vpc (564.21s)
=== CONT  TestAccLambdaFunction_VPC_withInvocation
--- PASS: TestAccLambdaFunction_fileSystem (900.74s)
=== CONT  TestAccLambdaFunction_vpcUpdate
--- PASS: TestAccLambdaFunction_VPCPublishNo_changes (409.46s)
=== CONT  TestAccLambdaFunction_vpcRemoval
--- PASS: TestAccLambdaFunction_VPC_withInvocation (579.69s)
=== CONT  TestAccLambdaFunction_tags
--- PASS: TestAccLambdaFunction_tags (240.63s)
=== CONT  TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
--- PASS: TestAccLambdaFunction_vpcRemoval (429.78s)
=== CONT  TestAccLambdaFunction_nilDeadLetter
--- PASS: TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables (35.36s)
=== CONT  TestAccLambdaFunction_enablePublish
--- PASS: TestAccLambdaFunction_nilDeadLetter (14.48s)
=== CONT  TestAccLambdaFunction_layersUpdate
--- PASS: TestAccLambdaFunction_enablePublish (61.29s)
=== CONT  TestAccLambdaFunction_versionedUpdate
--- PASS: TestAccLambdaFunction_layersUpdate (66.00s)
=== CONT  TestAccLambdaFunction_layers
--- PASS: TestAccLambdaFunction_layers (39.15s)
=== CONT  TestAccLambdaFunction_tracing
--- PASS: TestAccLambdaFunction_versionedUpdate (73.68s)
=== CONT  TestAccLambdaFunction_disappears
--- PASS: TestAccLambdaFunction_vpcUpdate (630.41s)
=== CONT  TestAccLambdaFunction_versioned
--- PASS: TestAccLambdaFunction_tracing (61.63s)
=== CONT  TestAccLambdaFunction_ephemeralStorage
--- PASS: TestAccLambdaFunction_disappears (40.33s)
--- PASS: TestAccLambdaFunction_versioned (40.68s)
--- PASS: TestAccLambdaFunction_ephemeralStorage (53.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	2392.314s
@ewbankkit
r/aws_lambda_function: Tidy up resource Update.
f61c21e 
Acceptance test output:

% make testacc TESTARGS='-run=TestAccLambdaFunction_' PKG=lambda ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 3  -run=TestAccLambdaFunction_ -timeout 180m
=== RUN   TestAccLambdaFunction_basic
=== PAUSE TestAccLambdaFunction_basic
=== RUN   TestAccLambdaFunction_disappears
=== PAUSE TestAccLambdaFunction_disappears
=== RUN   TestAccLambdaFunction_tags
=== PAUSE TestAccLambdaFunction_tags
=== RUN   TestAccLambdaFunction_unpublishedCodeUpdate
=== PAUSE TestAccLambdaFunction_unpublishedCodeUpdate
=== RUN   TestAccLambdaFunction_codeSigning
=== PAUSE TestAccLambdaFunction_codeSigning
=== RUN   TestAccLambdaFunction_concurrency
=== PAUSE TestAccLambdaFunction_concurrency
=== RUN   TestAccLambdaFunction_concurrencyCycle
=== PAUSE TestAccLambdaFunction_concurrencyCycle
=== RUN   TestAccLambdaFunction_expectFilenameAndS3Attributes
=== PAUSE TestAccLambdaFunction_expectFilenameAndS3Attributes
=== RUN   TestAccLambdaFunction_envVariables
=== PAUSE TestAccLambdaFunction_envVariables
=== RUN   TestAccLambdaFunction_EnvironmentVariables_noValue
=== PAUSE TestAccLambdaFunction_EnvironmentVariables_noValue
=== RUN   TestAccLambdaFunction_encryptedEnvVariables
=== PAUSE TestAccLambdaFunction_encryptedEnvVariables
=== RUN   TestAccLambdaFunction_nameValidation
=== PAUSE TestAccLambdaFunction_nameValidation
=== RUN   TestAccLambdaFunction_versioned
=== PAUSE TestAccLambdaFunction_versioned
=== RUN   TestAccLambdaFunction_versionedUpdate
=== PAUSE TestAccLambdaFunction_versionedUpdate
=== RUN   TestAccLambdaFunction_enablePublish
=== PAUSE TestAccLambdaFunction_enablePublish
=== RUN   TestAccLambdaFunction_disablePublish
=== PAUSE TestAccLambdaFunction_disablePublish
=== RUN   TestAccLambdaFunction_deadLetter
=== PAUSE TestAccLambdaFunction_deadLetter
=== RUN   TestAccLambdaFunction_deadLetterUpdated
=== PAUSE TestAccLambdaFunction_deadLetterUpdated
=== RUN   TestAccLambdaFunction_nilDeadLetter
=== PAUSE TestAccLambdaFunction_nilDeadLetter
=== RUN   TestAccLambdaFunction_fileSystem
=== PAUSE TestAccLambdaFunction_fileSystem
=== RUN   TestAccLambdaFunction_image
    function_test.go:901: Environment variable AWS_LAMBDA_IMAGE_LATEST_ID is not set
--- SKIP: TestAccLambdaFunction_image (0.00s)
=== RUN   TestAccLambdaFunction_architectures
=== PAUSE TestAccLambdaFunction_architectures
=== RUN   TestAccLambdaFunction_architecturesUpdate
=== PAUSE TestAccLambdaFunction_architecturesUpdate
=== RUN   TestAccLambdaFunction_architecturesWithLayer
=== PAUSE TestAccLambdaFunction_architecturesWithLayer
=== RUN   TestAccLambdaFunction_ephemeralStorage
=== PAUSE TestAccLambdaFunction_ephemeralStorage
=== RUN   TestAccLambdaFunction_tracing
=== PAUSE TestAccLambdaFunction_tracing
=== RUN   TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== PAUSE TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
=== RUN   TestAccLambdaFunction_layers
=== PAUSE TestAccLambdaFunction_layers
=== RUN   TestAccLambdaFunction_layersUpdate
=== PAUSE TestAccLambdaFunction_layersUpdate
=== RUN   TestAccLambdaFunction_vpc
=== PAUSE TestAccLambdaFunction_vpc
=== RUN   TestAccLambdaFunction_vpcRemoval
=== PAUSE TestAccLambdaFunction_vpcRemoval
=== RUN   TestAccLambdaFunction_vpcUpdate
=== PAUSE TestAccLambdaFunction_vpcUpdate
=== RUN   TestAccLambdaFunction_VPC_withInvocation
=== PAUSE TestAccLambdaFunction_VPC_withInvocation
=== RUN   TestAccLambdaFunction_VPCPublishNo_changes
=== PAUSE TestAccLambdaFunction_VPCPublishNo_changes
=== RUN   TestAccLambdaFunction_VPCPublishHas_changes
=== PAUSE TestAccLambdaFunction_VPCPublishHas_changes
=== RUN   TestAccLambdaFunction_VPC_properIAMDependencies
=== PAUSE TestAccLambdaFunction_VPC_properIAMDependencies
=== RUN   TestAccLambdaFunction_emptyVPC
=== PAUSE TestAccLambdaFunction_emptyVPC
=== RUN   TestAccLambdaFunction_s3
=== PAUSE TestAccLambdaFunction_s3
=== RUN   TestAccLambdaFunction_localUpdate
=== PAUSE TestAccLambdaFunction_localUpdate
=== RUN   TestAccLambdaFunction_LocalUpdate_nameOnly
=== PAUSE TestAccLambdaFunction_LocalUpdate_nameOnly
=== RUN   TestAccLambdaFunction_S3Update_basic
=== PAUSE TestAccLambdaFunction_S3Update_basic
=== RUN   TestAccLambdaFunction_S3Update_unversioned
=== PAUSE TestAccLambdaFunction_S3Update_unversioned
=== RUN   TestAccLambdaFunction_snapStart
=== PAUSE TestAccLambdaFunction_snapStart
=== RUN   TestAccLambdaFunction_runtimes
=== PAUSE TestAccLambdaFunction_runtimes
=== RUN   TestAccLambdaFunction_Zip_validation
=== PAUSE TestAccLambdaFunction_Zip_validation
=== CONT  TestAccLambdaFunction_basic
=== CONT  TestAccLambdaFunction_architecturesWithLayer
=== CONT  TestAccLambdaFunction_nameValidation
--- PASS: TestAccLambdaFunction_nameValidation (2.54s)
=== CONT  TestAccLambdaFunction_architecturesUpdate
--- PASS: TestAccLambdaFunction_basic (44.63s)
=== CONT  TestAccLambdaFunction_architectures
--- PASS: TestAccLambdaFunction_architecturesUpdate (80.00s)
=== CONT  TestAccLambdaFunction_fileSystem
--- PASS: TestAccLambdaFunction_architecturesWithLayer (90.12s)
=== CONT  TestAccLambdaFunction_nilDeadLetter
--- PASS: TestAccLambdaFunction_architectures (48.41s)
=== CONT  TestAccLambdaFunction_deadLetterUpdated
--- PASS: TestAccLambdaFunction_nilDeadLetter (14.06s)
=== CONT  TestAccLambdaFunction_deadLetter
--- PASS: TestAccLambdaFunction_deadLetterUpdated (55.37s)
=== CONT  TestAccLambdaFunction_disablePublish
--- PASS: TestAccLambdaFunction_deadLetter (65.30s)
=== CONT  TestAccLambdaFunction_enablePublish
--- PASS: TestAccLambdaFunction_disablePublish (58.27s)
=== CONT  TestAccLambdaFunction_versionedUpdate
--- PASS: TestAccLambdaFunction_enablePublish (70.79s)
=== CONT  TestAccLambdaFunction_versioned
--- PASS: TestAccLambdaFunction_versioned (165.22s)
=== CONT  TestAccLambdaFunction_vpc
--- PASS: TestAccLambdaFunction_versionedUpdate (218.70s)
=== CONT  TestAccLambdaFunction_VPCPublishNo_changes
--- PASS: TestAccLambdaFunction_fileSystem (680.25s)
=== CONT  TestAccLambdaFunction_VPC_withInvocation
--- PASS: TestAccLambdaFunction_vpc (420.51s)
=== CONT  TestAccLambdaFunction_vpcUpdate
--- PASS: TestAccLambdaFunction_VPCPublishNo_changes (581.06s)
=== CONT  TestAccLambdaFunction_vpcRemoval
--- PASS: TestAccLambdaFunction_VPC_withInvocation (423.68s)
=== CONT  TestAccLambdaFunction_S3Update_basic
--- PASS: TestAccLambdaFunction_S3Update_basic (58.92s)
=== CONT  TestAccLambdaFunction_Zip_validation
--- PASS: TestAccLambdaFunction_Zip_validation (3.89s)
=== CONT  TestAccLambdaFunction_runtimes
--- PASS: TestAccLambdaFunction_vpcRemoval (400.15s)
=== CONT  TestAccLambdaFunction_VPCPublishHas_changes
--- PASS: TestAccLambdaFunction_vpcUpdate (764.54s)
=== CONT  TestAccLambdaFunction_snapStart
--- PASS: TestAccLambdaFunction_snapStart (72.41s)
=== CONT  TestAccLambdaFunction_LocalUpdate_nameOnly
--- PASS: TestAccLambdaFunction_runtimes (418.75s)
=== CONT  TestAccLambdaFunction_localUpdate
--- PASS: TestAccLambdaFunction_LocalUpdate_nameOnly (61.68s)
=== CONT  TestAccLambdaFunction_S3Update_unversioned
--- PASS: TestAccLambdaFunction_localUpdate (56.38s)
=== CONT  TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables
--- PASS: TestAccLambdaFunction_KMSKeyARN_noEnvironmentVariables (35.45s)
=== CONT  TestAccLambdaFunction_layersUpdate
--- PASS: TestAccLambdaFunction_S3Update_unversioned (56.81s)
=== CONT  TestAccLambdaFunction_layers
--- PASS: TestAccLambdaFunction_layers (45.48s)
=== CONT  TestAccLambdaFunction_tracing
--- PASS: TestAccLambdaFunction_layersUpdate (64.11s)
=== CONT  TestAccLambdaFunction_s3
--- PASS: TestAccLambdaFunction_s3 (34.92s)
=== CONT  TestAccLambdaFunction_emptyVPC
--- PASS: TestAccLambdaFunction_tracing (53.94s)
=== CONT  TestAccLambdaFunction_concurrencyCycle
--- PASS: TestAccLambdaFunction_VPCPublishHas_changes (464.02s)
=== CONT  TestAccLambdaFunction_VPC_properIAMDependencies
--- PASS: TestAccLambdaFunction_emptyVPC (33.99s)
=== CONT  TestAccLambdaFunction_encryptedEnvVariables
--- PASS: TestAccLambdaFunction_concurrencyCycle (65.09s)
=== CONT  TestAccLambdaFunction_unpublishedCodeUpdate
--- PASS: TestAccLambdaFunction_VPC_properIAMDependencies (252.89s)
=== CONT  TestAccLambdaFunction_EnvironmentVariables_noValue
--- PASS: TestAccLambdaFunction_unpublishedCodeUpdate (195.58s)
=== CONT  TestAccLambdaFunction_envVariables
--- PASS: TestAccLambdaFunction_encryptedEnvVariables (249.47s)
=== CONT  TestAccLambdaFunction_concurrency
--- PASS: TestAccLambdaFunction_EnvironmentVariables_noValue (34.95s)
=== CONT  TestAccLambdaFunction_expectFilenameAndS3Attributes
--- PASS: TestAccLambdaFunction_expectFilenameAndS3Attributes (1.27s)
=== CONT  TestAccLambdaFunction_codeSigning
--- PASS: TestAccLambdaFunction_concurrency (50.16s)
=== CONT  TestAccLambdaFunction_ephemeralStorage
--- PASS: TestAccLambdaFunction_envVariables (98.53s)
=== CONT  TestAccLambdaFunction_tags
--- PASS: TestAccLambdaFunction_codeSigning (69.76s)
=== CONT  TestAccLambdaFunction_disappears
--- PASS: TestAccLambdaFunction_ephemeralStorage (56.98s)
--- PASS: TestAccLambdaFunction_disappears (44.71s)
--- PASS: TestAccLambdaFunction_tags (74.22s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lambda	2305.107s
@ewbankkit
r/aws_lambda_function: Add Update timeout.
2a58d99
@ewbankkit
r/aws_lambda_function: Don't persist invalid source code filename or …
05c2dce 
…S3 attributes on Update.
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 19, 2023
@ewbankkit ewbankkit merged commit c0d8d88 into main Jan 19, 2023
@ewbankkit ewbankkit deleted the b-aws_lambda_function.invoke_arn branch January 19, 2023 17:07
@github-actions github-actions bot added this to the v4.51.0 milestone Jan 19, 2023
github-actions bot pushed a commit that referenced this pull request Jan 19, 2023
Update CHANGELOG.md for #28963
21626de
@github-actions
Copy link

This functionality has been released in v4.51.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@pcallewaert pcallewaert mentioned this pull request Jan 23, 2023
Closed
@justinretzolk justinretzolk mentioned this pull request Jan 26, 2023
Open
@grimm26 grimm26 mentioned this pull request Feb 2, 2023
Closed
@justinretzolk justinretzolk mentioned this pull request Feb 2, 2023
Open
@ewbankkit ewbankkit mentioned this pull request Feb 3, 2023
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. service/lambda Issues and PRs that pertain to the lambda service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.51.0
1 participant
@ewbankkit