Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wafv2/web_acl: Rule add body oversize_handling #29082

Merged
merged 6 commits into from
Jan 25, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/29082.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_wafv2_rule_group: Add `oversize_handling` argument to `body` block of the `field_to_match` block
```
32 changes: 30 additions & 2 deletions internal/service/wafv2/flex.go
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ func expandFieldToMatch(l []interface{}) *wafv2.FieldToMatch {
}

if v, ok := m["body"]; ok && len(v.([]interface{})) > 0 {
f.Body = &wafv2.Body{}
f.Body = expandBody(v.([]interface{}))
}

if v, ok := m["cookies"]; ok && len(v.([]interface{})) > 0 {
Expand Down Expand Up @@ -550,6 +550,22 @@ func expandJSONBody(l []interface{}) *wafv2.JsonBody {
return jsonBody
}

func expandBody(l []interface{}) *wafv2.Body {
if len(l) == 0 || l[0] == nil {
return nil
}

m := l[0].(map[string]interface{})

body := &wafv2.Body{}

if v, ok := m["oversize_handling"].(string); ok && v != "" {
body.OversizeHandling = aws.String(v)
}

return body
}

func expandJSONMatchPattern(l []interface{}) *wafv2.JsonMatchPattern {
if len(l) == 0 || l[0] == nil {
return nil
Expand Down Expand Up @@ -1500,7 +1516,7 @@ func flattenFieldToMatch(f *wafv2.FieldToMatch) interface{} {
}

if f.Body != nil {
m["body"] = make([]map[string]interface{}, 1)
m["body"] = flattenBody(f.Body)
}

if f.Cookies != nil {
Expand Down Expand Up @@ -1611,6 +1627,18 @@ func flattenJSONBody(b *wafv2.JsonBody) interface{} {
return []interface{}{m}
}

func flattenBody(b *wafv2.Body) interface{} {
if b == nil {
return []interface{}{}
}

m := map[string]interface{}{
"oversize_handling": aws.StringValue(b.OversizeHandling),
}

return []interface{}{m}
}

func flattenJSONMatchPattern(p *wafv2.JsonMatchPattern) []interface{} {
if p == nil {
return []interface{}{}
Expand Down
15 changes: 14 additions & 1 deletion internal/service/wafv2/schemas.go
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func fieldToMatchBaseSchema() *schema.Resource {
return &schema.Resource{
Schema: map[string]*schema.Schema{
"all_query_arguments": emptySchema(),
"body": emptySchema(),
"body": bodySchema(),
"cookies": cookiesSchema(),
"headers": headersSchema(),
"json_body": jsonBodySchema(),
Expand Down Expand Up @@ -734,6 +734,19 @@ func cookiesMatchPatternSchema() *schema.Schema {
}
}

func bodySchema() *schema.Schema {
return &schema.Schema{
Type: schema.TypeList,
Optional: true,
MaxItems: 1,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"oversize_handling": oversizeHandlingOptionalSchema(wafv2.OversizeHandlingContinue),
},
},
}
}

func oversizeHandlingOptionalSchema(defaultValue string) *schema.Schema {
return &schema.Schema{
Type: schema.TypeString,
Expand Down
99 changes: 99 additions & 0 deletions internal/service/wafv2/web_acl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -980,6 +980,54 @@ func TestAccWAFV2WebACL_ByteMatchStatement_jsonBody(t *testing.T) {
})
}

func TestAccWAFV2WebACL_ByteMatchStatement_body(t *testing.T) {
ctx := acctest.Context(t)
var v wafv2.WebACL
webACLName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)
resourceName := "aws_wafv2_web_acl.test"

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(t); testAccPreCheckScopeRegional(ctx, t) },
ErrorCheck: acctest.ErrorCheck(t, wafv2.EndpointsID),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
CheckDestroy: testAccCheckWebACLDestroy(ctx),
Steps: []resource.TestStep{
{
Config: testAccWebACLConfig_byteMatchStatementBody(webACLName, wafv2.OversizeHandlingNoMatch),
Check: resource.ComposeTestCheckFunc(
testAccCheckWebACLExists(ctx, resourceName, &v),
acctest.MatchResourceAttrRegionalARN(resourceName, "arn", "wafv2", regexp.MustCompile(`regional/webacl/.+$`)),
resource.TestCheckResourceAttr(resourceName, "name", webACLName),
resource.TestCheckResourceAttr(resourceName, "rule.#", "1"),
resource.TestCheckTypeSetElemNestedAttrs(resourceName, "rule.*", map[string]string{
"statement.0.byte_match_statement.0.field_to_match.0.body.#": "1",
"statement.0.byte_match_statement.0.field_to_match.0.body.0.oversize_handling": "NO_MATCH",
}),
),
},
{
Config: testAccWebACLConfig_byteMatchStatementBody(webACLName, wafv2.OversizeHandlingContinue),
Check: resource.ComposeTestCheckFunc(
testAccCheckWebACLExists(ctx, resourceName, &v),
acctest.MatchResourceAttrRegionalARN(resourceName, "arn", "wafv2", regexp.MustCompile(`regional/webacl/.+$`)),
resource.TestCheckResourceAttr(resourceName, "name", webACLName),
resource.TestCheckResourceAttr(resourceName, "rule.#", "1"),
resource.TestCheckTypeSetElemNestedAttrs(resourceName, "rule.*", map[string]string{
"statement.0.byte_match_statement.0.field_to_match.0.body.#": "1",
"statement.0.byte_match_statement.0.field_to_match.0.body.0.oversize_handling": "CONTINUE",
}),
),
},
{
ResourceName: resourceName,
ImportState: true,
ImportStateVerify: true,
ImportStateIdFunc: testAccWebACLImportStateIdFunc(resourceName),
},
},
})
}

func TestAccWAFV2WebACL_GeoMatch_basic(t *testing.T) {
ctx := acctest.Context(t)
var v wafv2.WebACL
Expand Down Expand Up @@ -2245,6 +2293,57 @@ resource "aws_wafv2_web_acl" "test" {
`, name, matchScope, invalidFallbackBehavior, oversizeHandling, matchPattern)
}

func testAccWebACLConfig_byteMatchStatementBody(name, oversizeHandling string) string {
return fmt.Sprintf(`
resource "aws_wafv2_web_acl" "test" {
name = "%[1]s"
description = "%[1]s"
scope = "REGIONAL"

default_action {
allow {}
}

rule {
name = "rule-1"
priority = 1

action {
count {}
}

statement {
byte_match_statement {
field_to_match {
body {
oversize_handling = "%[2]s"
}
}
positional_constraint = "CONTAINS_WORD"
search_string = "Buddy"
text_transformation {
priority = 0
type = "NONE"
}
}
}

visibility_config {
cloudwatch_metrics_enabled = false
metric_name = "friendly-rule-metric-name"
sampled_requests_enabled = false
}
}

visibility_config {
cloudwatch_metrics_enabled = false
metric_name = "friendly-metric-name"
sampled_requests_enabled = false
}
}
`, name, oversizeHandling)
}

func testAccWebACLConfig_geoMatchStatement(name, countryCodes string) string {
return fmt.Sprintf(`
resource "aws_wafv2_web_acl" "test" {
Expand Down