-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_dms_endpoint: Updates S3 Endpoint tests for extra connection attributes #29189
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
$ make testacc PKG=dms TESTS=TestAccDMSEndpoint_S3_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/dms/... -v -count 1 -parallel 20 -run='TestAccDMSEndpoint_S3_' -timeout 180m
=== RUN TestAccDMSEndpoint_S3_basic
=== PAUSE TestAccDMSEndpoint_S3_basic
=== RUN TestAccDMSEndpoint_S3_key
=== PAUSE TestAccDMSEndpoint_S3_key
=== RUN TestAccDMSEndpoint_S3_extraConnectionAttributes
=== PAUSE TestAccDMSEndpoint_S3_extraConnectionAttributes
=== RUN TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== RUN TestAccDMSEndpoint_S3_SSEKMSKeyId
=== PAUSE TestAccDMSEndpoint_S3_SSEKMSKeyId
=== CONT TestAccDMSEndpoint_S3_basic
=== CONT TestAccDMSEndpoint_S3_SSEKMSKeyARN
=== CONT TestAccDMSEndpoint_S3_SSEKMSKeyId
=== CONT TestAccDMSEndpoint_S3_extraConnectionAttributes
=== CONT TestAccDMSEndpoint_S3_key
--- PASS: TestAccDMSEndpoint_S3_key (14.08s)
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyARN (45.89s)
--- PASS: TestAccDMSEndpoint_S3_extraConnectionAttributes (46.57s)
--- PASS: TestAccDMSEndpoint_S3_SSEKMSKeyId (46.65s)
--- PASS: TestAccDMSEndpoint_S3_basic (68.65s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/dms 72.337s
This functionality has been released in v4.53.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Adds test to confirm that
extra_connection_attributes
is correctly updated for DMS Endpoints.Output from Acceptance Testing