Add New Datasource: Appmesh Virtual Router

[alowder94]

Description

This creates a data source for AWS Appmesh Virtual Router.

This will allow you to pull a virtual router into a project other than the one it was created in - which will allow for greater modularization of appmesh resources. Current state - if you want to use a virtual router, the route and node that it points to must also be created in the same project.

Relations

Closes #26908.
Relates #17590.

References

Test Command Used: go test -v internal/service/appmesh/virtual_router_data_source_test.go internal/service/appmesh/virtual_router_data_source.go internal/service/appmesh/flex.go internal/service/appmesh/virtual_router_test.go internal/service/appmesh/tags_gen.go

Only one test is written for this data source because both mesh_name and name of the router are required - since this creates a 1 to 1 relationship no optional fields are needed, and no disappears test needed for data source, leaving only the basic test.

Output from Acceptance Testing

$ go test -v internal/service/appmesh/virtual_router_data_source_test.go internal/service/appmesh/virtual_router_data_source.go internal/service/appmesh/flex.go internal/service/appmesh/virtual_router_test.go internal/service/appmesh/tags_gen.go
=== RUN TestAccAppMeshVirtualRouterDataSource_basic
=== PAUSE TestAccAppMeshVirtualRouterDataSource_basic
=== CONT TestAccAppMeshVirtualRouterDataSource_basic
--- PASS: TestAccAppMeshVirtualRouterDataSource_basic (50.74s)
PASS
ok command-line-arguments 65.793s

$ make testacc TESTS=TestAccAppMeshVirtualRouterDataSource_basic PKG=appmesh

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @alowder94 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[alowder94]

My organization does not allow maintainer access

[alowder94]

@ewbankkit When you have a chance, can you trigger the check run for me so I can see if there are any other changes needed before this PR is ready? Thanks!

[alowder94]

Closing as this PR was merged into another and merged into main from there

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.