Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contributing document #2951

Merged
merged 3 commits into from
Jan 12, 2018
Merged

Update Contributing document #2951

merged 3 commits into from
Jan 12, 2018

Conversation

drewsonne
Copy link
Contributor

  • Removed two block references to the core terraform code base as this provider is no longer in the core repo
  • Added note about putting vendor updates and additions in a separate PR
  • Started shifting examples from Azure to AWS

@drewsonne
Use AWS example instead of Azure
98f726a 
This is the AWS provider, so we should probably use AWS examples
@drewsonne
Add instructions for vendor updates
fee693b
@drewsonne
Removed reference to Core fixes
1632298 
This provider is no longer in the core repo, so this document does not relate to core features
radeksimko
radeksimko approved these changes Jan 12, 2018
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@radeksimko radeksimko added the documentation Introduces or discusses updates to documentation. label Jan 12, 2018
@radeksimko radeksimko merged commit 83fe925 into hashicorp:master Jan 12, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drewsonne @radeksimko