Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add resource: aws_verifiedaccess_instance #29742

Closed

Conversation

silvaalbert
Copy link
Contributor

@silvaalbert silvaalbert commented Mar 1, 2023

Description

add resource: aws_verifiedaccess_instance

Relations

Relates #29689

References

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_CreateVerifiedAccessInstance.html

Output from Acceptance Testing

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run='TestAccVerifiedAccessInstance'  -timeout 180m
=== RUN   TestAccVerifiedAccessInstance_basic
=== PAUSE TestAccVerifiedAccessInstance_basic
=== RUN   TestAccVerifiedAccessInstance_tags
=== PAUSE TestAccVerifiedAccessInstance_tags
=== RUN   TestAccVerifiedAccessInstance_disappears
=== PAUSE TestAccVerifiedAccessInstance_disappears
=== CONT  TestAccVerifiedAccessInstance_basic
=== CONT  TestAccVerifiedAccessInstance_disappears
=== CONT  TestAccVerifiedAccessInstance_tags
--- PASS: TestAccVerifiedAccessInstance_disappears (7.11s)
--- PASS: TestAccVerifiedAccessInstance_basic (9.15s)
--- PASS: TestAccVerifiedAccessInstance_tags (18.82s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	22.491s
...

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 1, 2023
@breathingdust breathingdust added the partner Contribution from a partner. label Mar 15, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. partner Contribution from a partner. service/verifiedaccess Issues and PRs that pertain to the verifiedaccess service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants